Merge #1402: Overhaul stats: add a configuration option to enable/disable stats per server

57d884d refactor: [#1401] add config option to enable/disable tracker usage stats per server (Jose Celano)

Pull request description:

  Add a configuration option to enable/disable stats per server. It does not have any effect yet.

ACKs for top commit:
  josecelano:
    ACK 57d884d

Tree-SHA512: 292f82fe1e505ea4c7f485ce46ff7356ba96ebd2e9ed5d548da5532d9e75b41eb011f25fd31f467237fd8652faaad0dcf12360d18a1c166059e49350a3f6cc25

Author: josecelano

packages/configuration/src/v2_0_0/core.rs

@@ -103,6 +103,7 @@ impl Core {
     fn default_tracker_policy() -> TrackerPolicy {
         TrackerPolicy::default()
     }
+
     fn default_tracker_usage_statistics() -> bool {
         true
     }

packages/configuration/src/v2_0_0/http_tracker.rs

@@ -19,13 +19,18 @@ pub struct HttpTracker {
     /// TSL config.
     #[serde(default = "HttpTracker::default_tsl_config")]
     pub tsl_config: Option<TslConfig>,
+
+    /// Weather the tracker should collect statistics about tracker usage.
+    #[serde(default = "HttpTracker::default_tracker_usage_statistics")]
+    pub tracker_usage_statistics: bool,
 }
 
 impl Default for HttpTracker {
     fn default() -> Self {
         Self {
             bind_address: Self::default_bind_address(),
             tsl_config: Self::default_tsl_config(),
+            tracker_usage_statistics: Self::default_tracker_usage_statistics(),
         }
     }
 }
@@ -38,4 +43,8 @@ impl HttpTracker {
     fn default_tsl_config() -> Option<TslConfig> {
         None
     }
+
+    fn default_tracker_usage_statistics() -> bool {
+        false
+    }
 }

packages/configuration/src/v2_0_0/udp_tracker.rs

@@ -16,12 +16,17 @@ pub struct UdpTracker {
     /// the client as the `ConnectionId`.
     #[serde(default = "UdpTracker::default_cookie_lifetime")]
     pub cookie_lifetime: Duration,
+
+    /// Weather the tracker should collect statistics about tracker usage.
+    #[serde(default = "UdpTracker::default_tracker_usage_statistics")]
+    pub tracker_usage_statistics: bool,
 }
 impl Default for UdpTracker {
     fn default() -> Self {
         Self {
             bind_address: Self::default_bind_address(),
             cookie_lifetime: Self::default_cookie_lifetime(),
+            tracker_usage_statistics: Self::default_tracker_usage_statistics(),
         }
     }
 }
@@ -34,4 +39,8 @@ impl UdpTracker {
     fn default_cookie_lifetime() -> Duration {
         Duration::from_secs(120)
     }
+
+    fn default_tracker_usage_statistics() -> bool {
+        false
+    }
 }

packages/test-helpers/src/configuration.rs

@@ -55,13 +55,15 @@ pub fn ephemeral() -> Configuration {
     config.udp_trackers = Some(vec![UdpTracker {
         bind_address: SocketAddr::new(IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1)), udp_port),
         cookie_lifetime: Duration::from_secs(120),
+        tracker_usage_statistics: true,
     }]);
 
     // Ephemeral socket address for HTTP tracker
     let http_port = 0u16;
     config.http_trackers = Some(vec![HttpTracker {
         bind_address: SocketAddr::new(IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1)), http_port),
         tsl_config: None,
+        tracker_usage_statistics: true,
     }]);
 
     let temp_file = ephemeral_sqlite_database();