Merge #1471: Fix Clippy errors

53c8694 fix: clippy errors (Jose Celano)

Pull request description:

  Fix Clippy errors.

ACKs for top commit:
  josecelano:
    ACK 53c8694

Tree-SHA512: 3c3cf86e3c7f5762564eb5c3b8535029b3d1e31c538a8505446514e8939b5aaeb90f2c950f54907704dfdc9ab7c368f19096f9c678a59a78279f01accbf68022

Author: josecelano

packages/http-tracker-core/src/statistics/mod.rs

@@ -19,7 +19,7 @@ pub fn describe_metrics() -> Metrics {
     metrics.metric_collection.describe_counter(
         &metric_name!(HTTP_TRACKER_CORE_REQUESTS_RECEIVED_TOTAL),
         Some(Unit::Count),
-        Some(MetricDescription::new("Total number of HTTP requests received")),
+        Some(&MetricDescription::new("Total number of HTTP requests received")),
     );
 
     metrics

packages/metrics/src/metric_collection.rs

@@ -57,7 +57,7 @@ impl MetricCollection {
 
     // Counter-specific methods
 
-    pub fn describe_counter(&mut self, name: &MetricName, opt_unit: Option<Unit>, opt_description: Option<MetricDescription>) {
+    pub fn describe_counter(&mut self, name: &MetricName, opt_unit: Option<Unit>, opt_description: Option<&MetricDescription>) {
         tracing::info!(target: METRICS_TARGET, type = "counter", name = name.to_string(), unit = ?opt_unit, description = ?opt_description);
         self.counters.ensure_metric_exists(name);
     }
@@ -99,7 +99,7 @@ impl MetricCollection {
 
     // Gauge-specific methods
 
-    pub fn describe_gauge(&mut self, name: &MetricName, opt_unit: Option<Unit>, opt_description: Option<MetricDescription>) {
+    pub fn describe_gauge(&mut self, name: &MetricName, opt_unit: Option<Unit>, opt_description: Option<&MetricDescription>) {
         tracing::info!(target: METRICS_TARGET, type = "gauge", name = name.to_string(), unit = ?opt_unit, description = ?opt_description);
         self.gauges.ensure_metric_exists(name);
     }

packages/udp-tracker-core/src/statistics/mod.rs

@@ -19,7 +19,7 @@ pub fn describe_metrics() -> Metrics {
     metrics.metric_collection.describe_counter(
         &metric_name!(UDP_TRACKER_CORE_REQUESTS_RECEIVED_TOTAL),
         Some(Unit::Count),
-        Some(MetricDescription::new("Total number of UDP requests received")),
+        Some(&MetricDescription::new("Total number of UDP requests received")),
     );
 
     metrics

packages/udp-tracker-server/src/statistics/mod.rs

@@ -25,43 +25,43 @@ pub fn describe_metrics() -> Metrics {
     metrics.metric_collection.describe_counter(
         &metric_name!(UDP_TRACKER_SERVER_REQUESTS_ABORTED_TOTAL),
         Some(Unit::Count),
-        Some(MetricDescription::new("Total number of UDP requests aborted")),
+        Some(&MetricDescription::new("Total number of UDP requests aborted")),
     );
 
     metrics.metric_collection.describe_counter(
         &metric_name!(UDP_TRACKER_SERVER_REQUESTS_BANNED_TOTAL),
         Some(Unit::Count),
-        Some(MetricDescription::new("Total number of UDP requests banned")),
+        Some(&MetricDescription::new("Total number of UDP requests banned")),
     );
 
     metrics.metric_collection.describe_counter(
         &metric_name!(UDP_TRACKER_SERVER_REQUESTS_RECEIVED_TOTAL),
         Some(Unit::Count),
-        Some(MetricDescription::new("Total number of UDP requests received")),
+        Some(&MetricDescription::new("Total number of UDP requests received")),
     );
 
     metrics.metric_collection.describe_counter(
         &metric_name!(UDP_TRACKER_SERVER_REQUESTS_ACCEPTED_TOTAL),
         Some(Unit::Count),
-        Some(MetricDescription::new("Total number of UDP requests accepted")),
+        Some(&MetricDescription::new("Total number of UDP requests accepted")),
     );
 
     metrics.metric_collection.describe_counter(
         &metric_name!(UDP_TRACKER_SERVER_RESPONSES_SENT_TOTAL),
         Some(Unit::Count),
-        Some(MetricDescription::new("Total number of UDP responses sent")),
+        Some(&MetricDescription::new("Total number of UDP responses sent")),
     );
 
     metrics.metric_collection.describe_counter(
         &metric_name!(UDP_TRACKER_SERVER_ERRORS_TOTAL),
         Some(Unit::Count),
-        Some(MetricDescription::new("Total number of errors processing UDP requests")),
+        Some(&MetricDescription::new("Total number of errors processing UDP requests")),
     );
 
     metrics.metric_collection.describe_gauge(
         &metric_name!(UDP_TRACKER_SERVER_PERFORMANCE_AVG_PROCESSING_TIME_NS),
         Some(Unit::Nanoseconds),
-        Some(MetricDescription::new(
+        Some(&MetricDescription::new(
             "Average time to process a UDP connect request in nanoseconds",
         )),
     );