Fix bug that does not save Tiny metadata when metadata is not an array

Author: Jacob Middag

src/class-tiny-plugin.php

@@ -89,7 +89,8 @@ public function compress_attachment($metadata, $attachment_id) {
             }
         }
 
-        if (!is_array($metadata['sizes'])) {
+        if (!isset($metadata['sizes']) || !is_array($metadata['sizes'])) {
+            $tiny_metadata->update();
             return $metadata;
         }
 
@@ -103,8 +104,8 @@ public function compress_attachment($metadata, $attachment_id) {
                 }
             }
         }
-        $tiny_metadata->update();
 
+        $tiny_metadata->update();
         return $metadata;
     }
 

test/unit/TinyPluginTest.php

@@ -119,4 +119,17 @@ public function testWrongMetadataShouldNotShowWarnings() {
 
         $this->subject->compress_attachment($testmeta, 1);
     }
+
+    public function testWrongMetadataShouldSaveTinyMetadata() {
+        $this->wp->stub('get_post_mime_type', create_function('$i', 'return "image/png";'));
+        $this->compressor->expects($this->exactly(1))->method('compress_file')->will(
+            $this->returnCallback('compressTestFile')
+        );
+
+        $testmeta = getTestMetadata();
+        $testmeta['sizes'] = 0;
+
+        $this->subject->compress_attachment($testmeta, 1);
+        $this->assertEquals(1, count($this->wp->getCalls('update_post_meta')));
+    }
 }