Remove $settings

Author: tijmenbruggeman

src/class-tiny-cli.php

@@ -20,16 +20,9 @@
 
 class Tiny_Cli
 {
-	/**
-	 * Tiny_Plugin $settings
-	 *
-	 * @var Tiny_Settings
-	 */
-	private $tiny_settings;
 
-	public function __construct($settings)
+	public function __construct()
 	{
-		$this->tiny_settings = $settings;
 
 		// Only add CLI hooks when WP-CLI is available
 		if (defined('WP_CLI') && WP_CLI) {
@@ -38,23 +31,13 @@ public function __construct($settings)
 	}
 
 	public function register_command() {
-		$command_instance = new Tiny_Command( $this->tiny_settings );
+		$command_instance = new Tiny_Command();
 		WP_CLI::add_command('tiny', $command_instance);
 	}
 }
 
 class Tiny_Command
 {
-	/**
-	 * Tiny_Plugin $settings
-	 *
-	 * @var Tiny_Settings
-	 */
-	private $tiny_settings;
-
-	public function __construct( $settings ) {
-		$tiny_settings = $settings;
-	}
 
 	/**
 	 * Optimize will process images
@@ -79,11 +62,6 @@ public function __construct( $settings ) {
 	 */
 	public function optimize($args, $assoc_args)
 	{
-		if (! $this->tiny_settings) {
-			WP_CLI::error('TinyPNG settings not available.');
-			return;
-		}
-
 		$attachments = isset($assoc_args['attachments']) ? array_map('trim', explode(',', $assoc_args['attachments'])) : array();
 
 		if (empty($attachments)) {

test/unit/TinyCliTest.php

@@ -46,4 +46,13 @@ public function test_will_not_hook_if_cli_is_unavailable() {
 
 		$this->assertFalse($cli_init_found, 'No cli_init hooks should be registered when WP_CLI is not available');
 	}
+
+	public function test_will_compress_attachments_given_in_params() {
+		$command = new Tiny_Command();
+		$command->optimize(array(), array(
+			"attachments" => array(4030),
+		));
+
+		
+	}
 }