Merge pull request #127 from thinreports/fix-unknown-keyword-argument-error

allow title argument to be specified in Report.generate method

Author: hidakatsuya

lib/thinreports/basic_report/report/base.rb

@@ -26,12 +26,13 @@ def create(options = {}, &block)
           # @param layout (see #initialize)
           # @param filename (see #generate)
           # @param security (see #generate)
+          # @param title (see #generate)
           # @param [Hash] report ({}) DEPRECATED. Options for Report.
           # @param [Hash] generator ({}) DEPRECATED. Options for Generator.
           # @yield (see .create)
           # @yieldparam (see .create)
           # @return [String]
-          def generate(layout: nil, filename: nil, security: nil, report: {}, generator: {}, &block)
+          def generate(layout: nil, filename: nil, security: nil, title: nil, report: {}, generator: {}, &block)
             raise ArgumentError, '#generate requires a block' unless block_given?
 
             if report.any? || generator.any?
@@ -44,7 +45,7 @@ def generate(layout: nil, filename: nil, security: nil, report: {}, generator: {
             security ||= generator[:security]
 
             report = create(layout: layout, &block)
-            report.generate(filename: filename, security: security)
+            report.generate(filename: filename, security: security, title: title)
           end
         end
 

test/basic_report/units/report/test_base.rb

@@ -222,7 +222,8 @@ def test_Base_generate_with_deprecated_arguments
     Report::Base.expects(:create).with(layout: '/path/to/layout.tlf').returns(@report)
     @report.expects(:generate).with(
       filename: 'result.pdf',
-      security: { owner_password: 'pass' }
+      security: { owner_password: 'pass' },
+      title: nil
     )
 
     Report::Base.generate(
@@ -238,7 +239,8 @@ def test_Base_generate_argument_priority
     Report::Base.expects(:create).with(layout: '/path/to/layout.tlf').returns(@report)
     @report.expects(:generate).with(
       filename: 'result.pdf',
-      security: { owner_password: 'pass' }
+      security: { owner_password: 'pass' },
+      title: nil
     )
 
     Report::Base.generate(
@@ -252,4 +254,10 @@ def test_Base_generate_argument_priority
       }
     ) { |_| }
   end
+
+  def test_Base_generate_when_title_argument_is_specified
+    pdf = Report::Base.generate(layout: @layout_file.path, title: 'Custom title') { start_new_page }
+
+    assert_equal 'Custom title', PDF::Reader.new(StringIO.new(pdf)).info[:Title]
+  end
 end