Skip to content

Commit 6632474

Browse files
committed
Fix tests
1 parent edcdc05 commit 6632474

4 files changed

Lines changed: 25 additions & 13 deletions

File tree

libexec/tfenv-resolve-version

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ log 'debug' "Version Requested: ${version_requested}";
101101

102102
# Accept a v-prefixed version, but strip the v.
103103
if [[ "${version_requested}" =~ ^v.*$ ]]; then
104+
log 'debug' "Version Requested is prefixed with a v. Stripping the v."
104105
version_requested="${version_requested#v*}";
105106
fi;
106107

libexec/tfenv-use

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ fi
7777

7878
log debug "Resolving version with: tfenv-resolve-version ${requested_arg}";
7979
declare resolved="$(tfenv-resolve-version ${requested_arg})";
80+
log debug "Resolved to: ${resolved}";
8081

8182
declare version="${resolved%%\:*}";
8283
declare regex="${resolved##*\:}";

libexec/tfenv-version-name

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,12 @@ if [[ "${TFENV_VERSION}" =~ ^latest.*$ ]]; then
105105

106106
else
107107
log 'debug' 'TFENV_VERSION does not use "latest" keyword';
108+
109+
# Accept a v-prefixed version, but strip the v.
110+
if [[ "${TFENV_VERSION}" =~ ^v.*$ ]]; then
111+
log 'debug' "Version Requested is prefixed with a v. Stripping the v."
112+
TFENV_VERSION="${TFENV_VERSION#v*}";
113+
fi;
108114
fi;
109115

110116
[ -z "${TFENV_VERSION}" ] \

test/test_install_and_use.sh

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -112,12 +112,13 @@ tests__kv=(
112112

113113
tests_count=${#tests__desc[@]};
114114

115-
declare desc kv k v;
115+
declare desc kv k v test_num;
116116

117-
for ((test_num=0; test_num<${tests_count}; ++test_num )) ; do
117+
for ((test_iter=0; test_iter<${tests_count}; ++test_iter )) ; do
118118
cleanup || log 'error' 'Cleanup failed?!';
119-
desc=${tests__desc[${test_num}]};
120-
kv="${tests__kv[${test_num}]}";
119+
test_num=$((test_iter + 1));
120+
desc=${tests__desc[${test_iter}]};
121+
kv="${tests__kv[${test_iter}]}";
121122
v="${kv%,*}";
122123
k="${kv##*,}";
123124
log 'info' "## Param Test ${test_num}/${tests_count}: ${desc} ( ${k} / ${v} )";
@@ -126,10 +127,11 @@ for ((test_num=0; test_num<${tests_count}; ++test_num )) ; do
126127
|| error_and_proceed "## Param Test ${test_num}/${tests_count}: ${desc} ( ${k} / ${v} ) failed";
127128
done;
128129

129-
for ((test_num=0; test_num<${tests_count}; ++test_num )) ; do
130+
for ((test_iter=0; test_iter<${tests_count}; ++test_iter )) ; do
130131
cleanup || log 'error' 'Cleanup failed?!';
131-
desc=${tests__desc[${test_num}]};
132-
kv="${tests__kv[${test_num}]}";
132+
test_num=$((test_iter + 1));
133+
desc=${tests__desc[${test_iter}]};
134+
kv="${tests__kv[${test_iter}]}";
133135
v="${kv%,*}";
134136
k="${kv##*,}";
135137
log 'info' "## ./.terraform-version Test ${test_num}/${tests_count}: ${desc} ( ${k} / ${v} )";
@@ -140,10 +142,11 @@ for ((test_num=0; test_num<${tests_count}; ++test_num )) ; do
140142
|| error_and_proceed "## ./.terraform-version Test ${test_num}/${tests_count}: ${desc} ( ${k} / ${v} ) failed";
141143
done;
142144

143-
for ((test_num=0; test_num<${tests_count}; ++test_num )) ; do
145+
for ((test_iter=0; test_iter<${tests_count}; ++test_iter )) ; do
144146
cleanup || log 'error' 'Cleanup failed?!';
145-
desc=${tests__desc[${test_num}]};
146-
kv="${tests__kv[${test_num}]}";
147+
test_num=$((test_iter + 1));
148+
desc=${tests__desc[${test_iter}]};
149+
kv="${tests__kv[${test_iter}]}";
147150
v="${kv%,*}";
148151
k="${kv##*,}";
149152
log 'info' "## TFENV_TERRAFORM_VERSION Test ${test_num}/${tests_count}: ${desc} ( ${k} / ${v} )";
@@ -208,10 +211,11 @@ neg_tests__kv=(
208211

209212
neg_tests_count=${#neg_tests__desc[@]};
210213

211-
for ((test_num=0; test_num<${neg_tests_count}; ++test_num )) ; do
214+
for ((test_iter=0; test_iter<${neg_tests_count}; ++test_iter )) ; do
212215
cleanup || log 'error' 'Cleanup failed?!';
213-
desc=${neg_tests__desc[${test_num}]}
214-
k="${neg_tests__kv[${test_num}]}";
216+
test_num=$((test_iter + 1));
217+
desc=${neg_tests__desc[${test_iter}]}
218+
k="${neg_tests__kv[${test_iter}]}";
215219
expected_error_message="No versions matching '${k}' found in remote";
216220
log 'info' "## Invalid Version Test ${test_num}/${neg_tests_count}: ${desc} ( ${k} )";
217221
[ -z "$(tfenv install "${k}" 2>&1 | grep "${expected_error_message}")" ] \

0 commit comments

Comments
 (0)