Skip to content

Commit 6d45f5d

Browse files
committed
Fix bug in KafkaUpdater
1 parent 58bbef5 commit 6d45f5d

1 file changed

Lines changed: 9 additions & 7 deletions

File tree

lib/kafka_updater.rb

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ def initialize(kafka_bridge_url, kafka_bridge_secret, service_id)
99
@service_id = service_id
1010
end
1111

12+
def task_type(task)
13+
return task.task_type if task.task_type.present?
14+
'unknown'
15+
end
16+
1217
private
1318
def make_kafka_request(topic, payload)
1419
return if @kafka_bridge_url == 'test'
@@ -25,8 +30,10 @@ def make_kafka_request(topic, payload)
2530
Rails.logger.debug("Kafka request successful for topic #{topic}")
2631
response
2732
rescue RestClient::ExceptionWithResponse => e
28-
Rails.logger.error("Kafka bridge API error for topic #{topic}: #{e.response.code} - #{e.response.body}")
29-
raise "Kafka bridge API error: #{e.response.code} - #{e.response.body}"
33+
response_body = e.response && e.response.body
34+
response_body = response_body && response_body.length > 1000 ? "#{response_body[0..1000]}..." : response_body
35+
Rails.logger.error("Kafka bridge API error for topic #{topic}: #{e.response.code} - #{response_body}")
36+
raise "Kafka bridge API error: #{e.response.code} - #{response_body}"
3037
rescue RestClient::Exception => e
3138
Rails.logger.error("Kafka bridge connection error for topic #{topic}: #{e.message}")
3239
raise "Kafka bridge connection error: #{e.message}"
@@ -36,11 +43,6 @@ def make_kafka_request(topic, payload)
3643
end
3744
end
3845

39-
def task_type(task)
40-
return task.task_type if task.task_type.present?
41-
'unknown'
42-
end
43-
4446
def update_user_progress(task)
4547
finished_successfully = false
4648
user = User.find(task.user_id)

0 commit comments

Comments
 (0)