Code style for the rest of app

Author: nygrenh

app/background_tasks/background_course_refresher_task.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'background_course_refresher'
 
 class BackgroundCourseRefresherTask

app/background_tasks/submission_reprocessor_task.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'submission_processor'
 
 class SubmissionReprocessorTask

app/helpers/application_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'tailoring'
 
 module ApplicationHelper
@@ -18,7 +20,7 @@ def active_on_current_path_link_to(name, path, options = {})
       classes += ' active'
       options[:class] = classes
     end
-    return link_to(name, path, options)
+    link_to(name, path, options)
   end
 
   def labeled(label, tags = nil, options = {}, &block)
@@ -36,9 +38,9 @@ def labeled(label, tags = nil, options = {}, &block)
     tags = tags.html_safe
 
     if tags =~ /id\s*=\s*"([^"]+)"/
-      target = ' for="' + $1 + '"'
+      target = ' for="' + Regexp.last_match(1) + '"'
     else
-      fail 'Cannot label a tag without an id'
+      raise 'Cannot label a tag without an id'
     end
 
     cls = []
@@ -56,7 +58,7 @@ def labeled(label, tags = nil, options = {}, &block)
     when :label_last
       label_start + tags + label_text + label_end
     else
-      fail 'invalid :order option for labeled()'
+      raise 'invalid :order option for labeled()'
     end
   end
 
@@ -79,7 +81,7 @@ def bs_labeled_field(label, field, options = {})
       str << '</label>'
     else
       label = label_tag label, nil, class: 'control-label'
-      str += raw("<div class=\"form-group\">" + raw(label) + raw(field) + '</div>')
+      str += raw('<div class="form-group">' + raw(label) + raw(field) + '</div>')
     end
     raw(str)
   end
@@ -89,14 +91,14 @@ def use_datatables(table_selector, options = {})
       bJQueryUI: true,
       bSort: false
     }.merge options
-    script = <<EOS
-<script type="text/javascript">
-<!--
-$(document).ready(function() {
-  $('#{escape_javascript table_selector}').dataTable(#{options.to_json});
-});
-//-->
-</script>
+    script = <<~EOS
+      <script type="text/javascript">
+      <!--
+      $(document).ready(function() {
+        $('#{escape_javascript table_selector}').dataTable(#{options.to_json});
+      });
+      //-->
+      </script>
 EOS
     raw(script)
   end

app/helpers/authorize_collection_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AuthorizeCollectionHelper
   # This method allows to authorize collections of items
   # TODO: Has to be tested with empty collections and other edge cases

app/helpers/bad_utf8_helper.rb

@@ -1,4 +1,6 @@
 
+# frozen_string_literal: true
+
 module BadUtf8Helper
   def force_utf8_violently(str)
     if str.encoding == Encoding.find('UTF-8') && str.valid_encoding?

app/helpers/bootstrap_flash_helper.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module BootstrapFlashHelper
-  ALERT_TYPES = [:error, :info, :success, :danger]
+  ALERT_TYPES = %i[error info success danger].freeze
 
   def bootstrap_flash
     flash_messages = []
@@ -8,7 +10,7 @@ def bootstrap_flash
       next if message.blank?
 
       type = :success if type.to_sym == :notice
-      type = :danger   if type.to_sym == :alert
+      type = :danger if type.to_sym == :alert
 
       next unless ALERT_TYPES.include?(type.to_sym)
 

app/helpers/comet_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'site_setting'
 
 module CometHelper

app/helpers/course_timings_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module CourseTimingsHelper
   def parse_percentage_from_unlock_condition(condition)
     if condition =~ /^(\d+)[%]\s+(?:in|of|from)\s+(\S+)$/

app/helpers/courses_helper.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 module CoursesHelper
   def response_body_for(body)
     return "You wrote:\n\n#{body}\n\n---\n\n"
-    "#{body}"
+    body.to_s
   end
 end

app/helpers/embeddable_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module EmbeddableHelper
   def remove_x_frame_options_header_when_bare_layout
     response.headers.except! 'X-Frame-Options' if @bare_layout