Handle exceptions in SettingsIo.

Author: Aleksi Salmela

src/main/java/fi/helsinki/cs/tmc/cli/backend/SettingsIo.java

@@ -117,32 +117,37 @@ protected static Path getConfigDirectory() {
         return configPath.resolve(CONFIG_DIR);
     }
 
-    //TODO handle exceptions
     private static Path getAccountsFile(Path configRoot) {
         Path file = configRoot.resolve(ACCOUNTS_CONFIG);
-        if (!Files.exists(configRoot)) {
-            try {
-                Files.createDirectories(configRoot).getParent();
-            } catch (Exception e) { }
-            try {
-                Files.createFile(configRoot);
-            } catch (Exception e) { }
+        if (!requireConfigDirectory(configRoot)) {
+            return null;
         }
         return file;
     }
 
-    //TODO handle exceptions
     private static Path getPropertiesFile(Path configRoot) {
         Path file = configRoot.resolve(PROPERTIES_CONFIG);
+        if (!requireConfigDirectory(configRoot)) {
+            return null;
+        }
+        return file;
+    }
+
+    /**
+     * Create the config directory if it doesn't already exist.
+     * @param configRoot config directory
+     * @return false if directory can't be created.
+     */
+    private static boolean requireConfigDirectory(Path configRoot) {
         if (!Files.exists(configRoot)) {
             try {
-                Files.createDirectories(configRoot).getParent();
-            } catch (Exception e) { }
-            try {
-                Files.createFile(configRoot);
-            } catch (Exception e) { }
+                Files.createDirectories(configRoot);
+            } catch (Exception e) {
+                logger.error("Could not create config directory", e);
+                return false;
+            }
         }
-        return file;
+        return true;
     }
 
     private static AccountList getHolderFromJson(Path file) {