Skip to content

Commit f1cffa2

Browse files
committed
Document code to clean up
1 parent ce8ecfa commit f1cffa2

1 file changed

Lines changed: 18 additions & 5 deletions

File tree

terminusdb_client/tests/test_woql_query_builder.py

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -192,14 +192,27 @@ def test_vlist_with_mixed_items(self):
192192
for item in result:
193193
assert isinstance(item, dict)
194194

195+
@pytest.mark.skip(reason="This method is deprecated and dead code - it is never called anywhere in the codebase.")
195196
def test_data_value_list_with_mixed_items(self):
196-
"""Test _data_value_list with mixed item types."""
197+
"""Test _data_value_list with mixed item types.
198+
199+
DEPRECATED: This method is dead code - it is never called anywhere in the
200+
codebase. The similar method _value_list() is used instead throughout the
201+
client. This test and the method will be removed in a future release.
202+
203+
There was an issue that is now fixed; however, test is disabled due to
204+
deprecation. To be cleaned up once confirmed.
205+
"""
197206
query = WOQLQuery()
198207
items = ["string", "42", True, None]
199-
# BLOCKED: Bug in line 355 of woql_query.py - it calls clean_data_value instead of _clean_data_value
200-
# This test will fail until the bug is fixed in the main codebase
201-
with pytest.raises(AttributeError):
202-
query._data_value_list(items)
208+
209+
result = query._data_value_list(items)
210+
211+
assert isinstance(result, list)
212+
assert len(result) == 4
213+
for item in result:
214+
assert isinstance(item, dict)
215+
assert "@type" in item
203216

204217
def test_clean_subject_with_dict(self):
205218
"""Test _clean_subject with dictionary input."""

0 commit comments

Comments
 (0)