Make the server check work correctly

Author: hoijnet

terminusdb_client/tests/integration_tests/conftest.py

@@ -12,30 +12,29 @@
 def is_local_server_running():
     """Check if local TerminusDB server is running at http://127.0.0.1:6363"""
     try:
-        response = requests.get("http://127.0.0.1:6363", timeout=2)
-        # Server responds with 200 (success) or 404 (not found but server is up)
-        # 401 (unauthorized) also indicates server is running but needs auth
-        return response.status_code in [200, 404]
+        requests.get("http://127.0.0.1:6363", timeout=2)
+        # Any HTTP response means the server is running
+        return True
     except (requests.exceptions.ConnectionError, requests.exceptions.Timeout):
         return False
 
 
 def is_docker_server_running():
     """Check if Docker TerminusDB server is already running at http://127.0.0.1:6366"""
     try:
-        response = requests.get("http://127.0.0.1:6366", timeout=2)
-        # Server responds with 404 for root path, which means it's running
-        return response.status_code in [200, 404]
+        requests.get("http://127.0.0.1:6366", timeout=2)
+        # Any HTTP response means the server is running
+        return True
     except (requests.exceptions.ConnectionError, requests.exceptions.Timeout):
         return False
 
 
 def is_jwt_server_running():
     """Check if JWT Docker TerminusDB server is already running at http://127.0.0.1:6367"""
     try:
-        response = requests.get("http://127.0.0.1:6367", timeout=2)
-        # Server responds with 404 for root path, which means it's running
-        return response.status_code in [200, 404]
+        requests.get("http://127.0.0.1:6367", timeout=2)
+        # Any HTTP response means the server is running
+        return True
     except (requests.exceptions.ConnectionError, requests.exceptions.Timeout):
         return False
 

terminusdb_client/tests/integration_tests/test_conftest.py

@@ -14,20 +14,18 @@ class TestServerDetection:
     """Test server detection helper functions"""
 
     @patch("terminusdb_client.tests.integration_tests.conftest.requests.get")
-    def test_local_server_running_200(self, mock_get):
-        """Test local server detection returns True for HTTP 200"""
-        mock_response = Mock()
-        mock_response.status_code = 200
-        mock_get.return_value = mock_response
+    def test_local_server_running_any_response(self, mock_get):
+        """Test local server detection returns True for any HTTP response"""
+        mock_get.return_value = Mock()
 
         assert is_local_server_running() is True
         mock_get.assert_called_once_with("http://127.0.0.1:6363", timeout=2)
 
     @patch("terminusdb_client.tests.integration_tests.conftest.requests.get")
-    def test_local_server_running_404(self, mock_get):
-        """Test local server detection returns True for HTTP 404"""
+    def test_local_server_running_401(self, mock_get):
+        """Test local server detection returns True for HTTP 401 (unauthorized)"""
         mock_response = Mock()
-        mock_response.status_code = 404
+        mock_response.status_code = 401
         mock_get.return_value = mock_response
 
         assert is_local_server_running() is True
@@ -47,20 +45,18 @@ def test_local_server_not_running_timeout(self, mock_get):
         assert is_local_server_running() is False
 
     @patch("terminusdb_client.tests.integration_tests.conftest.requests.get")
-    def test_docker_server_running_200(self, mock_get):
-        """Test Docker server detection returns True for HTTP 200"""
-        mock_response = Mock()
-        mock_response.status_code = 200
-        mock_get.return_value = mock_response
+    def test_docker_server_running_any_response(self, mock_get):
+        """Test Docker server detection returns True for any HTTP response"""
+        mock_get.return_value = Mock()
 
         assert is_docker_server_running() is True
         mock_get.assert_called_once_with("http://127.0.0.1:6366", timeout=2)
 
     @patch("terminusdb_client.tests.integration_tests.conftest.requests.get")
-    def test_docker_server_running_404(self, mock_get):
-        """Test Docker server detection returns True for HTTP 404"""
+    def test_docker_server_running_401(self, mock_get):
+        """Test Docker server detection returns True for HTTP 401 (unauthorized)"""
         mock_response = Mock()
-        mock_response.status_code = 404
+        mock_response.status_code = 401
         mock_get.return_value = mock_response
 
         assert is_docker_server_running() is True
@@ -73,20 +69,18 @@ def test_docker_server_not_running(self, mock_get):
         assert is_docker_server_running() is False
 
     @patch("terminusdb_client.tests.integration_tests.conftest.requests.get")
-    def test_jwt_server_running_200(self, mock_get):
-        """Test JWT server detection returns True for HTTP 200"""
-        mock_response = Mock()
-        mock_response.status_code = 200
-        mock_get.return_value = mock_response
+    def test_jwt_server_running_any_response(self, mock_get):
+        """Test JWT server detection returns True for any HTTP response"""
+        mock_get.return_value = Mock()
 
         assert is_jwt_server_running() is True
         mock_get.assert_called_once_with("http://127.0.0.1:6367", timeout=2)
 
     @patch("terminusdb_client.tests.integration_tests.conftest.requests.get")
-    def test_jwt_server_running_404(self, mock_get):
-        """Test JWT server detection returns True for HTTP 404"""
+    def test_jwt_server_running_401(self, mock_get):
+        """Test JWT server detection returns True for HTTP 401 (unauthorized)"""
         mock_response = Mock()
-        mock_response.status_code = 404
+        mock_response.status_code = 401
         mock_get.return_value = mock_response
 
         assert is_jwt_server_running() is True