Document the defensive code and deprecation

Author: hoijnet

terminusdb_client/tests/test_woql_subquery_aggregation.py

@@ -317,36 +317,12 @@ def test_aggregation_with_distinct(self):
         assert result is query
         assert query._query.get("@type") == "Count"
 
-    # @pytest.mark.skip(reason="""BLOCKED: Lines 852-853 in woql_query.py - edge case not covered
-        
-    #     PROBLEM: Lines 852-853 handle initialization of the "and" array when woql_and()
-    #     is called on a query that already has @type="And" but no "and" key yet.
-        
-    #     This is an edge case that occurs when:
-    #     1. A query's cursor is manually set to {"@type": "And"} without an "and" array
-    #     2. Then woql_and() is called to add queries
-        
-    #     The code checks: if "and" not in self._cursor:
-    #     Then initializes: self._cursor["and"] = []
-        
-    #     This edge case is difficult to trigger through normal API usage because:
-    #     - woql_and() always sets both @type and initializes the "and" array
-    #     - The only way to get @type="And" without "and" is through manual manipulation
-        
-    #     RECOMMENDATION: This is defensive programming for an edge case that shouldn't
-    #     occur in normal usage. Consider either:
-    #     1. Remove this check if it's truly unreachable through the public API
-    #     2. Add internal validation to prevent this state
-    #     3. Document this as defensive code and accept the uncovered lines
-    #     """)
     def test_woql_and_with_uninitialized_and_array(self):
-        """Test woql_and() when cursor has @type='And' but no 'and' array.
-        
-        This tests lines 852-853 which defensively initialize the "and" array
-        if it doesn't exist. This edge case occurs when the cursor is manually
-        manipulated to have @type="And" without the corresponding "and" array.
+        """Test woql_and() defensive programming for uninitialized 'and' array.
         
-        This is a TDD test showing the CORRECT expected behavior for this edge case.
+        Tests that woql_and() properly handles the edge case where cursor has
+        @type='And' but no 'and' array (e.g., from manual cursor manipulation).
+        The defensive code should initialize the missing array.
         """
         query = WOQLQuery()
 

terminusdb_client/woqlquery/woql_query.py

@@ -350,6 +350,10 @@ def _vlist(self, target_list):
         return vl
 
     def _data_value_list(self, target_list):
+        """DEPRECATED: Dead code - never called anywhere in the codebase.
+        
+        Use _value_list() instead. This method will be removed in a future release.
+        """
         dvl = []
         for item in target_list:
             o = self._clean_data_value(item)