fix tests

Author: Veeral Patel

tools/tdbg/task_queue_commands.go

@@ -218,11 +218,11 @@ func AdminGetTaskQueueUserData(c *cli.Context, clientFactory ClientFactory) erro
 
 	ctx, cancel := newContext(c)
 	defer cancel()
-	if response, e := client.GetTaskQueueUserData(ctx, req); e != nil {
+	response, e := client.GetTaskQueueUserData(ctx, req)
+	if e != nil {
 		return fmt.Errorf("unable to get Task Queue User Data: %w", e)
-	} else {
-		prettyPrintJSONObject(c, response)
 	}
+	prettyPrintJSONObject(c, response)
 	return nil
 }
 

tools/tdbg/task_queue_commands_test.go

@@ -175,7 +175,7 @@ func (s *taskQueueCommandTestSuite) TestForceUnloadTaskQueuePartition() {
 // TestGetTaskQueueUserData tests that the cli accepts the various arguments for get-user-data.
 func (s *taskQueueCommandTestSuite) TestGetTaskQueueUserData() {
 	baseCommand := []string{"tdbg", "taskqueue", "get-user-data",
-		"--task-queue", "test"}
+		"--namespace", "default", "--task-queue", "test"}
 
 	// Run shared test cases, skipping sticky-name (not a registered flag on this command).
 	for _, test := range testCases {
@@ -184,17 +184,22 @@ func (s *taskQueueCommandTestSuite) TestGetTaskQueueUserData() {
 		}
 		cliCommand := append(baseCommand, test.inputFlags...)
 		resp := s.app.Run(cliCommand)
-		if resp != nil {
+		if test.err != nil {
 			s.ErrorContainsf(resp, test.err.Error(), "error present")
+		} else {
+			s.NoError(resp)
 		}
 	}
 
 	// Missing --task-queue is enforced by cli/v2 (Required: true) before the action runs.
-	s.Error(s.app.Run([]string{"tdbg", "taskqueue", "get-user-data"}))
+	s.Error(s.app.Run([]string{"tdbg", "taskqueue", "get-user-data", "--namespace", "default"}))
+
+	// Missing --namespace is enforced by cli/v2 (Required: true) before the action runs.
+	s.Error(s.app.Run([]string{"tdbg", "taskqueue", "get-user-data", "--task-queue", "test"}))
 
 	// No --task-queue-type or --partition-id: both use their defaults and succeed.
 	s.NoError(s.app.Run([]string{"tdbg", "taskqueue", "get-user-data",
-		"--task-queue", "test"}))
+		"--namespace", "default", "--task-queue", "test"}))
 
 	// Matching client returns an error: CLI wraps and returns it.
 	errorClient := &testClient{
@@ -205,6 +210,6 @@ func (s *taskQueueCommandTestSuite) TestGetTaskQueueUserData() {
 	errorApp := NewCliApp(func(params *Params) { params.ClientFactory = errorClient })
 	errorApp.ExitErrHandler = func(context *cli.Context, err error) {}
 	resp := errorApp.Run([]string{"tdbg", "taskqueue", "get-user-data",
-		"--task-queue", "test"})
+		"--namespace", "default", "--task-queue", "test"})
 	s.ErrorContains(resp, "unable to get Task Queue User Data")
 }