Skip to content

Commit 5e86fa0

Browse files
rkannan82claude
andcommitted
Fix stale test comments
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent da1cc6b commit 5e86fa0

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

service/matching/matching_engine_test.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5233,9 +5233,8 @@ func (*testTaskManager) CountTaskQueuesByBuildId(context.Context, *persistence.C
52335233
}
52345234

52355235
// TestLoggerAndMetricsForPartition_BreakdownEnabled verifies partition and taskqueue tag values
5236-
// with the default BreakdownMetricsByTaskQueue=true: normal queues show their name, sticky queues
5237-
// show the base name, and worker-commands queues get partition=__worker_commands__ with
5238-
// taskqueue=__omitted__.
5236+
// with the default BreakdownMetricsByTaskQueue=true: normal and worker-commands queues show their
5237+
// name, sticky queues show the base name, and each partition type gets its own partition tag.
52395238
func TestLoggerAndMetricsForPartition_BreakdownEnabled(t *testing.T) {
52405239
t.Parallel()
52415240

@@ -5294,8 +5293,7 @@ func TestLoggerAndMetricsForPartition_BreakdownEnabled(t *testing.T) {
52945293
}
52955294

52965295
// TestLoggerAndMetricsForPartition_BreakdownDisabled verifies behavior with BreakdownMetricsByTaskQueue=false:
5297-
// normal and sticky queues get taskqueue=__omitted__, and worker-commands queues also get __omitted__
5298-
// with partition=__worker_commands__.
5296+
// all partition types get taskqueue=__omitted__, but each still gets its own partition tag.
52995297
func TestLoggerAndMetricsForPartition_BreakdownDisabled(t *testing.T) {
53005298
t.Parallel()
53015299

0 commit comments

Comments
 (0)