Skip to content

Commit 438a038

Browse files
authored
Add resource id annotation for SAA (#747)
<!-- Describe what has changed in this PR --> **What changed?** - Add resource id annotation for SAA <!-- Tell your future self why have you made these changes --> **Why?** - With request header annotation, activityID will be automatically available in the request header <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** - N/A <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** - N/A
1 parent 6895f0b commit 438a038

1 file changed

Lines changed: 20 additions & 0 deletions

File tree

temporal/api/workflowservice/v1/service.proto

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1653,6 +1653,10 @@ service WorkflowService {
16531653
body: "*"
16541654
}
16551655
};
1656+
option (temporal.api.protometa.v1.request_header) = {
1657+
header: "temporal-resource-id"
1658+
value: "activity:{activity_id}"
1659+
};
16561660
}
16571661

16581662
// DescribeActivityExecution returns information about an activity execution.
@@ -1667,6 +1671,10 @@ service WorkflowService {
16671671
get: "/api/v1/namespaces/{namespace}/activities/{activity_id}"
16681672
}
16691673
};
1674+
option (temporal.api.protometa.v1.request_header) = {
1675+
header: "temporal-resource-id"
1676+
value: "activity:{activity_id}"
1677+
};
16701678
}
16711679

16721680
// PollActivityExecution long-polls for an activity execution to complete and returns the
@@ -1678,6 +1686,10 @@ service WorkflowService {
16781686
get: "/api/v1/namespaces/{namespace}/activities/{activity_id}/outcome"
16791687
}
16801688
};
1689+
option (temporal.api.protometa.v1.request_header) = {
1690+
header: "temporal-resource-id"
1691+
value: "activity:{activity_id}"
1692+
};
16811693
}
16821694

16831695
// ListActivityExecutions is a visibility API to list activity executions in a specific namespace.
@@ -1715,6 +1727,10 @@ service WorkflowService {
17151727
body: "*"
17161728
}
17171729
};
1730+
option (temporal.api.protometa.v1.request_header) = {
1731+
header: "temporal-resource-id"
1732+
value: "activity:{activity_id}"
1733+
};
17181734
}
17191735

17201736
// TerminateActivityExecution terminates an existing activity execution immediately.
@@ -1730,6 +1746,10 @@ service WorkflowService {
17301746
body: "*"
17311747
}
17321748
};
1749+
option (temporal.api.protometa.v1.request_header) = {
1750+
header: "temporal-resource-id"
1751+
value: "activity:{activity_id}"
1752+
};
17331753
}
17341754

17351755
// DeleteActivityExecution asynchronously deletes a specific activity execution (when

0 commit comments

Comments
 (0)