Skip to content

Commit e314f09

Browse files
rkannan82claude
andauthored
Fix proto generation for new subdirectories (#248)
* Fix proto generation failing when new subdirectories are added The `mv -f` command cannot merge directories — it fails when the destination directory already exists. Replace with `cp -rf` so that new proto subdirectories (e.g. nexusservices) are handled correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Add comment explaining cp vs mv choice Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 3716dd6 commit e314f09

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ go-grpc: clean .go-helpers-installed $(PROTO_OUT)
6161
-p grpc-gateway_out=allow_patch_feature=false,$(PROTO_PATHS) \
6262
-p go-helpers_out=$(PROTO_PATHS)
6363

64-
mv -f $(PROTO_OUT)/temporal/api/* $(PROTO_OUT) && rm -rf $(PROTO_OUT)/temporal
64+
# cp is safer than mv because mv cannot merge into existing directories
65+
cp -rf $(PROTO_OUT)/temporal/api/* $(PROTO_OUT) && rm -rf $(PROTO_OUT)/temporal
6566

6667
http-api-docs: go-grpc
6768
go run cmd/encode-openapi-spec/main.go \

0 commit comments

Comments
 (0)