Skip to content

Commit 28451b8

Browse files
committed
Add more state to the pending activity state (#565)
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** Add PAUSED/PAUSE_REQUESTED states to the PendictActivityState enum. <!-- Tell your future self why have you made these changes --> **Why?** To easily differentiate between "activity is paused on server and still running on worker" and "activity is paused on server and not running on worker". This is the result of our discussion for activity commands. In old terms: "state == PAUSED" is "state = SCHEDULLED and paused_flag = true" "state == PAUSE_REQUESTED" is "state = STARTED and paused_flag = true"
1 parent 61a7a2c commit 28451b8

5 files changed

Lines changed: 21 additions & 5 deletions

File tree

enums/v1/workflow.go-helpers.pb.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

enums/v1/workflow.pb.go

Lines changed: 16 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

temporalproto/openapi/openapiv2.go

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

temporalproto/openapi/openapiv3.go

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)