Missing tdsVersion option on CLI

[luisvinicius09]

As title, I have the need to chose the tdsVersion when running the CLI, to connect in a SQL Server 2000.

I've took a look at the code and could confirm that is not possible to pass it as an argument
Currently this are the available options(taken from node-mssql/bin/mssql file):

  .option('--config <file>', 'Configuration file for the connection', './.mssql.json')
  .option('--user <user>', 'User for the database connection')
  .option('--password <password>', 'Password for the database connection')
  .option('--server <server>', 'Server for the database connection')
  .option('--database <database>', 'Database for the database connection')
  .option('--port <port>', 'Port for the database connection', parseInt)
  .option('--encrypt', 'Use the encrypt option for this connection', false)
  .option('--trust-server-certificate', 'Trust the server certificate for this connection', false)

My goal would be to use it as

mssql --database master --user sa --password xxxxxxxx --server 192.x.x.x --port 1433 --tdsVersion 7.1

Am I missing something, or do we need to make a change to make it work?

[dhensby]

If you want to set it as a CLI argument, then this feature needs to be added.

Otherwise you should be able to do it in a config file.

[luisvinicius09]

When doing the following on a modern SQL Server created with docker, it works fine

echo "select 1 as xxx" | bin/mssql ./test/.mssql.json

Using the following config file

{
  "user": "sa",
  "password": "***********",
  "server": "192.x.x.x",
  "port": 1433,
  "database": "master",
  "requestTimeout": 30000,
  "options": {
    "abortTransactionOnError": true,
    "encrypt": false
  }
}

But for some reason when I pass options.tdsVersion: "7_1" and try connecting into my SQL Server 2000, I get the following

Failed to connect to 192.168.3.46:1433 - Could not connect (sequence)

The connection to the 2000 is working fine because I've done it through DBeaver and even works when installing this, as dependency and using it on runtime

import sql from "mssql";

const options = {
  useUTC: false,
  enableArithAbort: true,
  encrypt: encrypt ? encrypt : false,
  tdsVersion: "7_1"
};

{...}

sql.connect({
    server: host,
    port: Number(port),
    user,
    password,
    database,
    requestTimeout: 2147483646, // why? ok
    options,
  }); // WORKS on 2000

But I have a specific need of querying stuff through the CLI

[luisvinicius09]

I'm trying to debug what is going on since yesterday

I've noticed it goes in lib/tedious/connection-pool.js and gets inside the tedious.connect without errors

try {
  tedious = new tds.Connection(this._config())
} catch (err) {
  rejectOnce(err)
  return
}
tedious.connect(err => {
  if (err) {
    err = new ConnectionError(err)
    return rejectOnce(err)
  }

  debug('connection(%d): established', IDS.get(tedious)) // <------------ gets here
  this.collation = tedious.databaseCollation
  resolveOnce(tedious)
})

And then goes directly to tedious.on('end', () => {...})

I'm mapping where it throws the error to gather more information - but apparently happens inside tedious? Any help would be great

[luisvinicius09]

Also, when I don't pipe a query in, it stays on limbo? I'm not sure if it's normal behaviour - I saw it happen on both connections, modern and 2000

[luisvinicius09]

I'm trying to debug what is going on since yesterday

I've noticed it goes in lib/tedious/connection-pool.js and gets inside the tedious.connect without errors

try {
tedious = new tds.Connection(this._config())
} catch (err) {
rejectOnce(err)
return
}
tedious.connect(err => {
if (err) {
err = new ConnectionError(err)
return rejectOnce(err)
}

debug('connection(%d): established', IDS.get(tedious)) // <------------ gets here
this.collation = tedious.databaseCollation
resolveOnce(tedious)
})
And then goes directly to tedious.on('end', () => {...})

I'm mapping where it throws the error to gather more information - but apparently happens inside tedious? Any help would be great

Realized that the problem was my server - it works fine

For contribution, I worked on adding the flag - Add --tds-version flag to CLI