Skip to content

Commit ce855c5

Browse files
MrChromeboxjackpot51
authored andcommitted
drivers/intel/gma: Drop unused MAILBOXES_DESKTOP
MAILBOXES_DESKTOP is unused, and the IGD opregion spec makes no distinction in the mailboxes supported between desktop and mobile platforms. Rename MAILBOXES_MOBILE to IGD_MAILBOXES for consistency with other mailbox variables and clean up the comment. Change-Id: Ia06fe75702887aa6953bf17bd4bc14af4038bec5 Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86279 Reviewed-by: Jérémy Compostella <jeremy.compostella@intel.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
1 parent a6e521e commit ce855c5

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

src/drivers/intel/gma/opregion.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -367,8 +367,8 @@ enum cb_err intel_gma_init_igd_opregion(void)
367367
/* 8kb */
368368
opregion->header.size = sizeof(igd_opregion_t) / 1024;
369369

370-
// FIXME We just assume we're mobile for now
371-
opregion->header.mailboxes = MAILBOXES_MOBILE;
370+
// Supported mailboxes
371+
opregion->header.mailboxes = IGD_MAILBOXES;
372372

373373
// TODO Initialize Mailbox 1
374374
opregion->mailbox1.clid = 1;

src/drivers/intel/gma/opregion.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,7 @@ typedef struct {
4141
#define IGD_MBOX4 (1 << 3)
4242
#define IGD_MBOX5 (1 << 4)
4343

44-
#define MAILBOXES_MOBILE (IGD_MBOX1 | IGD_MBOX3 | IGD_MBOX4 | IGD_MBOX5)
45-
#define MAILBOXES_DESKTOP (IGD_MBOX2 | IGD_MBOX4)
44+
#define IGD_MAILBOXES (IGD_MBOX1 | IGD_MBOX3 | IGD_MBOX4 | IGD_MBOX5)
4645

4746
#define SBIOS_VERSION_SIZE 32
4847

0 commit comments

Comments
 (0)