Skip to content

Commit 5694587

Browse files
committed
1009433: Need to ensure JavaScript(ES5) Document Coding Standards in Spreadsheet JavaScript ES5 platform
1 parent 5440e39 commit 5694587

40 files changed

Lines changed: 412 additions & 417 deletions

File tree

Document-Processing/Excel/Spreadsheet/Javascript-ES5/docker-deployment.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ Now the Spreadsheet server Docker instance runs on localhost with the provided p
103103
<div id='Spreadsheet'></div>
104104
<script>
105105
// Initialize Spreadsheet component.
106-
const spreadsheet = new ej.spreadsheet.Spreadsheet({
106+
var spreadsheet = new ej.spreadsheet.Spreadsheet({
107107
openUrl: 'http://localhost:6002/api/spreadsheet/open',
108108
saveUrl: 'http://localhost:6002/api/spreadsheet/save'
109109
});

Document-Processing/Excel/Spreadsheet/Javascript-ES5/formatting.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ Compared to Excel, the date, time, currency, and accounting formats vary across
116116
The code below illustrates how culture-based format codes are mapped to their corresponding number format ID for the `German (de)` culture.
117117

118118
```js
119-
const deLocaleFormats = [
119+
var deLocaleFormats = [
120120
{ id: 14, code: 'dd.MM.yyyy' },
121121
{ id: 15, code: 'dd. MMM yy' },
122122
{ id: 16, code: 'dd. MMM' },

Document-Processing/Excel/Spreadsheet/Javascript-ES5/open-save.md

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,8 @@ By default, the Spreadsheet control provides an option to browse files from the
130130
},
131131
body: JSON.stringify({ FileName: 'Sample' }),
132132
})
133-
.then((response) => response.json())
134-
.then((data) => {
133+
.then(function (response){ response.json()})
134+
.then(function(data) {
135135
// Load the JSON data into spreadsheet.
136136
spreadsheet.openFromJson({ file: data });
137137
})
@@ -163,14 +163,14 @@ var spreadsheet = new ej.spreadsheet.Spreadsheet({
163163
sheets: [
164164
],
165165
openUrl: 'https://xxxxxxxxxxxxxxxxxx.amazonaws.com/Prod/api/spreadsheet/open',
166-
beforeOpen: (eventArgs) => {
166+
beforeOpen: function (eventArgs) {
167167
eventArgs.cancel = true; // To prevent the default open action.
168168
if (eventArgs.file) {
169-
const reader = new FileReader();
169+
var reader = new FileReader();
170170
reader.readAsDataURL(eventArgs.file);
171-
reader.onload = () => {
171+
reader.onload = function () {
172172
// Removing the xlsx file content-type.
173-
const base64Data = reader.result.replace('data:application/vnd.openxmlformats-officedocument.spreadsheetml.sheet;base64,', '');
173+
var base64Data = reader.result.replace('data:application/vnd.openxmlformats-officedocument.spreadsheetml.sheet;base64,', '');
174174
openExcel({
175175
file: base64Data,
176176
extension: eventArgs.file.name.slice(eventArgs.file.name.lastIndexOf('.') + 1),
@@ -180,7 +180,7 @@ var spreadsheet = new ej.spreadsheet.Spreadsheet({
180180
}
181181
}
182182
});
183-
const openExcel = (requestData) => {
183+
function openExcel(requestData) {
184184
// Fetch call to AWS server for open processing.
185185
fetch('https://xxxxxxxxxxxxxxxxxx.amazonaws.com/Prod/api/spreadsheet/open', {
186186
method: 'POST',
@@ -189,16 +189,16 @@ const openExcel = (requestData) => {
189189
'Content-Type': 'application/json;charset=UTF-8'
190190
},
191191
body: JSON.stringify(requestData)
192-
}).then((response) => {
192+
}).then(function (response) {
193193
if (response.ok) {
194194
return response.json();
195195
}
196-
}).then((data) => {
196+
}).then(function (data) {
197197
// Loading the JSON data into our spreadsheet.
198198
if (data.Workbook && data.Workbook.sheets) {
199199
spreadsheet.openFromJson({ file: data });
200200
}
201-
}).catch((error) => {
201+
}).catch(function (error) {
202202
console.log(error);
203203
});
204204
};
@@ -344,7 +344,7 @@ The following code example demonstrates the client-side and server-side configur
344344
**Client Side**:
345345

346346
```javascript
347-
const spreadsheet = new ej.spreadsheet.Spreadsheet({
347+
var spreadsheet = new ej.spreadsheet.Spreadsheet({
348348
openSettings: {
349349
// Specifies the size (in bytes) of each chunk for the server response when opening a document.
350350
chunkSize: 1000000,
@@ -496,8 +496,8 @@ By default, the Spreadsheet control saves the Excel file and downloads it to the
496496
```js
497497

498498
// Convert the spreadsheet workbook to JSON data.
499-
spreadsheet.saveAsJson().then((json) => {
500-
const formData = new FormData();
499+
spreadsheet.saveAsJson().then(function (json) {
500+
var formData = new FormData();
501501
formData.append('FileName', "Sample");
502502
formData.append('saveType', 'Xlsx');
503503
// Passing the JSON data to perform the save operation.
@@ -507,7 +507,7 @@ By default, the Spreadsheet control saves the Excel file and downloads it to the
507507
fetch('https://localhost:{Your port number}/Home/Save', {
508508
method: 'POST',
509509
body: formData
510-
}).then((response) => {
510+
}).then(function (response) {
511511
console.log(response);
512512
});
513513
});
@@ -573,19 +573,19 @@ var spreadsheet = new ej.spreadsheet.Spreadsheet({
573573
sheets: [
574574
],
575575
saveUrl:'https://xxxxxxxxxxxxxxxxxxxxxxxxx.amazonaws.com/Prod/api/spreadsheet/save',
576-
beforeSave: (eventArgs) => {
576+
beforeSave: fucntion (eventArgs) {
577577
if (!saveInitiated) {
578578
eventArgs.cancel = true; // Preventing default save action.
579579
saveInitiated = true; // The "beforeSave" event will trigger for "saveAsJson" action also, so we are preventing for the "saveAsJson".
580580
saveAsExcel(eventArgs);
581581
}
582582
}
583583
});
584-
const saveAsExcel = (eventArgs) => {
584+
var saveAsExcel = function (eventArgs) {
585585
// Convert the spreadsheet workbook to JSON data.
586-
spreadsheet.saveAsJson().then(Json => {
586+
spreadsheet.saveAsJson().then(function (Json) {
587587
saveInitiated = false;
588-
const formData = new FormData();
588+
var formData = new FormData();
589589
// Passing the JSON data to server to perform save operation.
590590
formData.append('JSONData', JSON.stringify(Json.jsonObject.Workbook));
591591
formData.append('saveType', 'Xlsx');
@@ -594,28 +594,28 @@ const saveAsExcel = (eventArgs) => {
594594
// Using fetch API to invoke the server for save processing.
595595
fetch('https://xxxxxxxxxxxxxxxxxxxxxxxxx.amazonaws.com/Prod/api/spreadsheet/save', {
596596
method: 'POST', body: formData
597-
}).then(response => {
597+
}).then(function (response) {
598598
if (response.ok) {
599599
return response.blob();
600600
}
601-
}).then(data => {
602-
const reader = new FileReader();
601+
}).then(function (data) {
602+
var reader = new FileReader();
603603
reader.onload = function () {
604604
//Converts the result of the file reading operation into a base64 string.
605-
const textBase64Str = reader.result.toString();
605+
var textBase64Str = reader.result.toString();
606606
//Converts the base64 string into a Excel base64 string.
607-
const excelBase64Str = atob(textBase64Str.replace('data:text/plain;base64,', ''));
607+
var excelBase64Str = atob(textBase64Str.replace('data:text/plain;base64,', ''));
608608
//Converts the Excel base64 string into byte characters.
609-
const byteCharacters = atob(excelBase64Str.replace('data:application/vnd.openxmlformats-officedocument.spreadsheetml.sheet;base64,', ''));
610-
const byteArrays = [];
611-
for (let i = 0; i < byteCharacters.length; i++) {
609+
var byteCharacters = atob(excelBase64Str.replace('data:application/vnd.openxmlformats-officedocument.spreadsheetml.sheet;base64,', ''));
610+
var byteArrays = [];
611+
for (var i = 0; i < byteCharacters.length; i++) {
612612
byteArrays.push(byteCharacters.charCodeAt(i));
613613
}
614-
const byteArray = new Uint8Array(byteArrays);
614+
var byteArray = new Uint8Array(byteArrays);
615615
//creates a blob data from the byte array with xlsx content type.
616-
const blobData = new Blob([byteArray], { type: 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet' });
617-
const blobUrl = URL.createObjectURL(blobData);
618-
const anchor = document.createElement('a');
616+
var blobData = new Blob([byteArray], { type: 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet' });
617+
var blobUrl = URL.createObjectURL(blobData);
618+
var anchor = document.createElement('a');
619619
anchor.download = 'Sample.xlsx';
620620
anchor.href = blobUrl;
621621
document.body.appendChild(anchor);

Document-Processing/Excel/Spreadsheet/Javascript-ES5/performance-best-practices.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ The following code example shows how to set `isFullPost` to **false** in the Spr
109109

110110
```js
111111
var spreadsheet = new ej.spreadsheet.Spreadsheet({
112-
beforeSave: (args) => {
112+
beforeSave: function (args) {
113113
args.isFullPost = false;
114114
}
115115
});

Document-Processing/Excel/Spreadsheet/Javascript-ES5/sort.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ You can also enable or disable this property using `beforeSort` event arguments,
5656

5757
```ts
5858

59-
let spreadsheet: Spreadsheet = new Spreadsheet({
59+
var spreadsheet: Spreadsheet = new Spreadsheet({
6060

6161
beforeSort: function (args) {
6262
args.sortOptions.containsHeader = true;
@@ -79,7 +79,7 @@ You can also enable or disable this property using `beforeSort` event arguments,
7979

8080
```ts
8181

82-
let spreadsheet: Spreadsheet = new Spreadsheet({
82+
var spreadsheet: Spreadsheet = new Spreadsheet({
8383

8484
beforeSort: function (args) {
8585
args.sortOptions.caseSensitive = true;
Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
var base64String;
32

43
var spreadsheet = new ej.spreadsheet.Spreadsheet({
@@ -12,17 +11,17 @@ var spreadsheet = new ej.spreadsheet.Spreadsheet({
1211
]
1312
}],
1413

15-
created: () => {
16-
//Applies cell and number formatting to specified range of the active sheet
14+
created: function () {
15+
// Applies cell and number formatting to specified range of the active sheet
1716
spreadsheet.cellFormat({ fontWeight: 'bold', textAlign: 'center', verticalAlign: 'middle' }, 'A1:F1');
1817
},
1918

20-
beforeSave: (args) => {
19+
beforeSave: function (args) {
2120
args.needBlobData = true; // To trigger the saveComplete event.
2221
args.isFullPost = false; // Get the spreadsheet data as blob data in the saveComplete event.
2322
},
2423

25-
saveComplete: (args) => {
24+
saveComplete: function (args) {
2625
// Convert blob data to base64 string.
2726
var reader = new FileReader();
2827
reader.readAsDataURL(args.blobData);
@@ -36,22 +35,24 @@ var spreadsheet = new ej.spreadsheet.Spreadsheet({
3635
// Render initialized Spreadsheet.
3736
spreadsheet.appendTo('#spreadsheet');
3837

39-
document.getElementById("import").onclick = () => {
38+
document.getElementById("import").onclick = function () {
4039
// Open the file based on saved base64 string.
4140
fetch(base64String)
42-
.then((response) => response.blob())
43-
.then((fileBlob) => {
41+
.then(function (response) {
42+
return response.blob();
43+
})
44+
.then(function (fileBlob) {
4445
var file = new File([fileBlob], 'Sample.xlsx');
4546
spreadsheet.open({ file: file });
4647
});
47-
}
48+
};
4849

49-
document.getElementById("export").onclick = () => {
50+
document.getElementById("export").onclick = function () {
5051
spreadsheet.save({
5152
url: 'https://document.syncfusion.com/web-services/spreadsheet-editor/api/spreadsheet/save',
5253
fileName: 'Worksheet',
53-
saveType: 'Xlsx',
54+
saveType: 'Xlsx'
5455
}); // Specifies the save URL, file name, file type need to be saved.
5556
// Logs base64 string into the console.
5657
console.log('Base64 String - ', base64String);
57-
}
58+
};

Document-Processing/code-snippet/spreadsheet/javascript-es5/change-active-sheet-cs1/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
ej.base.enableRipple(true);
22

3-
let spreadsheet = new ej.spreadsheet.Spreadsheet({
3+
var spreadsheet = new ej.spreadsheet.Spreadsheet({
44
openUrl: 'https://document.syncfusion.com/web-services/spreadsheet-editor/api/spreadsheet/open',
55
saveUrl: 'https://document.syncfusion.com/web-services/spreadsheet-editor/api/spreadsheet/save',
66
openComplete: function() {

Document-Processing/code-snippet/spreadsheet/javascript-es5/chart-cs3/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ var spreadsheet = new ej.spreadsheet.Spreadsheet({
3131
spreadsheet.numberFormat(ej.spreadsheet.getFormatFromType('Currency'), 'B4:F8');
3232
spreadsheet.merge('A1:F1');
3333
},
34-
actionBegin: (args) => {
34+
actionBegin: function (args) {
3535
if (args.action === 'beforeInsertChart' && args.args.eventArgs.type.includes('Line')) {
3636
args.args.eventArgs.markerSettings.shape = 'Triangle';
3737
args.args.eventArgs.markerSettings.isFilled = false;

Document-Processing/code-snippet/spreadsheet/javascript-es5/clipboard-cs1/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
//Initialize action items.
2-
let items = [
2+
var items = [
33
{
44
text: "Copy"
55
},
@@ -12,10 +12,10 @@ let items = [
1212
];
1313

1414
// Initialize the DropDownButton component.
15-
let drpDownBtn = new ej.splitbuttons.DropDownButton({
15+
var drpDownBtn = new ej.splitbuttons.DropDownButton({
1616
items: items,
1717
cssClass: "e-round-corner",
18-
select: (args) => {
18+
select: function (args) {
1919
if (args.item.text === 'Copy')
2020
spreadsheet.copy();
2121
if (args.item.text === 'Cut')
Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
//Initialize action items.
2-
let items = [
2+
var items = [
33
{
44
text: "Copy"
55
},
@@ -12,10 +12,10 @@ let items = [
1212
];
1313

1414
// Initialize the DropDownButton component.
15-
let drpDownBtn = new ej.splitbuttons.DropDownButton({
15+
var drpDownBtn = new ej.splitbuttons.DropDownButton({
1616
items: items,
1717
cssClass: "e-round-corner",
18-
select: (args) => {
18+
select: function (args) {
1919
if (args.item.text === 'Copy')
2020
spreadsheet.copy();
2121
if (args.item.text === 'Cut')
@@ -32,22 +32,22 @@ drpDownBtn.appendTo("#element");
3232
// Initialize the Spreadsheet component.
3333

3434
var columns = [
35-
{
36-
width: 130
37-
},
38-
{
39-
width: 92
40-
},
41-
{
42-
width: 96
43-
}
35+
{
36+
width: 130
37+
},
38+
{
39+
width: 92
40+
},
41+
{
42+
width: 96
43+
}
4444
];
4545

4646
var spreadsheet = new ej.spreadsheet.Spreadsheet({
4747
sheets: [{ ranges: [{ dataSource: defaultData }], columns: columns }],
4848
enableClipboard: true,
4949
// Triggers before the action begins.
50-
actionBegin: (pasteArgs) => {
50+
actionBegin: function (pasteArgs) {
5151
// To cancel the paste action.
5252
if (pasteArgs.action === 'clipboard' && pasteArgs.args.eventArgs.requestType === 'paste') {
5353
pasteArgs.args.eventArgs.cancel = true;
@@ -57,7 +57,4 @@ var spreadsheet = new ej.spreadsheet.Spreadsheet({
5757

5858

5959
// Render initialized Spreadsheet.
60-
spreadsheet.appendTo('#spreadsheet');
61-
62-
63-
60+
spreadsheet.appendTo('#spreadsheet');

0 commit comments

Comments
 (0)