chores: small code changes to improve code coverage

Author: t-graf

sw360/attachments.py

@@ -55,16 +55,10 @@ def get_attachment_infos_for_resource(self, resource_type: str, resource_id: str
             + "/attachments"
         )
 
-        if not resp:
-            return []
+        if resp and "_embedded" in resp and "sw360:attachments" in resp["_embedded"]:
+            return resp["_embedded"]["sw360:attachments"]
 
-        if "_embedded" not in resp:
-            return []
-
-        if "sw360:attachments" not in resp["_embedded"]:
-            return []
-
-        return resp["_embedded"]["sw360:attachments"]
+        return []
 
     def get_attachment_infos_for_release(self, release_id: str) -> List[Dict[str, Any]]:
         """Get information about the attachments of a release

sw360/license.py

@@ -117,16 +117,10 @@ def get_all_licenses(self) -> List[Dict[str, Any]]:
         """
 
         resp = self.api_get(self.url + "resource/api/licenses")
-        if not resp:
-            return []
+        if resp and "_embedded" in resp and "sw360:licenses" in resp["_embedded"]:
+            return resp["_embedded"]["sw360:licenses"]
 
-        if "_embedded" not in resp:
-            return []
-
-        if "sw360:licenses" not in resp["_embedded"]:
-            return []
-
-        return resp["_embedded"]["sw360:licenses"]
+        return []
 
     def get_license(self, license_id: str) -> Optional[Dict[str, Any]]:
         """Get information of about a license

sw360/vendor.py

@@ -27,16 +27,10 @@ def get_all_vendors(self) -> List[Dict[str, Any]]:
         """
 
         resp = self.api_get(self.url + "resource/api/vendors")
-        if not resp:
-            return []
+        if resp and "_embedded" in resp and "sw360:vendors" in resp["_embedded"]:
+            return resp["_embedded"]["sw360:vendors"]
 
-        if "_embedded" not in resp:
-            return []
-
-        if "sw360:vendors" not in resp["_embedded"]:
-            return []
-
-        return resp["_embedded"]["sw360:vendors"]
+        return []
 
     def get_vendor(self, vendor_id: str) -> Optional[Dict[str, Any]]:
         """Returns a vendor