Skip to content

Commit 5847f49

Browse files
committed
fix little problems
1 parent 0daf392 commit 5847f49

7 files changed

Lines changed: 16 additions & 34 deletions

File tree

api_v1/__init__.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
from .routers import register_routers
2-
from exeptions import ValidationError
32

43

5-
__all__ = ('register_routers',
6-
'ValidationError',
7-
)
4+
__all__ = ('register_routers',)

api_v1/users/views.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
from fastapi import APIRouter, Depends
1+
from fastapi import APIRouter, Depends, status
22

33
from sqlalchemy.ext.asyncio import AsyncSession
44

55
from config import db_connection
6+
from api_v1.exeptions import ValidationError
67

78

89
router = APIRouter(prefix='/users',
@@ -17,4 +18,5 @@ async def get_user(
1718
session: AsyncSession = Depends(db_connection.session_geter),
1819
):
1920
session = session
20-
return {'user': 'is_work'}
21+
raise ValidationError(status_code=status.HTTP_400_BAD_REQUEST,
22+
detail=dict(some='Some is wrong'))

app_includes/logs_errors.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
import json
22
from fastapi import FastAPI, Request
3+
from fastapi.responses import JSONResponse
34
from fastapi.exceptions import HTTPException
45
from starlette.exceptions import HTTPException as StarletteHTTPException
56

67
from http import HTTPStatus
78

89
from config.setup_logs.logging import logger
9-
from api_v1 import ValidationError
10+
from api_v1.exeptions import ValidationError
1011

1112

1213
def register_errors(app: FastAPI) -> None:
@@ -24,8 +25,7 @@ async def validation_error_handler(
2425
error_code=422,
2526
message=exc.detail,
2627
)
27-
json_response = json.dumps(response).encode(encoding='utf-8')
28-
return json_response
28+
return JSONResponse(response)
2929

3030
@app.exception_handler(HTTPException)
3131
async def http_error_handler(
@@ -41,8 +41,7 @@ async def http_error_handler(
4141
error_code=exc.status_code,
4242
message=exc.detail,
4343
)
44-
json_response = json.dumps(response).encode(encoding='utf-8')
45-
return json_response
44+
return JSONResponse(response)
4645

4746
@app.exception_handler(Exception)
4847
async def error_handler(
@@ -58,8 +57,7 @@ async def error_handler(
5857
error_code=500,
5958
message=HTTPStatus(500).phrase,
6059
)
61-
json_response = json.dumps(response).encode(encoding='utf-8')
62-
return json_response
60+
return JSONResponse(response)
6361

6462
@app.exception_handler(StarletteHTTPException)
6563
async def validation_error_handler(
@@ -75,5 +73,4 @@ async def validation_error_handler(
7573
error_code=exc.status_code,
7674
message=exc.detail,
7775
)
78-
json_response = json.dumps(response).encode(encoding='utf-8')
79-
return json_response
76+
return JSONResponse(response)

config/config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from starlette.config import Config
55

66

7-
base_dir = Path(__file__).resolve().parent.parent.parent
7+
base_dir = Path(__file__).resolve().parent.parent
88
log_dir = base_dir.joinpath('logs')
99

1010

config/setup_logs/__init__.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +0,0 @@
1-
from .logging import create_log_dirs
2-
3-
4-
__all__ = ('create_log_dirs',)

config/setup_logs/logging.py

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,13 @@
44
from config import settings
55

66

7-
log_dir = settings.LOG_DIR
8-
9-
10-
def create_log_dirs() -> None:
11-
"""
12-
Создание корневой папки для логов
13-
"""
14-
log_directory = settings.LOG_DIR
15-
log_directory.mkdir(parents=True, exist_ok=True)
16-
7+
log_directory = settings.LOG_DIR
8+
log_directory.mkdir(parents=True, exist_ok=True)
179

1810
logger.remove()
1911

2012
logger.add(
21-
log_dir.joinpath('access.log'),
13+
log_directory.joinpath('access.log'),
2214
rotation='15MB',
2315
format='{time:YYYY-MM-DD HH:mm:ss} - {level} - {message}',
2416
encoding='utf-8',
@@ -31,7 +23,7 @@ def create_log_dirs() -> None:
3123
)
3224

3325
logger.add(
34-
log_dir.joinpath('error.log'),
26+
log_directory.joinpath('error.log'),
3527
rotation='15MB',
3628
format='{time:YYYY-MM-DD HH:mm:ss} - {level} - {message}',
3729
encoding='utf-8',

main.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,13 @@
44
from config import db_connection, BaseModel
55
from api_v1 import register_routers
66
from app_includes import register_errors
7-
from config.setup_logs import create_log_dirs
87

98

109

1110
def start_app() -> FastAPI:
1211
"""
1312
Создание приложения со всеми настройками
1413
"""
15-
create_log_dirs()
1614
app = FastAPI(lifespan=lifespan)
1715
register_routers(app=app)
1816
register_errors(app=app)

0 commit comments

Comments
 (0)