Apply suggestions from code review

Author: pcarruscag

.github/workflows/regression.yml

@@ -128,7 +128,7 @@ jobs:
         uses: docker://ghcr.io/su2code/su2/test-su2:220614-1237
         with:
           # -t <Tutorials-branch> -c <Testcases-branch>
-          args: -b ${{github.ref}} -t develop -c update_vandv -s ${{matrix.testscript}}
+          args: -b ${{github.ref}} -t develop -c develop -s ${{matrix.testscript}}
       - name: Cleanup
         uses: docker://ghcr.io/su2code/su2/test-su2:220614-1237
         with:

TestCases/vandv.py

@@ -50,13 +50,13 @@ def main():
     test_list.append(p30n30)
 
     # flat plate - sst-v1994m
-    flatplate_sst1994m_restart           = TestCase('flatplate_sst1994m')
-    flatplate_sst1994m_restart.cfg_dir   = "vandv/rans/flatplate"
-    flatplate_sst1994m_restart.cfg_file  = "turb_flatplate_sst.cfg"
-    flatplate_sst1994m_restart.test_iter = 5
-    flatplate_sst1994m_restart.test_vals         = [-13.000480, -9.646253, -10.645471, -7.477528, -9.684807, -5.353455, 0.002809]
-    flatplate_sst1994m_restart.test_vals_aarch64 = [-13.000480, -9.646253, -10.645471, -7.477528, -9.684807, -5.353455, 0.002809]
-    test_list.append(flatplate_sst1994m_restart)
+    flatplate_sst1994m           = TestCase('flatplate_sst1994m')
+    flatplate_sst1994m.cfg_dir   = "vandv/rans/flatplate"
+    flatplate_sst1994m.cfg_file  = "turb_flatplate_sst.cfg"
+    flatplate_sst1994m.test_iter = 5
+    flatplate_sst1994m.test_vals         = [-13.044282, -9.682503, -10.712657, -7.519027, -9.742878, -5.374663, 0.002809]
+    flatplate_sst1994m.test_vals_aarch64 = [-13.044282, -9.682503, -10.712657, -7.519027, -9.742878, -5.374663, 0.002809]
+    test_list.append(flatplate_sst1994m)
 
     # bump in channel - sst-v1994m 
     bump_sst1994m           = TestCase('bump_sst1994m')
@@ -80,7 +80,7 @@ def main():
     swbli_sst.cfg_dir   = "vandv/rans/swbli"
     swbli_sst.cfg_file  = "config_sst.cfg"
     swbli_sst.test_iter = 20
-    swbli_sst.test_vals = [-11.020298, -10.520189, -11.572148, -10.164444, -11.112109, -3.678967, 0.002339, -2.979149, -5.343362, 1.3401]
+    swbli_sst.test_vals = [-11.030236, -10.542428, -11.668592, -10.210996, -11.121572, -3.875880, 0.002339, -2.472912, -5.464633, 2.786]
     test_list.append(swbli_sst)
 
     #################

TestCases/vandv/rans/bump_in_channel/turb_bump_sst.cfg

@@ -53,7 +53,8 @@ CONV_RESIDUAL_MINVAL= -13
 MESH_FILENAME= mesh_bump_2d_0089x041.cgns
 MESH_FORMAT= CGNS
 MESH_OUT_FILENAME= mesh_out.su2
-SOLUTION_FILENAME= restart_flow.dat
+SOLUTION_FILENAME= solution_flow.dat
+
 CONV_FILENAME= history
 RESTART_FILENAME= restart_flow.dat
 VOLUME_FILENAME= flow