Skip to content

Commit f5a0275

Browse files
Apply suggestions from code review
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
1 parent 75012f0 commit f5a0275

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

SU2_CFD/include/solvers/CIncEulerSolver.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -405,19 +405,19 @@ class CIncEulerSolver : public CFVMFlowSolverBase<CIncEulerVariable, ENUM_REGIME
405405
* \param[in] input - Boolean whether In- or Output should be registered.
406406
* \param[in] config - The particular config.
407407
*/
408-
void RegisterSolutionExtra(bool input, const CConfig* config);
408+
void RegisterSolutionExtra(bool input, const CConfig* config) final;
409409

410410
/*!
411411
* \brief Seed the adjoint of the extra solution at the output.
412412
* \param[in] adj_sol - Vector containing the adjoint solution to seed.
413413
* \param[in] config - The particular config.
414414
*/
415-
void SetAdjoint_SolutionExtra(const VectorType& adj_sol, const CConfig* config);
415+
void SetAdjoint_SolutionExtra(const VectorType& adj_sol, const CConfig* config) final;
416416

417417
/*!
418418
* \brief Extract the adjoint of the extra solution at the input.
419419
* \param[out] adj_sol - Vector to store the adjoint into.
420420
* \param[in] config - The particular config.
421421
*/
422-
void ExtractAdjoint_SolutionExtra(VectorType& adj_sol, const CConfig* config);
422+
void ExtractAdjoint_SolutionExtra(VectorType& adj_sol, const CConfig* config) final;
423423
};

SU2_CFD/include/solvers/CSolver.hpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,6 @@ using namespace std;
6464

6565
class CSolver {
6666
protected:
67-
using VectorType = C2DContainer<unsigned long, su2double, StorageType::ColumnMajor, 64, DynamicSize, 1>;
68-
6967
enum : size_t {OMP_MIN_SIZE = 32}; /*!< \brief Chunk size for small loops. */
7068

7169
int rank, /*!< \brief MPI Rank. */
@@ -3557,7 +3555,7 @@ class CSolver {
35573555
* \param[in] adj_sol - Vector containing the adjoint solution to seed.
35583556
* \param[in] config - The particular config.
35593557
*/
3560-
virtual void SetAdjoint_SolutionExtra(const VectorType& adj_sol, const CConfig* config) {}
3558+
virtual void SetAdjoint_SolutionExtra(const su2activevector& adj_sol, const CConfig* config) {}
35613559

35623560
/*!
35633561
* \brief Extract the adjoint of the extra solution at the input.

0 commit comments

Comments
 (0)