Merge pull request #1038 from su2code/cleanup_orientation_checks

Improving and cleaning element orientation checks

Author: pcarruscag

Common/include/geometry/CGeometry.hpp

@@ -751,13 +751,13 @@ class CGeometry {
    * \brief A virtual member.
    * \param[in] config - Definition of the particular problem.
    */
-  inline virtual void Check_IntElem_Orientation(CConfig *config) {}
+  inline virtual void Check_IntElem_Orientation(const CConfig *config) {}
 
   /*!
    * \brief A virtual member.
    * \param[in] config - Definition of the particular problem.
    */
-  inline virtual void Check_BoundElem_Orientation(CConfig *config) {}
+  inline virtual void Check_BoundElem_Orientation(const CConfig *config) {}
 
   /*!
    * \brief A virtual member.

Common/include/geometry/CPhysicalGeometry.hpp

@@ -517,13 +517,13 @@ class CPhysicalGeometry final : public CGeometry {
    * \brief Check the volume element orientation.
    * \param[in] config - Definition of the particular problem.
    */
-  void Check_IntElem_Orientation(CConfig *config) override;
+  void Check_IntElem_Orientation(const CConfig *config) override;
 
   /*!
    * \brief Check the volume element orientation.
    * \param[in] config - Definition of the particular problem.
    */
-  void Check_BoundElem_Orientation(CConfig *config) override;
+  void Check_BoundElem_Orientation(const CConfig *config) override;
 
   /*!
    * \brief Set the domains for grid grid partitioning using ParMETIS.

Common/include/geometry/primal_grid/CLine.hpp

@@ -142,10 +142,6 @@ class CLine final : public CPrimalGrid {
    * \brief Change the orientation of an element.
    */
   inline void Change_Orientation(void) override {
-    unsigned long Point_0, Point_1;
-    Point_0 = Nodes[0];
-    Point_1 = Nodes[1];
-    Nodes[0] = Point_1;
-    Nodes[1] = Point_0;
+    swap(Nodes[0], Nodes[1]);
   }
 };

Common/include/geometry/primal_grid/CTriangle.hpp

@@ -143,10 +143,6 @@ class CTriangle final: public CPrimalGrid {
    * \brief Change the orientation of an element.
    */
   inline void Change_Orientation(void) override {
-    unsigned long Point_0, Point_2;
-    Point_0 = Nodes[0];
-    Point_2 = Nodes[2];
-    Nodes[0] = Point_2;
-    Nodes[2] = Point_0;
+    swap(Nodes[0], Nodes[2]);
   }
 };