addressing some PR comments, merge in develop

Author: WallyMaier

SU2_CFD/include/numerics/CNumerics.hpp

@@ -1407,11 +1407,10 @@ class CNumerics {
    * \param[in] val_residual - residual of the numeric function.
    * \param[out] ERR - Presencse of NaN in vector
    */
-  static bool CheckResidualNaNs(bool implicit, int nVar, ResidualType<>(residual)){
+  static bool CheckResidualNaNs(bool implicit, int nVar, const ResidualType<> residual) {
 
     bool ERR = false;
-    bool jac_j = false;
-    if (residual.jacobian_j != nullptr) jac_j =true;
+    const bool jac_j = residual.jacobian_j != nullptr
 
     for (auto iVar = 0; iVar<nVar; iVar++){
       if (residual[iVar] != residual[iVar]) ERR = true;

SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

@@ -544,7 +544,7 @@ void CFVMFlowSolverBase<V, R>::ComputeUnderRelaxationFactor(const CConfig* confi
       /* We impose a limit on the maximum percentage that the
        density and energy can change over a nonlinear iteration. */
 
-      if ((iVar == 0)  || (iVar >= nVar - 1)) {
+      if ((iVar == 0)  || (iVar == nVar - 1)) {
         const unsigned long index = iPoint * nVar + iVar;
         su2double ratio = fabs(LinSysSol[index]) / (fabs(nodes->GetSolution(iPoint, iVar)) + EPS);
         if (ratio > allowableRatio) {

SU2_CFD/include/solvers/CNEMOEulerSolver.hpp

@@ -204,7 +204,7 @@ class CNEMOEulerSolver : public CFVMFlowSolverBase<CNEMOEulerVariable, ENUM_REGI
    * a nonlinear iteration for stability.
    * \param[in] config - Definition of the particular problem.
    */
-  void ComputeUnderRelaxationFactor(const CConfig *config) override;
+  void ComputeUnderRelaxationFactor(const CConfig *config) final;
 
   /*!
    * \brief Set the fluid solver nondimensionalization.

SU2_CFD/src/numerics/NEMO/NEMO_sources.cpp

@@ -110,7 +110,7 @@ CNumerics::ResidualType<> CSource_NEMO::ComputeChemistry(const CConfig *config)
   if (implicit) {
     for (iVar = 0; iVar<nVar; iVar++) {
       for (jVar = 0; jVar<nVar; jVar++) {
-      jacobian[iVar][jVar] = jacobian[iVar][jVar] * Volume;
+        jacobian[iVar][jVar] *= Volume;
       }
     }
   }
@@ -164,13 +164,13 @@ CNumerics::ResidualType<> CSource_NEMO::ComputeVibRelaxation(const CConfig *conf
 
   residual[nSpecies+nDim+1] = VTterm * Volume;
 
-    if (implicit) {
-      for (iVar = 0; iVar<nVar; iVar++) {
-        for (jVar = 0; jVar<nVar; jVar++) {
-        jacobian[iVar][jVar] = jacobian[iVar][jVar] * Volume;
-        }
+  if (implicit) {
+    for (iVar = 0; iVar<nVar; iVar++) {
+      for (jVar = 0; jVar<nVar; jVar++) {
+        jacobian[iVar][jVar] *= Volume;
       }
     }
+  }
 
   /*--- Relax/limit vt transfer ---*/
   if(config->GetVTTransferResidualLimiting()){

SU2_CFD/src/solvers/CNEMOEulerSolver.cpp

@@ -959,12 +959,12 @@ void CNEMOEulerSolver::ComputeUnderRelaxationFactor(const CConfig *config) {
           }
         }
 
-	/*--- Energy ---*/
+        /*--- Energy ---*/
         if (iVar == (nVar-2)){
           su2double ratio = fabs(LinSysSol[index]) / (fabs(nodes->GetSolution(iPoint, iVar)) + EPS);
           if (ratio > allowableRatio) {
             localUnderRelaxation = min(allowableRatio / ratio, localUnderRelaxation);
-	  }
+          }
         }
       }
     }