Skip to content

Commit df19e32

Browse files
committed
change from code review
1 parent 75b6ffd commit df19e32

3 files changed

Lines changed: 92 additions & 39 deletions

File tree

.idea/workspace.xml

Lines changed: 92 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

SU2_CFD/include/fluid/CCoolPropConductivity.hpp

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -45,29 +45,6 @@ class CCoolPropConductivity final : public CConductivityModel {
4545
std::unique_ptr<CoolProp::AbstractState> fluid_entity; /*!< \brief fluid entity */
4646
#endif
4747
/*!< \brief list of fluids whose conductivity model is available in CoolProp */
48-
<<<<<<< HEAD
49-
vector<string> fluidNameList = {"Air", "Ammonia", "Argon", "Benzene", "CarbonDioxide", "Cyclopentane", "EthylBenzene",
50-
"Ethane", "Ethanol", "HeavyWater", "Helium", "Hydrogen", "IsoButane", "Isopentane",
51-
"Methane", "Methanol", "Nitrogen", "Oxygen", "Propylene", "ParaHydrogen", "R11", "R116" , "R12", "R123",
52-
"R1234yf", "R1234ze(E)", "R124", "R125", "R13", "R134a", "R14", "R141b", "R142b", "R143a", "R152A",
53-
"R218", "R22", "R227EA", "R23", "R236EA", "R236FA", "R245fa", "R32", "R404A", "R407C", "R410A", "R507A",
54-
"RC318", "SulfurHexafluoride", "Toluene", "Water", "m-Xylene", "n-Butane", "n-Decane", "n-Dodecane", "n-Heptane",
55-
"n-Hexane", "n-Nonane", "n-Octane", "n-Pentane", "n-Propane", "o-Xylene", "p-Xylene"};
56-
public:
57-
/*!
58-
* \brief Constructor of the class.
59-
*/
60-
CCoolPropConductivity (const string& fluidname) {
61-
#ifdef USE_COOLPROP
62-
fluid_entity = std::unique_ptr<CoolProp::AbstractState>(CoolProp::AbstractState::factory("HEOS",fluidname));
63-
if (std::find(fluidNameList.begin(), fluidNameList.end(), fluidname) == fluidNameList.end()){
64-
SU2_MPI::Error("Conductivity model not available for this fluid in CoolProp library.", CURRENT_FUNCTION);
65-
}
66-
#else
67-
SU2_MPI::Error("SU2 was not compiled with CoolProp (-Denable-coolprop=true). Note that CoolProp cannot be used with directdiff or autodiff", CURRENT_FUNCTION);
68-
#endif
69-
}
70-
=======
7148
vector<string> fluidNameList = {
7249
"Air", "Ammonia", "Argon", "Benzene", "CarbonDioxide", "Cyclopentane", "EthylBenzene",
7350
"Ethane", "Ethanol", "HeavyWater", "Helium", "Hydrogen", "IsoButane", "Isopentane",
@@ -78,7 +55,6 @@ class CCoolPropConductivity final : public CConductivityModel {
7855
"R32", "R404A", "R407C", "R410A", "R507A", "RC318", "SulfurHexafluoride",
7956
"Toluene", "Water", "m-Xylene", "n-Butane", "n-Decane", "n-Dodecane", "n-Heptane",
8057
"n-Hexane", "n-Nonane", "n-Octane", "n-Pentane", "n-Propane", "o-Xylene", "p-Xylene"};
81-
>>>>>>> e673611876 (git fetch)
8258

8359
public:
8460
/*!

SU2_CFD/include/fluid/CCoolPropViscosity.hpp

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -45,20 +45,6 @@ class CCoolPropViscosity final : public CViscosityModel {
4545
std::unique_ptr<CoolProp::AbstractState> fluid_entity; /* \brief fluid entity */
4646
#endif
4747
/* \brief list of fluids whose viscosity model is available in CoolProp */
48-
<<<<<<< HEAD
49-
vector<string> fluidNameList = {"Air", "Ammonia", "Argon", "Benzene", "CarbonDioxide", "CycloHexane", "Cyclopentane", "DimethylEther",
50-
"Ethane", "Ethanol", "HeavyWater", "Helium", "Hydrogen", "HydrogenSulfide", "IsoButane", "Isopentane",
51-
"Methane", "Methanol", "Nitrogen", "Oxygen", "Propylene", "R11", "R116" , "R12", "R123", "R1233zd(E)",
52-
"R1234yf", "R1234ze(E)", "R124", "R125", "R13", "R134a", "R14", "R141b", "R142b", "R143a", "R152A",
53-
"R218", "R22", "R227EA", "R23", "R236EA", "R236FA", "R245fa", "R32", "R404A", "R407C", "R410A", "R507A",
54-
"RC318", "SulfurHexafluoride", "Toluene", "Water", "m-Xylene", "n-Butane", "n-Decane", "n-Dodecane", "n-Heptane",
55-
"n-Hexane", "n-Nonane", "n-Octane", "n-Pentane", "n-Propane", "o-Xylene", "p-Xylene"};
56-
public:
57-
/*!
58-
* \brief Constructor of the class.
59-
*/
60-
CCoolPropViscosity (const string& fluidname) {
61-
=======
6248
vector<string> fluidNameList = {"Air",
6349
"Ammonia",
6450
"Argon",
@@ -130,7 +116,6 @@ class CCoolPropViscosity final : public CViscosityModel {
130116
* \brief Constructor of the class.
131117
*/
132118
CCoolPropViscosity(const string& fluidname) {
133-
>>>>>>> e673611876 (git fetch)
134119
#ifdef USE_COOLPROP
135120
fluid_entity = std::unique_ptr<CoolProp::AbstractState>(CoolProp::AbstractState::factory("HEOS", fluidname));
136121
if (std::find(fluidNameList.begin(), fluidNameList.end(), fluidname) == fluidNameList.end()) {

0 commit comments

Comments
 (0)