I think I got all issues

Author: WallyMaier

SU2_CFD/src/numerics/NEMO/NEMO_diffusion.cpp

@@ -167,7 +167,7 @@ CNumerics::ResidualType<> CAvgGrad_NEMO::ComputeResidual(const CConfig *config)
   /*--- Compute the implicit part ---*/
   if (implicit) {
 
-  su2double dist_ij_2[nDim] = {0.0};
+  su2double dist_ij_2[MAXNDIM] = {0.0};
   GeometryToolbox::Distance(nDim, Coord_j, Coord_i, dist_ij_2);
   dist_ij = GeometryToolbox::SquaredNorm(nDim, dist_ij_2);
 

SU2_CFD/src/numerics/NEMO/NEMO_sources.cpp

@@ -195,9 +195,7 @@ CNumerics::ResidualType<> CSource_NEMO::ComputeAxisymmetric(const CConfig *confi
   if (Coord_i[1]!= 0.0) yinv = 1.0/Coord_i[1];
   else yinv = 0.0;
 
-  /*--- Rename for convenience ---*/
-  const su2double vel2 = GeometryToolbox::SquaredNorm(nDim, &V_i[VEL_INDEX]);
-
+  /*--- Rename mass flux for convenience ---*/
   for (auto iSpecies = 0ul; iSpecies < nSpecies; iSpecies++)
     Y[iSpecies] = V_i[RHOS_INDEX+iSpecies] / rho;
 

SU2_CFD/src/numerics/NEMO/convection/msw.cpp

@@ -172,7 +172,7 @@ CNumerics::ResidualType<> CUpwMSW_NEMO::ComputeResidual(const CConfig *config) {
   fluidmodel->ComputedPdU(Vst_j, eves_st_j, dPdUst_j);
 
   /*--- Flow eigenvalues at i (Lambda+) ---*/
-  for (auto iVar = 0ul; iVar < nSpecies+nDim-1; iVar++)
+  for (auto iVar = 0; iVar < nSpecies+nDim-1; iVar++)
     Lambda_i[iVar]          = 0.5*(ProjVelst_i + sqrt(ProjVelst_i*ProjVelst_i +
                                                       epsilon*epsilon));
   Lambda_i[nSpecies+nDim-1] = 0.5*(ProjVelst_i + Vst_i[A_INDEX] +
@@ -208,7 +208,7 @@ CNumerics::ResidualType<> CUpwMSW_NEMO::ComputeResidual(const CConfig *config) {
   }
 
   /*--- Flow eigenvalues at j (Lambda-) ---*/
-  for (auto iVar = 0ul; iVar < nSpecies+nDim-1; iVar++)
+  for (auto iVar = 0; iVar < nSpecies+nDim-1; iVar++)
     Lambda_j[iVar]          = 0.5*(ProjVelst_j - sqrt(ProjVelst_j*ProjVelst_j +
                                                       epsilon*epsilon));
   Lambda_j[nSpecies+nDim-1] = 0.5*(ProjVelst_j + Vst_j[A_INDEX] -

SU2_CFD/src/numerics/NEMO/convection/roe.cpp

@@ -136,7 +136,7 @@ CNumerics::ResidualType<> CUpwRoe_NEMO::ComputeResidual(const CConfig *config) {
   for (auto iSpecies = 0ul; iSpecies < nSpecies; iSpecies++)
     Lambda[iSpecies] = ProjVelocity;
 
-  for (auto iDim = 0ul; iDim < nDim-1; iDim++)
+  for (auto iDim = 0; iDim < nDim-1; iDim++)
     Lambda[nSpecies+iDim] = ProjVelocity;
 
   Lambda[nSpecies+nDim-1] = ProjVelocity + RoeSoundSpeed;
@@ -147,7 +147,7 @@ CNumerics::ResidualType<> CUpwRoe_NEMO::ComputeResidual(const CConfig *config) {
   for (auto iSpecies = 0ul; iSpecies < nSpecies; iSpecies++)
     Epsilon[iSpecies] = 4.0*max(0.0, max(Lambda[iSpecies]-ProjVelocity_i,
                                          ProjVelocity_j-Lambda[iSpecies] ));
-  for (auto iDim = 0ul; iDim < nDim-1; iDim++)
+  for (auto iDim = 0; iDim < nDim-1; iDim++)
     Epsilon[nSpecies+iDim] = 4.0*max(0.0, max(Lambda[iDim]-ProjVelocity_i,
                                               ProjVelocity_j-Lambda[iDim] ));
   Epsilon[nSpecies+nDim-1] = 4.0*max(0.0, max(Lambda[nSpecies+nDim-1]-(ProjVelocity_i+V_i[A_INDEX]),

SU2_CFD/src/solvers/CNEMOEulerSolver.cpp

@@ -942,7 +942,7 @@ void CNEMOEulerSolver::ComputeUnderRelaxationFactor(const CConfig *config) {
     su2double num = 0.0;
     su2double denom = 0.0;
 
-    for (auto iVar = 0ul; iVar < nVar; iVar++) {
+    for (auto iVar = 0; iVar < nVar; iVar++) {
       /* We impose a limit on the maximum percentage that the
        density (sum of all species) and energy can change over a nonlinear iteration. */
 
@@ -2001,8 +2001,8 @@ void CNEMOEulerSolver::BC_Outlet(CGeometry *geometry, CSolver **solver_container
         //     V: [rho1, ..., rhoNs, T, Tve, u, v, w, P, rho, h, a, rhoCvtr, rhoCvve]^T
         Density    = pow(P_Exit/Entropy,1.0/Gamma);
         Pressure   = P_Exit;
-        const su2double SoundSpeed = sqrt(Gamma*P_Exit/Density);
-        Vn_Exit    = Riemann - 2.0*SoundSpeed/Gamma_Minus_One;
+        SoundSpeed = sqrt(Gamma*P_Exit/Density);
+        const su2double Vn_Exit    = Riemann - 2.0*SoundSpeed/Gamma_Minus_One;
         Velocity2  = 0.0;
         for (auto iDim = 0ul; iDim < nDim; iDim++) {
           Velocity[iDim] = Velocity[iDim] + (Vn_Exit-Vn)*UnitNormal[iDim];

SU2_CFD/src/solvers/CNEMONSSolver.cpp

@@ -349,8 +349,7 @@ void CNEMONSSolver::BC_HeatFluxCatalytic_Wall(CGeometry *geometry,
   SU2_MPI::Error("BC_HEATFLUX with catalytic wall: Not operational in NEMO.", CURRENT_FUNCTION);
   //TODO: SCALE WITH EDDY VISC
   /*--- Local variables ---*/
-  unsigned short iDim, iSpecies, iVar;
-  unsigned long iVertex, iPoint, total_index;
+  unsigned long iPoint, total_index;
   su2double rho, Ys;
   su2double *Normal, Area;
   su2double *Ds, *dYdn, SdYdn;