codeQL

Author: pcarruscag

Common/include/grid_movement/CRadialBasisFunctionNode.hpp

@@ -35,55 +35,54 @@
  * \author F. van Steen
  */
 
-class CRadialBasisFunctionNode{
+class CRadialBasisFunctionNode {
  protected:
-  unsigned long idx;          /*!< \brief Global index. */
-  unsigned short marker_idx;  /*!< \brief Marker index. */
-  unsigned long vertex_idx;   /*!< \brief Vertex index. */
-    
-  su2double error[3];         /*!< \brief Nodal data reduction error; */
-    
-  public:
+  unsigned long idx;         /*!< \brief Global index. */
+  unsigned short marker_idx; /*!< \brief Marker index. */
+  unsigned long vertex_idx;  /*!< \brief Vertex index. */
 
+  su2double error[3]; /*!< \brief Nodal data reduction error. */
+
+ public:
   /*!
-  * \brief Constructor of the class.
-  * \param[in] idx_val - Local node index.
-  * \param[in] marker_val - Local marker index.
-  * \param[in] vertex_val - Local vertex index.
-  */
+   * \brief Constructor of the class.
+   * \param[in] idx_val - Local node index.
+   * \param[in] marker_val - Local marker index.
+   * \param[in] vertex_val - Local vertex index.
+   */
   CRadialBasisFunctionNode(unsigned long idx_val, unsigned short marker_val, unsigned long vertex_val);
 
   /*!
-  * \brief Returns local global index.
-  * \return Local node index.
-  */
-  inline unsigned long GetIndex(){return idx;}
+   * \brief Returns local global index.
+   * \return Local node index.
+   */
+  inline unsigned long GetIndex() { return idx; }
 
   /*!
-  * \brief Returns local vertex index.
-  * \return Local vertex index.
-  */
-  inline unsigned long GetVertex(){return vertex_idx;}
+   * \brief Returns local vertex index.
+   * \return Local vertex index.
+   */
+  inline unsigned long GetVertex() { return vertex_idx; }
 
   /*!
-  * \brief Returns local marker index.
-  * \return Local marker index.
-  */
-  inline unsigned short GetMarker(){return marker_idx;}
+   * \brief Returns local marker index.
+   * \return Local marker index.
+   */
+  inline unsigned short GetMarker() { return marker_idx; }
 
   /*!
-  * \brief Set error of the RBF node.
-  * \param val_error - Nodal error.
-  * \param nDim - Number of dimensions.
-  */
+   * \brief Set error of the RBF node.
+   * \param val_error - Nodal error.
+   * \param nDim - Number of dimensions.
+   */
 
   inline void SetError(const su2double* val_error, unsigned short nDim) {
     for (auto iDim = 0u; iDim < nDim; iDim++) error[iDim] = val_error[iDim];
   }
 
   /*!
-  * \brief Get nodal error.
-  * \return Nodal error.
-  */
-  inline su2double* GetError(){ return error;}
-};
+   * \brief Get nodal error.
+   * \return Nodal error.
+   */
+  inline su2double* GetError() { return error; }
+};

Common/src/grid_movement/CLinearElasticity.cpp

@@ -419,8 +419,8 @@ void CLinearElasticity::SetFEA_StiffMatrix2D(CGeometry* geometry, CConfig* confi
   su2double Location[4][3], Weight[4];
   unsigned short nVar = geometry->GetnDim();
 
-  for (iVar = 0; iVar < nNodes * nVar; iVar++) {
-    for (jVar = 0; jVar < nNodes * nVar; jVar++) {
+  for (iVar = 0; iVar < static_cast<unsigned short>(nNodes * nVar); iVar++) {
+    for (jVar = 0; jVar < static_cast<unsigned short>(nNodes * nVar); jVar++) {
       StiffMatrix_Elem[iVar][jVar] = 0.0;
     }
   }
@@ -465,7 +465,7 @@ void CLinearElasticity::SetFEA_StiffMatrix2D(CGeometry* geometry, CConfig* confi
     /*--- Compute the B Matrix ---*/
 
     for (iVar = 0; iVar < 3; iVar++)
-      for (jVar = 0; jVar < nNodes * nVar; jVar++) B_Matrix[iVar][jVar] = 0.0;
+      for (jVar = 0; jVar < static_cast<unsigned short>(nNodes * nVar); jVar++) B_Matrix[iVar][jVar] = 0.0;
 
     for (iNode = 0; iNode < nNodes; iNode++) {
       B_Matrix[0][0 + iNode * nVar] = DShapeFunction[iNode][0];
@@ -507,7 +507,7 @@ void CLinearElasticity::SetFEA_StiffMatrix2D(CGeometry* geometry, CConfig* confi
 
     /*--- Compute the BT.D Matrix ---*/
 
-    for (iVar = 0; iVar < nNodes * nVar; iVar++) {
+    for (iVar = 0; iVar < static_cast<unsigned short>(nNodes * nVar); iVar++) {
       for (jVar = 0; jVar < 3; jVar++) {
         Aux_Matrix[iVar][jVar] = 0.0;
         for (kVar = 0; kVar < 3; kVar++) Aux_Matrix[iVar][jVar] += B_Matrix[kVar][iVar] * D_Matrix[kVar][jVar];
@@ -517,8 +517,8 @@ void CLinearElasticity::SetFEA_StiffMatrix2D(CGeometry* geometry, CConfig* confi
     /*--- Compute the BT.D.B Matrix (stiffness matrix), and add to the original
      matrix using Gauss integration ---*/
 
-    for (iVar = 0; iVar < nNodes * nVar; iVar++) {
-      for (jVar = 0; jVar < nNodes * nVar; jVar++) {
+    for (iVar = 0; iVar < static_cast<unsigned short>(nNodes * nVar); iVar++) {
+      for (jVar = 0; jVar < static_cast<unsigned short>(nNodes * nVar); jVar++) {
         for (kVar = 0; kVar < 3; kVar++) {
           StiffMatrix_Elem[iVar][jVar] += Weight[iGauss] * Aux_Matrix[iVar][kVar] * B_Matrix[kVar][jVar] * fabs(Det);
         }