Skip to content

Commit a8c5e15

Browse files
authored
Merge pull request #2165 from pcarruscag/update_tests
Update tests and fix windows compilation
2 parents b602673 + aa815c9 commit a8c5e15

4 files changed

Lines changed: 12 additions & 9 deletions

File tree

SU2_CFD/src/solvers/CEulerSolver.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4329,7 +4329,7 @@ void CEulerSolver::SetActDisk_BEM_VLAD(CGeometry *geometry, CSolver **solver_con
43294329
su2double n, omega, a0, den;
43304330
su2double ang_offset = 0.0;
43314331

4332-
radtodeg = 180.0 / M_PI;
4332+
radtodeg = 180.0 / PI_NUMBER;
43334333
r_hub = ADBem_HubRadius;
43344334
ang_offset = blade_angle - ADBem_Angle75R;
43354335

@@ -4339,7 +4339,7 @@ void CEulerSolver::SetActDisk_BEM_VLAD(CGeometry *geometry, CSolver **solver_con
43394339
a0 = sqrt(1.4 * 287 * T);
43404340
/*--- Change pitch by ang_offset and calculate delta_r for integration by trapezoidal rule. ---*/
43414341
n = RPM / 60.0;
4342-
omega = n * 2.0 * M_PI;
4342+
omega = n * 2.0 * PI_NUMBER;
43434343

43444344
for (j = 0; j < NR; j++) {
43454345
if (j < 1) {
@@ -4416,7 +4416,7 @@ void CEulerSolver::SetActDisk_BEM_VLAD(CGeometry *geometry, CSolver **solver_con
44164416
c_phi = cos(phi);
44174417
t_loss = 1.0;
44184418
if (r_dash > 0.90) {
4419-
t_loss = (2.0 / M_PI) * acos(exp(-(1.0 * s_prop_nblades * (1 - r_dash) / (r_dash * c_phi))));
4419+
t_loss = (2.0 / PI_NUMBER) * acos(exp(-(1.0 * s_prop_nblades * (1 - r_dash) / (r_dash * c_phi))));
44204420
}
44214421

44224422
DtDr[j] = q * s_prop_nblades * sprop_sec_chord[j] * (cl * cos(phi) - cd * sin(phi));
@@ -4425,7 +4425,7 @@ void CEulerSolver::SetActDisk_BEM_VLAD(CGeometry *geometry, CSolver **solver_con
44254425
DtDr[j] *= t_loss;
44264426
DqDr *= t_loss;
44274427

4428-
tem2 = DqDr / (4.0 * M_PI * rad * rad * rad * rho * V * omega);
4428+
tem2 = DqDr / (4.0 * PI_NUMBER * rad * rad * rad * rho * V * omega);
44294429
bnew = 0.6 * b[j] + 0.4 * tem2;
44304430
if (bnew > 0.9) bnew = 0.9;
44314431
if (fabs(bnew - b[j]) < 1.0e-5) {
@@ -4447,11 +4447,11 @@ void CEulerSolver::SetActDisk_BEM_VLAD(CGeometry *geometry, CSolver **solver_con
44474447
tem1 = rho * n * n * dia * dia * dia * dia;
44484448
tem2 = tem1 * dia;
44494449

4450-
Torque = 2.0 * M_PI * torque;
4451-
dp_av = 2.0 * M_PI * torque;
4450+
Torque = 2.0 * PI_NUMBER * torque;
4451+
dp_av = 2.0 * PI_NUMBER * torque;
44524452

44534453
for (j = 0; j < NR; j++) {
4454-
DtDr[j] /= (2.0 * M_PI * sprop_sec_r1[j]);
4454+
DtDr[j] /= (2.0 * PI_NUMBER * sprop_sec_r1[j]);
44554455
Dtorq[j] = Dtorq[j];
44564456
}
44574457

@@ -4495,7 +4495,7 @@ void CEulerSolver::SetActDisk_BEM_VLAD(CGeometry *geometry, CSolver **solver_con
44954495

44964496
ActDisk_DeltaP_r[iMarker][iVertex] = Target_Press_Jump;
44974497
ActDisk_Thrust_r[iMarker][iVertex] = dp_at_r;
4498-
ActDisk_Torque_r[iMarker][iVertex] = Torque / (2 * M_PI * radius);
4498+
ActDisk_Torque_r[iMarker][iVertex] = Torque / (2 * PI_NUMBER * radius);
44994499
/*--- Non-dimensionalize the elemental load. ---*/
45004500
const su2double dCp_v = Torque * ((Omega_sw * r_tip) / (rho * rps * rps * rps * pow(dia, 5)));
45014501
/*--- Force radial load to 0 as there is no information of radial load from BEM. ---*/

TestCases/TestCase.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ def run_filediff(self, running_with_tsan=False):
361361
if len(fromlines) != len(tolines):
362362
diff = ["ERROR: Number of lines in " + fromfile + " and " + tofile + " differ."]
363363
passed = False
364-
364+
365365
# Loop through all lines
366366
for i_line in range(0, len(fromlines)):
367367

TestCases/hybrid_regression.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -771,6 +771,7 @@ def main():
771771
pywrapper_translating_naca0012.reference_file = "forces_0.csv.ref"
772772
pywrapper_translating_naca0012.reference_file_aarch64 = "forces_0_aarch64.csv.ref"
773773
pywrapper_translating_naca0012.test_file = "forces_0.csv"
774+
pywrapper_translating_naca0012.tol_file_percent = 0.1
774775
pywrapper_translating_naca0012.enabled_on_cpu_arch = ["x86_64"]
775776
pywrapper_translating_naca0012.enabled_with_tsan = False
776777
file_diff_list.append(pywrapper_translating_naca0012)
@@ -784,6 +785,7 @@ def main():
784785
pywrapper_updated_moving_frame_naca0012.reference_file = "forces_0.csv.ref"
785786
pywrapper_updated_moving_frame_naca0012.reference_file_aarch64 = "forces_0_aarch64.csv.ref"
786787
pywrapper_updated_moving_frame_naca0012.test_file = "forces_0.csv"
788+
pywrapper_updated_moving_frame_naca0012.tol_file_percent = 0.1
787789
pywrapper_updated_moving_frame_naca0012.enabled_on_cpu_arch = ["x86_64"]
788790
pywrapper_updated_moving_frame_naca0012.enabled_with_tsan = False
789791
file_diff_list.append(pywrapper_updated_moving_frame_naca0012)

TestCases/serial_regression.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1067,6 +1067,7 @@ def main():
10671067
airfoilRBF.cfg_file = "config.cfg"
10681068
airfoilRBF.test_iter = 1
10691069
airfoilRBF.test_vals = [1.000000, -2.786186, -4.977944]
1070+
airfoilRBF.tol = 0.0001
10701071
airfoilRBF.multizone = True
10711072
test_list.append(airfoilRBF)
10721073

0 commit comments

Comments
 (0)