cleaning includes and using factory class

Author: talbring

SU2_CFD/include/SU2_CFD.hpp

@@ -43,7 +43,6 @@
 #include "../../Common/include/grid_movement_structure.hpp"
 #include "../../Common/include/CConfig.hpp"
 #include "../include/definition_structure.hpp"
-#include "../include/iteration_structure.hpp"
 #include "../include/interfaces/CInterface.hpp"
 
 using namespace std;

SU2_CFD/include/drivers/CDriver.hpp

@@ -30,7 +30,6 @@
 
 #include "../../../Common/include/mpi_structure.hpp"
 
-#include "../iteration_structure.hpp"
 #include "../integration/CIntegration.hpp"
 #include "../solvers/CSolver.hpp"
 #include "../interfaces/CInterface.hpp"
@@ -42,6 +41,8 @@ using namespace std;
 
 class COutputLegacy;
 class CInterpolator;
+class CIteration;
+class COutput;
 
 /*!
  * \class CDriver

SU2_CFD/include/drivers/CMultizoneDriver.hpp

@@ -135,7 +135,5 @@ class CMultizoneDriver : public CDriver {
    * \brief  Returns whether all specified windowed-time-averaged ouputs have been converged
    * \return Boolean indicating whether the problem is converged.
    */
-  inline virtual bool GetTimeConvergence() const{
-    return driver_output->GetTimeConvergence();
-  }
+  virtual bool GetTimeConvergence() const;
 };

SU2_CFD/include/drivers/CSinglezoneDriver.hpp

@@ -102,10 +102,7 @@ class CSinglezoneDriver : public CDriver {
      * \brief  Returns whether all specified windowed-time-averaged ouputs have been converged
      * \return Boolean indicating whether the problem is converged.
      */
-  inline virtual bool GetTimeConvergence() const{
-    return output_container[ZONE_0]->GetTimeConvergence();
-  }
-
+  virtual bool GetTimeConvergence() const;
 
   /*!
    * \brief Runtime_Parsing

SU2_CFD/include/iteration/CAdjFluidIteration.hpp

@@ -41,7 +41,7 @@ class CAdjFluidIteration : public CFluidIteration {
    * \brief Constructor of the class.
    * \param[in] config - Definition of the particular problem.
    */
-  CAdjFluidIteration(CConfig* config);
+  CAdjFluidIteration(const CConfig* config);
 
   /*!
    * \brief Destructor of the class.

SU2_CFD/include/iteration/CDiscAdjFEAIteration.hpp

@@ -47,7 +47,7 @@ class CDiscAdjFEAIteration : public CIteration {
    * \brief Constructor of the class.
    * \param[in] config - Definition of the particular problem.
    */
-  CDiscAdjFEAIteration(CConfig* config);
+  CDiscAdjFEAIteration(const CConfig* config);
 
   /*!
    * \brief Destructor of the class.
@@ -237,4 +237,4 @@ class CDiscAdjFEAIteration : public CIteration {
    */
   void LoadDynamic_Solution(CGeometry**** geometry, CSolver***** solver, CConfig** config, unsigned short val_iZone,
                             unsigned short val_iInst, int val_DirectIter) override;
-};
+};

SU2_CFD/include/iteration/CDiscAdjFluidIteration.hpp

@@ -48,7 +48,7 @@ class CDiscAdjFluidIteration : public CIteration {
    * \brief Constructor of the class.
    * \param[in] config - Definition of the particular problem.
    */
-  CDiscAdjFluidIteration(CConfig* config);
+  CDiscAdjFluidIteration(const CConfig* config);
 
   /*!
    * \brief Destructor of the class.
@@ -242,4 +242,4 @@ class CDiscAdjFluidIteration : public CIteration {
    */
   void LoadUnsteady_Solution(CGeometry**** geometry, CSolver***** solver, CConfig** config, unsigned short val_iZone,
                              unsigned short val_iInst, int val_DirectIter) override;
-};
+};

SU2_CFD/include/iteration/CDiscAdjHeatIteration.hpp

@@ -47,7 +47,7 @@ class CDiscAdjHeatIteration : public CIteration {
    * \brief Constructor of the class.
    * \param[in] config - Definition of the particular problem.
    */
-  CDiscAdjHeatIteration(CConfig* config);
+  CDiscAdjHeatIteration(const CConfig* config);
 
   /*!
    * \brief Destructor of the class.
@@ -234,4 +234,4 @@ class CDiscAdjHeatIteration : public CIteration {
    */
   void LoadUnsteady_Solution(CGeometry**** geometry, CSolver***** solver, CConfig** config, unsigned short val_iZone,
                              unsigned short val_iInst, int val_DirectIter) override;
-};
+};

SU2_CFD/include/iteration/CFEAIteration.hpp

@@ -42,7 +42,7 @@ class CFEAIteration : public CIteration {
    * \brief Constructor of the class.
    * \param[in] config - Definition of the particular problem.
    */
-  CFEAIteration(CConfig* config);
+  CFEAIteration(const CConfig* config);
 
   /*!
    * \brief Destructor of the class.

SU2_CFD/include/iteration/CFEMFluidIteration.hpp

@@ -42,7 +42,7 @@ class CFEMFluidIteration : public CFluidIteration {
    * \brief Constructor of the class.
    * \param[in] config - Definition of the particular problem.
    */
-  CFEMFluidIteration(CConfig* config);
+  CFEMFluidIteration(const CConfig* config);
 
   /*!
    * \brief Destructor of the class.
@@ -101,4 +101,4 @@ class CFEMFluidIteration : public CFluidIteration {
                    CNumerics****** numerics, CConfig** config, CSurfaceMovement** surface_movement,
                    CVolumetricMovement*** grid_movement, CFreeFormDefBox*** FFDBox, unsigned short val_iZone,
                    unsigned short val_iInst) override;
-};
+};