silence misc. warnings

Author: pcarruscag

Common/src/geometry/CGeometry.cpp

@@ -1795,7 +1795,6 @@ void CGeometry::ComputeAirfoil_Section(su2double *Plane_P0, su2double *Plane_Nor
   vector<unsigned long> IGlobalID_Index0, JGlobalID_Index0, IGlobalID_Index1, JGlobalID_Index1, IGlobalID_Airfoil, JGlobalID_Airfoil;
   vector<unsigned short> Conection_Index0, Conection_Index1;
   vector<unsigned long> Duplicate;
-  vector<unsigned long>::iterator it;
   su2double **Coord_Variation = nullptr;
   vector<su2double> XcoordExtra, YcoordExtra, ZcoordExtra, VariableExtra;
   vector<unsigned long> IGlobalIDExtra, JGlobalIDExtra;
@@ -2778,8 +2777,7 @@ void CGeometry::ComputeSurf_Curvature(CConfig *config) {
   unsigned short iMarker, iNeigh_Point, iDim, iNode, iNeighbor_Nodes, Neighbor_Node;
   unsigned long Neighbor_Point, iVertex, iPoint, jPoint, iElem_Bound, iEdge, nLocalVertex, MaxLocalVertex , *Buffer_Send_nVertex, *Buffer_Receive_nVertex, TotalnPointDomain;
   vector<unsigned long> Point_NeighborList, Elem_NeighborList, Point_Triangle, Point_Edge, Point_Critical;
-  vector<unsigned long>::iterator it;
-  su2double U[3] = {0.0,0.0,0.0}, V[3] = {0.0,0.0,0.0}, W[3] = {0.0,0.0,0.0}, Length_U, Length_V, Length_W, CosValue, Angle_Value, *K, *Angle_Defect, *Area_Vertex, *Angle_Alpha, *Angle_Beta, **NormalMeanK, MeanK, GaussK, MaxPrinK, cot_alpha, cot_beta, delta, X1, X2, X3, Y1, Y2, Y3, radius, *Buffer_Send_Coord, *Buffer_Receive_Coord, *Coord, Dist, MinDist, MaxK, MinK, SigmaK;
+  su2double U[3] = {0.0}, V[3] = {0.0}, W[3] = {0.0}, Length_U, Length_V, Length_W, CosValue, Angle_Value, *K, *Angle_Defect, *Area_Vertex, *Angle_Alpha, *Angle_Beta, **NormalMeanK, MeanK, GaussK, MaxPrinK, cot_alpha, cot_beta, delta, X1, X2, X3, Y1, Y2, Y3, radius, *Buffer_Send_Coord, *Buffer_Receive_Coord, *Coord, Dist, MinDist, MaxK, MinK, SigmaK;
   bool *Check_Edge;
 
   const bool fea = config->GetStructuralProblem();

Common/src/geometry/CPhysicalGeometry.cpp

@@ -1092,7 +1092,6 @@ void CPhysicalGeometry::DistributePoints(const CConfig *config, CGeometry *geome
 
   unsigned short iDim;
   unsigned long iPoint, iNeighbor, jPoint, iProcessor;
-  vector<unsigned long>::iterator it;
 
   SU2_MPI::Request *colorSendReq = nullptr, *idSendReq = nullptr, *coordSendReq = nullptr;
   SU2_MPI::Request *colorRecvReq = nullptr, *idRecvReq = nullptr, *coordRecvReq = nullptr;
@@ -2587,7 +2586,6 @@ void CPhysicalGeometry::LoadSurfaceElements(CConfig *config, CGeometry *geometry
   vector<vector<unsigned long> > BoundQuad_List;
 
   vector<unsigned long> Marker_Local;
-  vector<unsigned long>::iterator it;
 
   /*--- Compute how many markers we have local to this rank by looping
    through the global marker numbers of each local surface element and

SU2_CFD/include/solvers/CEulerSolver.hpp

@@ -374,6 +374,7 @@ class CEulerSolver : public CFVMFlowSolverBase<CEulerVariable, COMPRESSIBLE> {
    */
   inline virtual void Viscous_Residual(unsigned long iEdge, CGeometry *geometry, CSolver **solver_container,
                                        CNumerics *numerics, CConfig *config) { }
+  using CSolver::Viscous_Residual; /*--- Silence warning ---*/
 
   /*!
    * \brief Recompute the extrapolated quantities, after MUSCL reconstruction,
@@ -459,6 +460,7 @@ class CEulerSolver : public CFVMFlowSolverBase<CEulerVariable, COMPRESSIBLE> {
    */
   void SetPreconditioner(const CConfig *config, unsigned long iPoint,
                          su2double delta, su2double** preconditioner) const;
+  using CSolver::SetPreconditioner; /*--- Silence warning. ---*/
 
   /*!
    * \brief Parallelization of Undivided Laplacian.

SU2_CFD/include/solvers/CTurbSolver.hpp

@@ -99,6 +99,7 @@ class CTurbSolver : public CSolver {
                         CSolver **solver_container,
                         CNumerics *numerics,
                         CConfig *config);
+  using CSolver::Viscous_Residual; /*--- Silence warning ---*/
 
   /*!
    * \brief Sum the edge fluxes for each cell to populate the residual vector, only used on coarse grids.

SU2_CFD/src/CMarkerProfileReaderFVM.cpp

@@ -180,7 +180,6 @@ void CMarkerProfileReaderFVM::MergeProfileMarkers() {
 
   char str_buf[MAX_STRING_SIZE];
   vector<string> Marker_Tags;
-  vector<string>::iterator it;
 
   vector<unsigned long> nRowCum_Counter;
 

SU2_CFD/src/definition_structure.cpp

@@ -83,7 +83,6 @@ void Partition_Analysis(CGeometry *geometry, CConfig *config) {
 
   unsigned long *row_ptr = nullptr, nnz;
   unsigned short *nNeigh = nullptr;
-  vector<unsigned long>::iterator it;
   vector<unsigned long> vneighs;
 
   /*--- Don't delete *row_ptr, *col_ind because they are

SU2_CFD/src/solvers/CDiscAdjSolver.cpp

@@ -796,10 +796,7 @@ void CDiscAdjSolver::SetSurface_Sensitivity(CGeometry *geometry, CConfig *config
 
     /*--- Loop over boundary markers to select those for Euler walls and NS walls ---*/
 
-    if(config->GetMarker_All_KindBC(iMarker) == EULER_WALL
-       || config->GetMarker_All_KindBC(iMarker) == HEAT_FLUX
-       || config->GetMarker_All_KindBC(iMarker) == ISOTHERMAL
-       || config->GetMarker_All_KindBC(iMarker) == CHT_WALL_INTERFACE) {
+    if(config->GetSolid_Wall(iMarker)) {
 
       Sens = 0.0;
 

SU2_CFD/src/solvers/CFEASolver.cpp

@@ -769,10 +769,8 @@ void CFEASolver::Preprocessing(CGeometry *geometry, CSolver **solver_container,
                                unsigned short iMesh, unsigned long Iteration, unsigned short RunTime_EqSystem, bool Output) {
 
   const bool dynamic = config->GetTime_Domain();
-  const bool first_iter = (config->GetInnerIter() == 0);
   const bool disc_adj_fem = (config->GetKind_Solver() == DISC_ADJ_FEM);
   const bool body_forces = config->GetDeadLoad();
-  const bool fsi = config->GetFSI_Simulation();
   const bool topology_mode = config->GetTopology_Optimization();
 
   /*

SU2_CFD/src/solvers/CTurbSolver.cpp

@@ -276,9 +276,9 @@ void CTurbSolver::Viscous_Residual(unsigned long iEdge, CGeometry *geometry, CSo
                             nodes->GetF1blending(jPoint));
 
   /*--- Roughness heights. ---*/
-    if (config->GetKind_Turb_Model() == SA)
-      numerics->SetRoughness(geometry->nodes->GetRoughnessHeight(iPoint),
-                             geometry->nodes->GetRoughnessHeight(jPoint));
+  if (config->GetKind_Turb_Model() == SA)
+    numerics->SetRoughness(geometry->nodes->GetRoughnessHeight(iPoint),
+                           geometry->nodes->GetRoughnessHeight(jPoint));
 
   /*--- Compute residual, and Jacobians ---*/