Fixes from CodeQL

Author: vdweide

Common/src/geometry/meshreader/CCGNSMeshReaderFEM.cpp

@@ -318,7 +318,8 @@ void CCGNSMeshReaderFEM::ReadCGNSSurfaceSection(const int val_section, const vec
 
         case QUADRILATERAL:
           thisFace.nCornerPoints = 4;
-          thisFace.cornerPoints[2] = nPolyGrid * nDOFEdgeGrid;
+          thisFace.cornerPoints[2] = static_cast<unsigned long> (nPolyGrid)
+                                   * nDOFEdgeGrid;
           thisFace.cornerPoints[3] = nDOFsGrid - 1;
           break;
 
@@ -456,7 +457,7 @@ void CCGNSMeshReaderFEM::CommPointCoordinates(void) {
     /*--- Allocate the memory for a buffer to receive this message and also
           for the buffer to return to coordinates. ---*/
     vector<unsigned long> pointRecvBuf(sizeMess);
-    coorReturnBuf[i].resize(dimension * sizeMess);
+    coorReturnBuf[i].resize(static_cast<size_t>(dimension) * sizeMess);
 
     /* Receive the message using a blocking receive. */
     SU2_MPI::Recv(pointRecvBuf.data(), sizeMess, MPI_UNSIGNED_LONG, source, rank, SU2_MPI::GetComm(), &status);

Common/src/geometry/meshreader/CSU2ASCIIMeshReaderBase.cpp

@@ -393,7 +393,7 @@ void CSU2ASCIIMeshReaderBase::ReadSurfaceElementConnectivity(const bool single_p
       if (text_line.find("NMARK=", 0) == string::npos) continue;
     }
 
-    for (unsigned short iMarker = 0; iMarker < numberOfMarkers; ++iMarker) {
+    for (unsigned long iMarker = 0; iMarker < numberOfMarkers; ++iMarker) {
       getline(mesh_file, text_line);
       text_line.erase(0, 11);
       string::size_type position;

Common/src/geometry/meshreader/CSU2ASCIIMeshReaderFEM.cpp

@@ -247,10 +247,9 @@ void CSU2ASCIIMeshReaderFEM::ReadSurfaceElementConnectivity() {
     /*--- Extract the marker name. Remove spaces returns and tabs
           and store the name in markerNames. ---*/
     text_line.erase(0, 11);
-    string::size_type position;
 
     for (unsigned short iChar = 0; iChar < 20; iChar++) {
-      position = text_line.find(" ", 0);
+      auto position = text_line.find(" ", 0);
       if (position != string::npos) text_line.erase(position, 1);
       position = text_line.find("\r", 0);
       if (position != string::npos) text_line.erase(position, 1);
@@ -262,7 +261,7 @@ void CSU2ASCIIMeshReaderFEM::ReadSurfaceElementConnectivity() {
     /*--- Find the section containing the number of surface elements
           for this marker and determine this number. ---*/
     while (getline(mesh_file, text_line)) {
-      string::size_type position = text_line.find("MARKER_ELEMS=", 0);
+      auto position = text_line.find("MARKER_ELEMS=", 0);
       if (position != string::npos) break;
     }
 
@@ -307,7 +306,8 @@ void CSU2ASCIIMeshReaderFEM::ReadSurfaceElementConnectivity() {
         case QUADRILATERAL:
           nDOFsGrid = nDOFEdgeGrid * nDOFEdgeGrid;
           thisFace.nCornerPoints = 4;
-          thisFace.cornerPoints[2] = nPolyGrid * nDOFEdgeGrid;
+          thisFace.cornerPoints[2] = static_cast<unsigned long>(nPolyGrid)
+                                   * nDOFEdgeGrid;
           thisFace.cornerPoints[3] = nDOFsGrid - 1;
           break;