fix mpi race conditions, add the VTK hex to the message

Author: pcarruscag

Common/src/grid_movement/CSurfaceMovement.cpp

@@ -778,7 +778,14 @@ void CSurfaceMovement::SetParametricCoord(CGeometry* geometry, CConfig* config,
     SU2_MPI::Error("The FFD box '" + FFDBox->GetTag() +
                        "' is not properly defined. The first 4 points must be listed counter\n"
                        "clockwise, such that applying the right-hand rule results in a vector into the box.\n"
-                       "This is according to the VTK hexahedron ordering. The CCW convention also applies in 2D.",
+                       "This is according to the VTK hexahedron ordering:\n"
+                       "    7 +----+ 6 \n"
+                       "     /|   /|   \n"
+                       "  4 +----+5|   \n"
+                       "    |3+--|-+ 2 \n"
+                       "    |/   |/    \n"
+                       "  0 +----+ 1   \n"
+                       "The CCW convention also applies in 2D, where only the bottom face is specified.",
                    CURRENT_FUNCTION);
   }
 

TestCases/py_wrapper/custom_heat_flux/run_ad.py

@@ -103,9 +103,12 @@ def RunPrimal(size):
   Returns the final average boundary temperature.
   """
   comm = MPI.COMM_WORLD
+  rank = comm.Get_rank()
 
-  with open('config_unsteady.cfg', 'w') as f:
-    f.write(common_settings.replace('__SIZE__', str(size)) + primal_settings)
+  if rank == 0:
+    with open('config_unsteady.cfg', 'w') as f:
+      f.write(common_settings.replace('__SIZE__', str(size)) + primal_settings)
+  comm.Barrier()
 
   # Initialize the primal driver of SU2, this includes solver preprocessing.
   try:
@@ -154,9 +157,12 @@ def RunAdjoint(size):
   size of the domain and to the initial temperature.
   """
   comm = MPI.COMM_WORLD
+  rank = comm.Get_rank()
 
-  with open('config_unsteady_ad.cfg', 'w') as f:
-    f.write(common_settings.replace('__SIZE__', str(size)) + adjoint_settings)
+  if rank == 0:
+    with open('config_unsteady_ad.cfg', 'w') as f:
+      f.write(common_settings.replace('__SIZE__', str(size)) + adjoint_settings)
+  comm.Barrier()
 
   # Initialize the adjoint driver of SU2, this includes solver preprocessing.
   try:

TestCases/py_wrapper/custom_load_fea/run_ad.py

@@ -117,10 +117,13 @@ def RunPrimal(density, peak_load, height):
   Returns the time average objective function.
   """
   comm = MPI.COMM_WORLD
+  rank = comm.Get_rank()
 
-  with open('config_unsteady.cfg', 'w') as f:
-    f.write(common_settings.replace('__DENSITY__', str(density)).replace('__HEIGHT__', str(height)) +
-            primal_settings)
+  if rank == 0:
+    with open('config_unsteady.cfg', 'w') as f:
+      f.write(common_settings.replace('__DENSITY__', str(density)).replace('__HEIGHT__', str(height)) +
+              primal_settings)
+  comm.Barrier()
 
   # Initialize the primal driver of SU2, this includes solver preprocessing.
   try:
@@ -155,10 +158,13 @@ def RunAdjoint(density, peak_load, height):
   load, to the material density, and to the beam height.
   """
   comm = MPI.COMM_WORLD
+  rank = comm.Get_rank()
 
-  with open('config_unsteady_ad.cfg', 'w') as f:
-    f.write(common_settings.replace('__DENSITY__', str(density)).replace('__HEIGHT__', str(height)) +
-            adjoint_settings)
+  if rank == 0:
+    with open('config_unsteady_ad.cfg', 'w') as f:
+      f.write(common_settings.replace('__DENSITY__', str(density)).replace('__HEIGHT__', str(height)) +
+              adjoint_settings)
+  comm.Barrier()
 
   # Initialize the adjoint driver of SU2, this includes solver preprocessing.
   try: