fix the "velocity to zero" part for NEMO

Author: pcarruscag

SU2_CFD/include/variables/CEulerVariable.hpp

@@ -428,6 +428,14 @@ class CEulerVariable : public CVariable {
       Solution_Old(iPoint,iDim+1) = val_velocity[iDim]*Solution(iPoint,0);
   }
 
+  /*!
+   * \brief Set the momentum part of the truncation error to zero.
+   * \param[in] iPoint - Point index.
+   */
+  inline void SetVel_ResTruncError_Zero(unsigned long iPoint) final {
+    for (unsigned long iDim = 0; iDim < nDim; iDim++) Res_TruncError(iPoint,iDim+1) = 0.0;
+  }
+
   /*!
    * \brief Set the harmonic balance source term.
    * \param[in] iVar - Index of the variable.

SU2_CFD/include/variables/CIncEulerVariable.hpp

@@ -326,6 +326,14 @@ class CIncEulerVariable : public CVariable {
       Solution_Old(iPoint,iDim+1) = val_velocity[iDim];
   }
 
+  /*!
+   * \brief Set the momentum part of the truncation error to zero.
+   * \param[in] iPoint - Point index.
+   */
+  inline void SetVel_ResTruncError_Zero(unsigned long iPoint) final {
+    for (unsigned long iDim = 0; iDim < nDim; iDim++) Res_TruncError(iPoint,iDim+1) = 0.0;
+  }
+
   /*!
    * \brief Set all the primitive variables for incompressible flows.
    */

SU2_CFD/include/variables/CNEMOEulerVariable.hpp

@@ -582,8 +582,16 @@ class CNEMOEulerVariable : public CVariable {
    * \param[in] val_vector - Pointer to the vector.
    */
   inline void SetVelSolutionVector(unsigned long iPoint, const su2double *val_vector) final {
-    SU2_MPI::Error("Please add the correct <Density> for `multigrid` + `moving grid` and Solution-Position for momentum below!", CURRENT_FUNCTION);
-    for (unsigned long iDim = 0; iDim < nDim; iDim++) Solution(iPoint, nSpecies+iDim) = GetDensity(iPoint) * val_vector[iDim];
+    for (unsigned long iDim = 0; iDim < nDim; iDim++)
+      Solution(iPoint, nSpecies+iDim) = Primitive(iPoint,RHO_INDEX) * val_vector[iDim];
+  }
+
+  /*!
+   * \brief Set the momentum part of the truncation error to zero.
+   * \param[in] iPoint - Point index.
+   */
+  inline void SetVel_ResTruncError_Zero(unsigned long iPoint) final {
+    for (unsigned long iDim = 0; iDim < nDim; iDim++) Res_TruncError(iPoint,nSpecies+iDim) = 0.0;
   }
 
 };

SU2_CFD/include/variables/CVariable.hpp

@@ -287,14 +287,6 @@ class CVariable {
     Solution_time_n1(iPoint,iVar) = val_sol;
   }
 
-  /*!
-   * \brief Set to zero the velocity components of the solution.
-   * \param[in] iPoint - Point index.
-   */
-  inline void SetVelSolutionZero(unsigned long iPoint) {
-    for (unsigned long iDim = 0; iDim < nDim; iDim++) Solution(iPoint,iDim+1) = 0.0;
-  }
-
   /*!
    * \brief Virtual Member. Specify a vector to set the velocity components of the solution.
    *        Multiplied by density for compressible cases.
@@ -303,14 +295,6 @@ class CVariable {
    */
   inline virtual void SetVelSolutionVector(unsigned long iPoint, const su2double *val_vector) { }
 
-  /*!
-   * \brief Set to zero velocity components of the solution.
-   * \param[in] iPoint - Point index.
-   */
-  inline void SetVelSolutionOldZero(unsigned long iPoint) {
-    for (unsigned long iDim = 0; iDim < nDim; iDim++) Solution_Old(iPoint, iDim+1) = 0.0;
-  }
-
   /*!
    * \brief Add a value to the solution.
    * \param[in] iPoint - Point index.
@@ -510,12 +494,6 @@ class CVariable {
     for (unsigned long iVar = 0; iVar < nVar; iVar++) Residual_Sum(iPoint,iVar) = 0.0;
   }
 
-  /*!
-   * \brief Set the velocity of the truncation error to zero.
-   * \param[in] iPoint - Point index.
-   */
-  inline virtual void SetVel_ResTruncError_Zero(unsigned long iPoint, unsigned long iSpecies) {}
-
   /*!
    * \brief Get the value of the summed residual.
    * \param[in] iPoint - Point index.
@@ -661,12 +639,10 @@ class CVariable {
   inline void SetVal_ResTruncError_Zero(unsigned long iPoint, unsigned long iVar) {Res_TruncError(iPoint, iVar) = 0.0;}
 
   /*!
-   * \brief Set the velocity of the truncation error to zero.
+   * \brief Set the momentum part of the truncation error to zero.
    * \param[in] iPoint - Point index.
    */
-  inline void SetVel_ResTruncError_Zero(unsigned long iPoint) {
-    for (unsigned long iDim = 0; iDim < nDim; iDim++) Res_TruncError(iPoint,iDim+1) = 0.0;
-  }
+  inline virtual void SetVel_ResTruncError_Zero(unsigned long iPoint) { }
 
   /*!
    * \brief Set the velocity of the truncation error to zero.

SU2_CFD/src/integration/CMultiGridIntegration.cpp

@@ -350,7 +350,8 @@ void CMultiGridIntegration::GetProlongated_Correction(unsigned short RunTime_EqS
         /*--- For dirichlet boundary condtions, set the correction to zero.
          Note that Solution_Old stores the correction not the actual value ---*/
 
-        sol_coarse->GetNodes()->SetVelSolutionOldZero(Point_Coarse);
+        su2double zero[3] = {0.0};
+        sol_coarse->GetNodes()->SetVelocity_Old(Point_Coarse, zero);
 
       }
     }
@@ -542,13 +543,12 @@ void CMultiGridIntegration::SetRestricted_Solution(unsigned short RunTime_EqSyst
                                                    CGeometry *geo_fine, CGeometry *geo_coarse, CConfig *config) {
 
   unsigned long iVertex, Point_Fine, Point_Coarse;
-  unsigned short iMarker, iVar, iChildren, iDim;
+  unsigned short iMarker, iVar, iChildren;
   su2double Area_Parent, Area_Children;
   const su2double *Solution_Fine = nullptr, *Grid_Vel = nullptr;
 
   const unsigned short Solver_Position = config->GetContainerPosition(RunTime_EqSystem);
   const unsigned short nVar = sol_coarse->GetnVar();
-  const unsigned short nDim = geo_fine->GetnDim();
   const bool grid_movement = config->GetGrid_Movement();
 
   su2double *Solution = new su2double[nVar];
@@ -598,8 +598,8 @@ void CMultiGridIntegration::SetRestricted_Solution(unsigned short RunTime_EqSyst
           }
           else {
             /*--- For stationary no-slip walls, set the velocity to zero. ---*/
-
-            sol_coarse->GetNodes()->SetVelSolutionZero(Point_Coarse);
+            su2double zero[3] = {0.0};
+            sol_coarse->GetNodes()->SetVelSolutionVector(Point_Coarse, zero);
           }
 
         }