Apply suggestions from Code Review

ArneVoss · ArneVoss · commit 605839acb6d9 · 2023-05-25T08:56:30.000+02:00
diff --git a/SU2_CFD/src/iteration/CFluidIteration.cpp b/SU2_CFD/src/iteration/CFluidIteration.cpp
@@ -329,23 +329,17 @@ void CFluidIteration::SetWind_GustField(CConfig* config, CGeometry** geometry, C
 
   su2double Uinf = solver[MESH_0][FLOW_SOL]->GetVelocity_Inf(0);  // Assumption gust moves at infinity velocity
 
-  Gust = new su2double[nDim];
-  NewGridVel = new su2double[nDim];
-  for (iDim = 0; iDim < nDim; iDim++) {
-    Gust[iDim] = 0.0;
-    NewGridVel[iDim] = 0.0;
-  }
+  Gust       = new su2double[nDim]();
+  NewGridVel = new su2double[nDim]();
+  GustDer    = new su2double[nDim+1]();
 
   // Print some information to check that we are doing the right thing. Not sure how to convert the index back to a string...
-  if (rank == MASTER_NODE) cout << endl << "Setting up a wind gust type " << Gust_Type << " with amplitude of " << gust_amp << " in direction " << GustDir << endl;
-  if (rank == MASTER_NODE) cout << " U_inf      = " << Uinf << endl;
-  if (rank == MASTER_NODE) cout << " Physical_t = " << Physical_t << endl;
-  su2double loc_x = (xbegin + L + Uinf * (Physical_t - tbegin));
-  if (rank == MASTER_NODE) cout << " Location_x = " << loc_x << endl;
-
-  GustDer = new su2double[nDim+1];
-  for (unsigned short i = 0; i < nDim+1; i++) {
-    GustDer[i] = 0.0;
+  if (rank == MASTER_NODE) {
+	  cout << endl << "Setting up a wind gust type " << Gust_Type << " with amplitude of " << gust_amp << " in direction " << GustDir << endl;
+	  cout << " U_inf      = " << Uinf << endl;
+	  cout << " Physical_t = " << Physical_t << endl;
+	  su2double loc_x = (xbegin + L + Uinf * (Physical_t - tbegin));
+	  cout << " Location_x = " << loc_x << endl;
   }
 
   // Vortex variables
diff --git a/SU2_CFD/src/numerics/flow/flow_sources.cpp b/SU2_CFD/src/numerics/flow/flow_sources.cpp
@@ -790,7 +790,7 @@ CNumerics::ResidualType<> CSourceWindGust::ComputeResidual(const CConfig* config
     residual[2] = 0.0;
     residual[3] = 0.0;
     residual[4] = 0.0;
-    }
+  }
 
   /*--- For now the source term Jacobian is just set to zero ---*/
   //bool implicit = (config->GetKind_TimeIntScheme_Flow() == EULER_IMPLICIT);
diff --git a/TestCases/gust/cosine_gust_zdir.cfg b/TestCases/gust/cosine_gust_zdir.cfg
@@ -1,30 +1,26 @@
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
+%                                                                              %
+% SU2 configuration file                                                       %
+% Case description: Cosine gust in z-direction of a 3D mesh                    %
+% Author: Arne Voß                                                             %
+% Institution: DLR                                                             %
+% Date: 25.05.2023                                                             %
+% File Version 7.5.1 "Blackbird"                                               %
+%                                                                              %
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
+
 % ------------- DIRECT, ADJOINT, AND LINEARIZED PROBLEM DEFINITION ------------%
 %
-% Solver type (EULER, NAVIER_STOKES, RANS,
-%              INC_EULER, INC_NAVIER_STOKES, INC_RANS,
-%              NEMO_EULER, NEMO_NAVIER_STOKES,
-%              FEM_EULER, FEM_NAVIER_STOKES, FEM_RANS, FEM_LES,
-%              HEAT_EQUATION_FVM, ELASTICITY)
 SOLVER= EULER
-%
-% Mathematical problem (DIRECT, CONTINUOUS_ADJOINT)
 MATH_PROBLEM= DIRECT
 %
-% Restart solution (NO, YES)
 RESTART_SOL= YES
-%
-% Iteration number to begin unsteady restarts
 RESTART_ITER= 72
 %
 % ------------------------------- SOLVER CONTROL ------------------------------%
 %
-% Maximum number of inner iterations
 INNER_ITER= 30
-%
-% Min value of the residual (log10 of the residual)
 CONV_RESIDUAL_MINVAL= -6
-%
-% Start convergence criteria at iteration number
 CONV_STARTITER= 0
 %
 % ------------------------- UNSTEADY SIMULATION -------------------------------%
@@ -49,124 +45,67 @@ GUST_PERIODS= 1.0
 GUST_AMPL= 2.37
 %
 GUST_BEGIN_TIME= 0.0
+% Gust is placed 5m ahead of the wing
 GUST_BEGIN_LOC=-10.0
 % -------------------- COMPRESSIBLE FREE-STREAM DEFINITION --------------------%
 %
-% Mach number (non-dimensional, based on the free-stream values)
 MACH_NUMBER= 0.2
-%
-% Angle of attack (degrees, only for compressible flows)
 AOA= 0.0
-%
-% Side-slip angle (degrees, only for compressible flows)
 SIDESLIP_ANGLE= 0.0
-%
-% Free-stream option to choose between density and temperature (default) for
-% initializing the solution (TEMPERATURE_FS, DENSITY_FS)
 FREESTREAM_OPTION= DENSITY_FS
-%
-% Free-stream pressure (101325.0 N/m^2, 2116.216 psf by default)
 FREESTREAM_PRESSURE= 101325.0
-%
-% Free-stream density (1.2886 Kg/m^3, 0.0025 slug/ft^3 by default)
 FREESTREAM_DENSITY= 1.225
-%
-% Free-stream temperature (288.15 K, 518.67 R by default)
 FREESTREAM_TEMPERATURE= 288.15
 %
 % ---------------------- REFERENCE VALUE DEFINITION ---------------------------%
 %
-% Reference origin for moment computation (m or in)
 REF_ORIGIN_MOMENT_X = 0.25
 REF_ORIGIN_MOMENT_Y = 0.00
 REF_ORIGIN_MOMENT_Z = 0.00
-%
-% Reference length for moment non-dimensional coefficients (m or in)
 REF_LENGTH= 1.0
-%
-% Reference area for non-dimensional force coefficients (0 implies automatic
-% calculation) (m^2 or in^2)
 REF_AREA= 3.0
-%
-% Aircraft semi-span (0 implies automatic calculation) (m or in)
 SEMI_SPAN= 1.5
-%
-% Flow non-dimensionalization (DIMENSIONAL, FREESTREAM_PRESS_EQ_ONE,
-%                              FREESTREAM_VEL_EQ_MACH, FREESTREAM_VEL_EQ_ONE)
 REF_DIMENSIONALIZATION= DIMENSIONAL
 
 % -------------------- BOUNDARY CONDITION DEFINITION --------------------------%
 %
-% Euler wall boundary marker(s) (NONE = no marker)
-% Implementation identical to MARKER_SYM.
 MARKER_EULER= ( wing, tip)
-%
-% Far-field boundary marker(s) (NONE = no marker)
 MARKER_FAR= ( far_away )
 
 % ------------------------ SURFACES IDENTIFICATION ----------------------------%
 %
-% Marker(s) of the surface in the surface flow solution file
 MARKER_PLOTTING = ( wing, tip )
-%
-% Marker(s) of the surface where the non-dimensional coefficients are evaluated.
 MARKER_MONITORING = ( wing, tip )
 
 % ------------- COMMON PARAMETERS DEFINING THE NUMERICAL METHOD ---------------%
 %
-% CFL number (initial value for the adaptive CFL number)
 CFL_NUMBER= 1000.0
-%
-% Adaptive CFL number (NO, YES)
 CFL_ADAPT= YES
 %
 % -------------------------- MULTIGRID PARAMETERS -----------------------------%
 %
-% Multi-grid levels (0 = no multi-grid)
 MGLEVEL= 3
-%
-% Multi-grid cycle (V_CYCLE, W_CYCLE, FULLMG_CYCLE)
 MGCYCLE= W_CYCLE
 
 % -------------------- FLOW NUMERICAL METHOD DEFINITION -----------------------%
 %
-% Convective numerical method (JST, JST_KE, JST_MAT, LAX-FRIEDRICH, CUSP, ROE, AUSM,
-%                              AUSMPLUSUP, AUSMPLUSUP2, AUSMPWPLUS, HLLC, TURKEL_PREC,
-%                              SW, MSW, FDS, SLAU, SLAU2, L2ROE, LMROE)
 CONV_NUM_METHOD_FLOW= JST
-%
-% Max number of iterations of the linear solver for the implicit formulation
 LINEAR_SOLVER_ITER= 20
 %
 % ------------------------- SCREEN/HISTORY VOLUME OUTPUT --------------------------%
 %
-% Screen output fields (use 'SU2_CFD -d <config_file>' to view list of available fields)
 SCREEN_OUTPUT= (TIME_ITER, INNER_ITER, RMS_DENSITY, LIFT, MOMENT_X, MOMENT_Y, MOMENT_Z)
-%
-% History output groups (use 'SU2_CFD -d <config_file>' to view list of available fields)
 HISTORY_OUTPUT= (ITER, RMS_RES, AERO_COEFF, CAUCHY, WALL_TIME)
 %
 % ------------------------- INPUT/OUTPUT FILE INFORMATION --------------------------%
 %
-% Mesh input file
 MESH_FILENAME= mesh_rectangular_wing.su2
-%
-% Mesh input file format (SU2, CGNS)
 MESH_FORMAT= SU2
-%
-% Restart flow input file
 SOLUTION_FILENAME= restart_gust.dat
 RESTART_FILENAME= restart_gust.dat
 SURFACE_FILENAME= surface_gust
 VOLUME_FILENAME= volume_gust
 CONV_FILENAME= history_gust
-%
-% Output tabular file format (TECPLOT, CSV)
 TABULAR_FORMAT= CSV
-%
-% Files to output
-% Possible formats : (TECPLOT, TECPLOT_BINARY, SURFACE_TECPLOT,
-%  SURFACE_TECPLOT_BINARY, CSV, SURFACE_CSV, PARAVIEW, PARAVIEW_BINARY, SURFACE_PARAVIEW,
-%  SURFACE_PARAVIEW_BINARY, MESH, RESTART_BINARY, RESTART_ASCII, CGNS, SURFACE_CGNS, STL)
 OUTPUT_FILES= (RESTART, RESTART_ASCII)
-
+%
diff --git a/TestCases/gust/gust_with_mesh_deformation.cfg b/TestCases/gust/gust_with_mesh_deformation.cfg
@@ -1,24 +1,22 @@
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
+%                                                                              %
+% SU2 configuration file                                                       %
+% Case description: Cosine gust combined with mesh deformation                 %
+% Author: Arne Voß                                                             %
+% Institution: DLR                                                             %
+% Date: 25.05.2023                                                             %
+% File Version 7.5.1 "Blackbird"                                               %
+%                                                                              %
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
+
 % ------------- DIRECT, ADJOINT, AND LINEARIZED PROBLEM DEFINITION ------------%
 %
-% Solver type (EULER, NAVIER_STOKES, RANS,
-%              INC_EULER, INC_NAVIER_STOKES, INC_RANS,
-%              NEMO_EULER, NEMO_NAVIER_STOKES,
-%              FEM_EULER, FEM_NAVIER_STOKES, FEM_RANS, FEM_LES,
-%              HEAT_EQUATION_FVM, ELASTICITY)
 SOLVER= EULER
-%
-% Mathematical problem (DIRECT, CONTINUOUS_ADJOINT)
 MATH_PROBLEM= DIRECT
-%
 % ------------------------------- SOLVER CONTROL ------------------------------%
 %
-% Maximum number of inner iterations
 INNER_ITER= 100
-%
-% Min value of the residual (log10 of the residual)
 CONV_RESIDUAL_MINVAL= -6
-%
-% Start convergence criteria at iteration number
 CONV_STARTITER= 0
 %
 % ------------------------- UNSTEADY SIMULATION -------------------------------%
@@ -39,11 +37,10 @@ GUST_TYPE= ONE_M_COSINE
 GUST_DIR= Y_DIR
 GUST_WAVELENGTH= 5.0
 GUST_PERIODS= 1.0
-% Gust amplitude corresponds to ~2.0 deg AoA
 GUST_AMPL= 1.0
-%
 GUST_BEGIN_TIME= 0.0
 GUST_BEGIN_LOC=-5.0
+%
 % --------------------------- MESH DEFORMATION--------------------------------%
 % Type of dynamic surface movement (NONE, DEFORMING, MOVING_WALL,
 % AEROELASTIC, AEROELASTIC_RIGID_MOTION EXTERNAL, EXTERNAL_ROTATION)
@@ -60,123 +57,66 @@ SURFACE_PLUNGING_AMPL= 0.0 0.0001 0.0
 %
 % Move Motion Origin for marker moving (1 or 0)
 MOVE_MOTION_ORIGIN = 0
+%
 % -------------------- COMPRESSIBLE FREE-STREAM DEFINITION --------------------%
 %
-% Mach number (non-dimensional, based on the free-stream values)
 MACH_NUMBER= 0.2
-%
-% Angle of attack (degrees, only for compressible flows)
 AOA= 0.0
-%
-% Side-slip angle (degrees, only for compressible flows)
 SIDESLIP_ANGLE= 0.0
-%
-% Free-stream option to choose between density and temperature (default) for
-% initializing the solution (TEMPERATURE_FS, DENSITY_FS)
 FREESTREAM_OPTION= DENSITY_FS
-%
-% Free-stream pressure (101325.0 N/m^2, 2116.216 psf by default)
 FREESTREAM_PRESSURE= 101325.0
-%
-% Free-stream density (1.2886 Kg/m^3, 0.0025 slug/ft^3 by default)
 FREESTREAM_DENSITY= 1.225
-%
-% Free-stream temperature (288.15 K, 518.67 R by default)
 FREESTREAM_TEMPERATURE= 288.15
 %
 % ---------------------- REFERENCE VALUE DEFINITION ---------------------------%
 %
-% Reference origin for moment computation (m or in)
 REF_ORIGIN_MOMENT_X = 0.25
 REF_ORIGIN_MOMENT_Y = 0.00
 REF_ORIGIN_MOMENT_Z = 0.00
-%
-% Reference length for moment non-dimensional coefficients (m or in)
 REF_LENGTH= 1.0
-%
-% Reference area for non-dimensional force coefficients (0 implies automatic
-% calculation) (m^2 or in^2)
 REF_AREA= 1.0
-%
-% Aircraft semi-span (0 implies automatic calculation) (m or in)
 SEMI_SPAN= 1.0
-%
-% Flow non-dimensionalization (DIMENSIONAL, FREESTREAM_PRESS_EQ_ONE,
-%                              FREESTREAM_VEL_EQ_MACH, FREESTREAM_VEL_EQ_ONE)
 REF_DIMENSIONALIZATION= DIMENSIONAL
-
+%
 % -------------------- BOUNDARY CONDITION DEFINITION --------------------------%
 %
-% Euler wall boundary marker(s) (NONE = no marker)
-% Implementation identical to MARKER_SYM.
 MARKER_EULER= ( airfoil )
-%
-% Far-field boundary marker(s) (NONE = no marker)
 MARKER_FAR= ( farfield )
-
+%
 % ------------------------ SURFACES IDENTIFICATION ----------------------------%
 %
-% Marker(s) of the surface in the surface flow solution file
 MARKER_PLOTTING = ( airfoil )
-%
-% Marker(s) of the surface where the non-dimensional coefficients are evaluated.
 MARKER_MONITORING = ( airfoil )
-
+%
 % ------------- COMMON PARAMETERS DEFINING THE NUMERICAL METHOD ---------------%
 %
-% CFL number (initial value for the adaptive CFL number)
 CFL_NUMBER= 100.0
-%
-% Adaptive CFL number (NO, YES)
 CFL_ADAPT= YES
 %
 % -------------------------- MULTIGRID PARAMETERS -----------------------------%
 %
-% Multi-grid levels (0 = no multi-grid)
 MGLEVEL= 3
-%
-% Multi-grid cycle (V_CYCLE, W_CYCLE, FULLMG_CYCLE)
 MGCYCLE= W_CYCLE
-
+%
 % -------------------- FLOW NUMERICAL METHOD DEFINITION -----------------------%
 %
-% Convective numerical method (JST, JST_KE, JST_MAT, LAX-FRIEDRICH, CUSP, ROE, AUSM,
-%                              AUSMPLUSUP, AUSMPLUSUP2, AUSMPWPLUS, HLLC, TURKEL_PREC,
-%                              SW, MSW, FDS, SLAU, SLAU2, L2ROE, LMROE)
 CONV_NUM_METHOD_FLOW= JST
-%
-% Max number of iterations of the linear solver for the implicit formulation
 LINEAR_SOLVER_ITER= 20
 %
 % ------------------------- SCREEN/HISTORY VOLUME OUTPUT --------------------------%
 %
-% Screen output fields (use 'SU2_CFD -d <config_file>' to view list of available fields)
 SCREEN_OUTPUT= (TIME_ITER, INNER_ITER, RMS_DENSITY, LIFT, MOMENT_Z)
-%
-% History output groups (use 'SU2_CFD -d <config_file>' to view list of available fields)
 HISTORY_OUTPUT= (ITER, RMS_RES, AERO_COEFF, CAUCHY, WALL_TIME)
 %
 % ------------------------- INPUT/OUTPUT FILE INFORMATION --------------------------%
 %
-% Mesh input file
 MESH_FILENAME= mesh_NACA0012_inv.su2
-%
-% Mesh input file format (SU2, CGNS)
 MESH_FORMAT= SU2
-%
-% Restart flow input file
 SOLUTION_FILENAME= restart_gust.dat
 RESTART_FILENAME= restart_gust.dat
 SURFACE_FILENAME= surface_gust
 VOLUME_FILENAME= volume_gust
 CONV_FILENAME= history_gust
-%
-% Output tabular file format (TECPLOT, CSV)
 TABULAR_FORMAT= CSV
-%
-% Files to output
-% Possible formats : (TECPLOT, TECPLOT_BINARY, SURFACE_TECPLOT,
-%  SURFACE_TECPLOT_BINARY, CSV, SURFACE_CSV, PARAVIEW, PARAVIEW_BINARY, SURFACE_PARAVIEW,
-%  SURFACE_PARAVIEW_BINARY, MESH, RESTART_BINARY, RESTART_ASCII, CGNS, SURFACE_CGNS, STL)
 OUTPUT_FILES= (NONE)
-
+%
