Cleanup

Author: TobiKattmann

Common/include/CConfig.hpp

@@ -817,7 +817,6 @@ class CConfig {
   Mu_SND;                /*!< \brief Non-dimensional reference S for Sutherland model.  */
   su2double Diffusivity_Constant;   /*!< \brief Constant mass diffusivity for scalar transport.  */
   su2double Diffusivity_ConstantND; /*!< \brief Non-dim. constant mass diffusivity for scalar transport.  */
-  su2double Diffusivity_Ref;        /*!< \brief Reference mass diffusion for species equations.  */
   su2double Schmidt_Number_Laminar;   /*!< \brief Laminar Schmidt number for mass diffusion.  */
   su2double Schmidt_Number_Turbulent; /*!< \brief Turbulent Schmidt number for mass diffusion.  */
   array<su2double, N_POLY_COEFFS> CpPolyCoefficientsND{{0.0}};  /*!< \brief Definition of the non-dimensional temperature polynomial coefficients for specific heat Cp. */
@@ -2043,13 +2042,11 @@ class CConfig {
    */
   su2double GetInc_Temperature_Init(void) const { return Inc_Temperature_Init; }
 
-  unsigned short GetNSpeciesInit() const { return nSpecies_Init; }
-
   /*!
    * \brief Get the flag for activating species transport clipping.
    * \return Flag for species clipping.
    */
-  bool GetSpecies_Clipping() { return Species_Clipping; }
+  bool GetSpecies_Clipping() const { return Species_Clipping; }
 
   /*!
    * \brief Get the maximum bound for scalar transport clipping
@@ -3977,11 +3974,6 @@ class CConfig {
    */
   void SetDiffusivity_ConstantND(su2double diffusivity_const) { Diffusivity_ConstantND = diffusivity_const; }
 
-  /*!
-   * \brief Set the value of the reference mass diffusivity.
-   */
-  void SetDiffusivity_Ref(su2double diffusivity_ref);
-
   /*!
    * \brief Get the kind of method for computation of spatial gradients used for viscous and source terms.
    * \return Numerical method for computation of spatial gradients used for viscous and source terms.
@@ -6590,7 +6582,6 @@ class CConfig {
    * \param[in] val_index - Index corresponding to the inlet boundary.
    * \return The inlet species values.
    */
-  // nijso: TODO we do not need inlet enthalpy, it is computed from temperature!
   const su2double* GetInlet_SpeciesVal(string val_index) const;
 
   /*!

Common/src/CConfig.cpp

@@ -5169,6 +5169,11 @@ void CConfig::SetPostprocessing(SU2_COMPONENT val_software, unsigned short val_i
       if (!(OptionIsSet("SPECIES_CLIPPING_MIN") && OptionIsSet("SPECIES_CLIPPING_MAX")))
         SU2_MPI::Error("SPECIES_CLIPPING= YES requires the options SPECIES_CLIPPING_MIN/MAX to set the clipping values.", CURRENT_FUNCTION);
 
+    /*--- Make sure a Diffusivity has been set for Constant Diffusivity. ---*/
+    if (Kind_Diffusivity_Model == DIFFUSIVITYMODEL::CONSTANT_DIFFUSIVITY &&
+        !(OptionIsSet("DIFFUSIVITY_CONSTANT")))
+      SU2_MPI::Error("A DIFFUSIVITY_CONSTANT=<value> has to be set with DIFFUSIVITY_MODEL= CONSTANT_DIFFUSIVITY.", CURRENT_FUNCTION);
+
     // Helper function that checks scalar variable bounds,
     auto checkScalarBounds = [&](su2double scalar, string name, su2double lowerBound, su2double upperBound) {
       if (scalar < lowerBound || scalar > upperBound)

SU2_CFD/include/numerics/species/species_convection.hpp

@@ -32,7 +32,7 @@
 
 /*!
  * \class CUpwSca_Species
- * \brief Class for doing a scalar upwind solver for the Spalar-Allmaras turbulence model equations.
+ * \brief Class for doing a scalar upwind solver for the species transport equations.
  * \ingroup ConvDiscr
  */
 template <class FlowIndices>
@@ -51,6 +51,7 @@ class CUpwSca_Species final : public CUpwScalar<FlowIndices> {
   using Base::ScalarVar_i;
   using Base::ScalarVar_j;
   using Base::idx;
+
   /*!
    * \brief Adds any extra variables to AD
    */
@@ -60,7 +61,7 @@ class CUpwSca_Species final : public CUpwScalar<FlowIndices> {
   };
 
   /*!
-   * \brief SA specific steps in the ComputeResidual method
+   * \brief Species transport specific steps in the ComputeResidual method
    * \param[in] config - Definition of the particular problem.
    */
   void FinishResidualCalc(const CConfig* config) override {

SU2_CFD/include/numerics/species/species_diffusion.hpp

@@ -32,7 +32,7 @@
 
 /*!
  * \class CAvgGrad_Species
- * \brief Class for computing viscous term using average of gradients (Spalart-Allmaras Turbulence model).
+ * \brief Class for computing viscous term using average of gradients (species transport model).
  * \ingroup ViscDiscr
  */
 template <class FlowIndices>

SU2_CFD/include/solvers/CSpeciesSolver.hpp

@@ -33,9 +33,8 @@
 
 /*!
  * \class CSpeciesSolver
- * \brief Main class for defining the turbulence model solver.
- * \ingroup Turbulence_Model
- * \author A. Bueno.
+ * \brief Main class for defining the species transport solver.
+ * \author T. Kattmann.
  */
 class CSpeciesSolver : public CScalarSolver<CSpeciesVariable> {
  protected:

SU2_CFD/include/variables/CSpeciesVariable.hpp

@@ -31,7 +31,7 @@
 
 /*!
  * \class CSpeciesVariable
- * \brief Base class for defining the variables of the turbulence model.
+ * \brief Base class for defining the variables of the species transport.
  */
 class CSpeciesVariable : public CScalarVariable {
  protected: