Merge pull request #1989 from su2code/feature_clang-tidy

Add clang-tidy checks and apply them

Author: pcarruscag

.clang-tidy

@@ -0,0 +1,5 @@
+Checks: '-*,modernize-avoid-bind,modernize-deprecated-headers,modernize-deprecated-ios-base-aliases,modernize-macro-to-enum,modernize-pass-by-value,modernize-raw-string-literal,modernize-redundant-void-arg,modernize-replace-auto-ptr,modernize-replace-disallow-copy-and-assign-macro,modernize-replace-random-shuffle,modernize-return-braced-init-list,modernize-shrink-to-fit,modernize-unary-static-assert,modernize-use-auto,modernize-use-bool-literals,modernize-use-default-member-init,modernize-use-emplace,modernize-use-equals-default,modernize-use-equals-delete,modernize-use-noexcept,modernize-use-nullptr,modernize-use-override,modernize-use-transparent-functors,modernize-use-using,readability-const-return-type,readability-avoid-const-params-in-decls,readability-container-data-pointer,readability-container-size-empty,readability-delete-null-pointer,readability-duplicate-include,readability-non-const-parameter,readability-redundant-access-specifiers,readability-redundant-control-flow,readability-redundant-declaration,readability-redundant-function-ptr-dereference,readability-redundant-smartptr-get,readability-redundant-string-cstr,readability-redundant-string-init,readability-simplify-boolean-expr,readability-simplify-subscript-expr,readability-else-after-return,performance-*'
+CheckOptions:
+  - {key: modernize-use-override.AllowOverrideAndFinal, value: 'true'}
+  - {key: performance-unnecessary-copy-initialization.AllowedTypes, value: 'su2double'}
+  - {key: performance-unnecessary-value-param.AllowedTypes, value: 'su2double'}

Common/include/CConfig.hpp

@@ -271,7 +271,7 @@ class CLookUpTable {
                                                               const su2double val_CV3);
 
  public:
-  CLookUpTable(const std::string& file_name_lut, const std::string& name_CV1_in, const std::string& name_CV2_in);
+  CLookUpTable(const std::string& file_name_lut, std::string name_CV1_in, std::string name_CV2_in);
 
   /*!
    * \brief print information to screen.

Common/include/containers/CLookUpTable.hpp

@@ -45,9 +45,9 @@ extern "C" {
 #include <sstream>
 #include <cmath>
 #include <algorithm>
-#include <string.h>
-#include <stdio.h>
-#include <stdlib.h>
+#include <cstring>
+#include <cstdio>
+#include <cstdlib>
 #include <climits>
 #include <memory>
 #include <unordered_map>

Common/include/geometry/CGeometry.hpp

@@ -282,7 +282,8 @@ class CPhysicalGeometry final : public CGeometry {
    * \param[in] val_iZone - Domain to be read from the grid file.
    * \param[in] val_nZone - Total number of domains in the grid file.
    */
-  void Read_Mesh_FVM(CConfig* config, string val_mesh_filename, unsigned short val_iZone, unsigned short val_nZone);
+  void Read_Mesh_FVM(CConfig* config, const string& val_mesh_filename, unsigned short val_iZone,
+                     unsigned short val_nZone);
 
   /*!
    * \brief Reads for the FEM solver the geometry of the grid and adjust the boundary
@@ -292,7 +293,7 @@ class CPhysicalGeometry final : public CGeometry {
    * \param[in] val_iZone - Domain to be read from the grid file.
    * \param[in] val_nZone - Total number of domains in the grid file.
    */
-  void Read_SU2_Format_Parallel_FEM(CConfig* config, string val_mesh_filename, unsigned short val_iZone,
+  void Read_SU2_Format_Parallel_FEM(CConfig* config, const string& val_mesh_filename, unsigned short val_iZone,
                                     unsigned short val_nZone);
 
   /*!
@@ -303,7 +304,7 @@ class CPhysicalGeometry final : public CGeometry {
    * \param[in] val_iZone - Domain to be read from the grid file.
    * \param[in] val_nZone - Total number of domains in the grid file.
    */
-  void Read_CGNS_Format_Parallel_FEM(CConfig* config, string val_mesh_filename, unsigned short val_iZone,
+  void Read_CGNS_Format_Parallel_FEM(CConfig* config, const string& val_mesh_filename, unsigned short val_iZone,
                                      unsigned short val_nZone);
 
   /*!

Common/include/geometry/CPhysicalGeometry.hpp

@@ -63,7 +63,7 @@ class CCGNSMeshReaderFVM : public CMeshReaderFVM {
    * \brief Open the CGNS file and checks for errors.
    * \param[in] val_filename - string name of the CGNS file to be read.
    */
-  void OpenCGNSFile(string val_filename);
+  void OpenCGNSFile(const string& val_filename);
 
   /*!
    * \brief Reads all CGNS database metadata and checks for errors.

Common/include/geometry/meshreader/CCGNSMeshReaderFVM.hpp

@@ -710,7 +710,7 @@ class CFreeFormDefBox : public CGridMovement {
    *        which? diff_thiss will tell us ; E.G.: dim=2, diff_this=1 => we use the third coordinate of the control
    *        points, and derivate de v-Bersntein polynomial (use m-1 when summing!!).
    */
-  su2double GetDerivative3(su2double* uvw, unsigned short dim, unsigned short diff_this, unsigned short* lmn);
+  su2double GetDerivative3(su2double* uvw, unsigned short dim, unsigned short diff_this, unsigned short* lmn) const;
 
   /*!
    * \brief An auxiliary routine to help us compute the Hessian of F(u, v, w) = ||X(u, v, w)-(x, y, z)||^2 =
@@ -742,7 +742,7 @@ class CFreeFormDefBox : public CGridMovement {
    * \return __________.
    */
   su2double GetDerivative5(su2double* uvw, unsigned short dim, unsigned short diff_this, unsigned short diff_this_also,
-                           unsigned short* lmn);
+                           unsigned short* lmn) const;
 
   /*!
    * \brief Euclidean norm of a vector.

Common/include/grid_movement/CFreeFormDefBox.hpp

@@ -433,7 +433,7 @@ class CSurfaceMovement : public CGridMovement {
    * \param[in] FFDBox - Array with all the free forms FFDBoxes of the computation.
    * \param[in] val_mesh_filename - Name of the grid input file.
    */
-  void ReadFFDInfo(CGeometry* geometry, CConfig* config, CFreeFormDefBox** FFDBox, string val_mesh_filename);
+  void ReadFFDInfo(CGeometry* geometry, CConfig* config, CFreeFormDefBox** FFDBox, const string& val_mesh_filename);
 
   /*!
    * \brief Read the free form information from the grid input file.

Common/include/grid_movement/CSurfaceMovement.hpp

@@ -191,7 +191,7 @@ class CSysSolve {
    *
    * \pre the ostream object os should be open
    */
-  void WriteHeader(std::string solver, ScalarType restol, ScalarType resinit) const;
+  void WriteHeader(const std::string& solver, ScalarType restol, ScalarType resinit) const;
 
   /*!
    * \brief writes residual convergence data for one iteration to a stream
@@ -208,7 +208,7 @@ class CSysSolve {
    * \param[in] iter - current iteration
    * \param[in] res - the residual norm
    */
-  void WriteFinalResidual(std::string solver, unsigned long iter, ScalarType res) const;
+  void WriteFinalResidual(const std::string& solver, unsigned long iter, ScalarType res) const;
 
   /*!
    * \brief writes the convergence warning

Common/include/linear_algebra/CSysSolve.hpp

@@ -44,7 +44,7 @@ int CBaseMPIWrapper::MinRankError;
 bool CBaseMPIWrapper::winMinRankErrorInUse = false;
 CBaseMPIWrapper::Win CBaseMPIWrapper::winMinRankError;
 
-void CBaseMPIWrapper::Error(std::string ErrorMsg, std::string FunctionName) {
+void CBaseMPIWrapper::Error(const std::string& ErrorMsg, const std::string& FunctionName) {
   /* Set MinRankError to Rank, as the error message is called on this rank. */
   MinRankError = Rank;
   int flag = 0;