Skip to content

Commit 520b978

Browse files
Apply suggestions from code review
Co-authored-by: TobiKattmann <31306376+TobiKattmann@users.noreply.github.com>
1 parent e348065 commit 520b978

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

SU2_CFD/src/numerics/heat.cpp

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ void CCentSca_Heat::ComputeResidual(su2double *val_residual, su2double **val_Jac
7676

7777
/*--- Computing the second order centered scheme part ---*/
7878

79-
su2double ProjVelocity = 0.5*(ProjVelocity_i+ProjVelocity_j);
79+
const su2double ProjVelocity = 0.5*(ProjVelocity_i+ProjVelocity_j);
8080

8181
val_residual[0] = 0.5*(Temp_i + Temp_j)*ProjVelocity;
8282

@@ -87,21 +87,21 @@ void CCentSca_Heat::ComputeResidual(su2double *val_residual, su2double **val_Jac
8787

8888
/*--- Adding artificial dissipation to stabilize the centered scheme ---*/
8989

90-
su2double Diff_Lapl = Und_Lapl_i[0]-Und_Lapl_j[0];
91-
su2double Area2 = GeometryToolbox::SquaredNorm(nDim, Normal);
90+
const su2double Diff_Lapl = Und_Lapl_i[0]-Und_Lapl_j[0];
91+
const su2double Area2 = GeometryToolbox::SquaredNorm(nDim, Normal);
9292

93-
su2double SoundSpeed_i = sqrt(pow(ProjVelocity_i,2) + (BetaInc2_i/DensityInc_i)*Area2);
94-
su2double SoundSpeed_j = sqrt(pow(ProjVelocity_j,2) + (BetaInc2_j/DensityInc_j)*Area2);
93+
const su2double SoundSpeed_i = sqrt(pow(ProjVelocity_i,2) + (BetaInc2_i/DensityInc_i)*Area2);
94+
const su2double SoundSpeed_j = sqrt(pow(ProjVelocity_j,2) + (BetaInc2_j/DensityInc_j)*Area2);
9595

96-
su2double Local_Lambda_i = fabs(ProjVelocity_i)+SoundSpeed_i;
97-
su2double Local_Lambda_j = fabs(ProjVelocity_j)+SoundSpeed_j;
98-
su2double MeanLambda = 0.5*(Local_Lambda_i+Local_Lambda_j);
96+
const su2double Local_Lambda_i = fabs(ProjVelocity_i)+SoundSpeed_i;
97+
const su2double Local_Lambda_j = fabs(ProjVelocity_j)+SoundSpeed_j;
98+
const su2double MeanLambda = 0.5*(Local_Lambda_i+Local_Lambda_j);
9999

100100
val_residual[0] += -Param_Kappa_4*Diff_Lapl*MeanLambda;
101101

102102
if (implicit) {
103-
su2double cte_0 = Param_Kappa_4*su2double(Neighbor_i+1)*MeanLambda;
104-
su2double cte_1 = Param_Kappa_4*su2double(Neighbor_j+1)*MeanLambda;
103+
const su2double cte_0 = Param_Kappa_4*su2double(Neighbor_i+1)*MeanLambda;
104+
const su2double cte_1 = Param_Kappa_4*su2double(Neighbor_j+1)*MeanLambda;
105105

106106
val_Jacobian_i[0][0] += cte_0;
107107
val_Jacobian_j[0][0] -= cte_1;
@@ -135,8 +135,8 @@ void CUpwSca_Heat::ComputeResidual(su2double *val_residual, su2double **val_Jaco
135135

136136
if (dynamic_grid) {
137137
for (unsigned short iDim = 0; iDim < nDim; iDim++) {
138-
su2double Velocity_i = V_i[iDim+1] - GridVel_i[iDim];
139-
su2double Velocity_j = V_j[iDim+1] - GridVel_j[iDim];
138+
const su2double Velocity_i = V_i[iDim+1] - GridVel_i[iDim];
139+
const su2double Velocity_j = V_j[iDim+1] - GridVel_j[iDim];
140140
q_ij += 0.5*(Velocity_i+Velocity_j)*Normal[iDim];
141141
}
142142
}
@@ -146,8 +146,8 @@ void CUpwSca_Heat::ComputeResidual(su2double *val_residual, su2double **val_Jaco
146146
}
147147
}
148148

149-
su2double a0 = 0.5*(q_ij+fabs(q_ij));
150-
su2double a1 = 0.5*(q_ij-fabs(q_ij));
149+
const su2double a0 = 0.5*(q_ij+fabs(q_ij));
150+
const su2double a1 = 0.5*(q_ij-fabs(q_ij));
151151

152152
val_residual[0] = a0*Temp_i+a1*Temp_j;
153153

0 commit comments

Comments
 (0)