fix mem leak, fix gcc 4.8

Author: pcarruscag

Common/include/linear_algebra/CSysVector.hpp

@@ -67,8 +67,6 @@ class CSysVector : public VecExpr::CVecExpr<CSysVector<ScalarType>, ScalarType>
   unsigned long nElm = 0;          /*!< \brief Total number of elements (or number elements on this processor). */
   unsigned long nElmDomain = 0;    /*!< \brief Total number of elements without Ghost cells. */
   unsigned long nVar = 0;          /*!< \brief Number of elements in a block. */
-  mutable ScalarType dotRes = 0.0; /*!< \brief Result of dot product. to perform a reduction with OpenMP the
-                                               variable needs to be declared outside the parallel region. */
 
   /*!
    * \brief Generic initialization from a scalar or array.
@@ -101,7 +99,7 @@ class CSysVector : public VecExpr::CVecExpr<CSysVector<ScalarType>, ScalarType>
   /*!
    * \brief Default constructor of the class.
    */
-  CSysVector() {}
+  CSysVector() = default;
 
   /*!
    * \brief Destructor
@@ -291,8 +289,10 @@ class CSysVector : public VecExpr::CVecExpr<CSysVector<ScalarType>, ScalarType>
    */
   template <class T>
   ScalarType dot(const VecExpr::CVecExpr<T, ScalarType>& expr) const {
+    static ScalarType dotRes;
     /*--- All threads get the same "view" of the vectors and shared variable. ---*/
     SU2_OMP_BARRIER
+    SU2_OMP_MASTER
     dotRes = 0.0;
     SU2_OMP_BARRIER
 

SU2_CFD/include/numerics_simd/flow/diffusion/viscous_fluxes.hpp

@@ -91,7 +91,7 @@ class CCompressibleViscousFluxBase : public CNumericsSIMD {
    */
   template<class... Ts>
   CCompressibleViscousFluxBase(const CConfig& config, int iMesh,
-                               const CVariable* turbVars_ = nullptr, Ts&...) :
+                               const CVariable* turbVars_, Ts&...) :
     gamma(config.GetGamma()),
     gasConst(config.GetGas_ConstantND()),
     prandtlLam(config.GetPrandtl_Lam()),

SU2_CFD/src/solvers/CEulerSolver.cpp

@@ -670,6 +670,7 @@ CEulerSolver::~CEulerSolver(void) {
 
 void CEulerSolver::InstantiateEdgeNumerics(const CSolver* const* solver_container, const CConfig* config) {
 
+  SU2_OMP_BARRIER
   SU2_OMP_MASTER {
 
   if (config->Low_Mach_Correction())