Merge remote-tracking branch 'github/fix_addresssanitizer_findings' into fix_addresssanitizer_findings

Author: maxaehle

Common/include/option_structure.inl

@@ -1710,7 +1710,7 @@ class COptionActDisk : public COptionBase {
     delete[] marker_outlet;
 
     SetDefault();
-  };
+  }
 
   string SetValue(const vector<string>& option_value) override {
     COptionBase::SetValue(option_value);

SU2_CFD/include/solvers/CFVMFlowSolverBase.inl

@@ -979,8 +979,8 @@ void CFVMFlowSolverBase<V, R>::LoadRestart_impl(CGeometry **geometry, CSolver **
   {
   /*--- Delete the class memory that is used to load the restart. ---*/
 
-    Restart_Vars.clear(); Restart_Vars.shrink_to_fit();
-    Restart_Data.clear(); Restart_Data.shrink_to_fit();
+    Restart_Vars = decltype(Restart_Vars){};
+    Restart_Data = decltype(Restart_Data){};
   }
   END_SU2_OMP_SAFE_GLOBAL_ACCESS
 }

SU2_CFD/src/solvers/CAdjEulerSolver.cpp

@@ -3898,8 +3898,8 @@ void CAdjEulerSolver::LoadRestart(CGeometry **geometry, CSolver ***solver, CConf
 
   /*--- Delete the class memory that is used to load the restart. ---*/
 
-  Restart_Vars.clear(); Restart_Vars.shrink_to_fit();
-  Restart_Data.clear(); Restart_Data.shrink_to_fit();
+  Restart_Vars = decltype(Restart_Vars){};
+  Restart_Data = decltype(Restart_Data){};
 }
 
 void CAdjEulerSolver::SetAuxVar_Surface_Gradient(CGeometry *geometry, const CConfig *config) {

SU2_CFD/src/solvers/CBaselineSolver.cpp

@@ -480,8 +480,8 @@ void CBaselineSolver::LoadRestart(CGeometry **geometry, CSolver ***solver, CConf
 
   /*--- Delete the class memory that is used to load the restart. ---*/
 
-  Restart_Vars.clear(); Restart_Vars.shrink_to_fit();
-  Restart_Data.clear(); Restart_Data.shrink_to_fit();
+  Restart_Vars = decltype(Restart_Vars){};
+  Restart_Data = decltype(Restart_Data){};
 }
 
 void CBaselineSolver::LoadRestart_FSI(CGeometry *geometry, CConfig *config, int val_iter) {

SU2_CFD/src/solvers/CBaselineSolver_FEM.cpp

@@ -379,8 +379,8 @@ void CBaselineSolver_FEM::LoadRestart(CGeometry **geometry, CSolver ***solver, C
 
   /*--- Delete the class memory that is used to load the restart. ---*/
 
-  Restart_Vars.clear(); Restart_Vars.shrink_to_fit();
-  Restart_Data.clear(); Restart_Data.shrink_to_fit();
+  Restart_Vars = decltype(Restart_Vars){};
+  Restart_Data = decltype(Restart_Data){};
 }
 
 CBaselineSolver_FEM::~CBaselineSolver_FEM() = default;

SU2_CFD/src/solvers/CFEASolver.cpp

@@ -3142,8 +3142,8 @@ void CFEASolver::LoadRestart(CGeometry **geometry, CSolver ***solver, CConfig *c
 
   /*--- Delete the class memory that is used to load the restart. ---*/
 
-  Restart_Vars.clear(); Restart_Vars.shrink_to_fit();
-  Restart_Data.clear(); Restart_Data.shrink_to_fit();
+  Restart_Vars = decltype(Restart_Vars){};
+  Restart_Data = decltype(Restart_Data){};
 }
 
 void CFEASolver::RegisterVariables(CGeometry *geometry, CConfig *config, bool reset)

SU2_CFD/src/solvers/CFEM_DG_EulerSolver.cpp

@@ -9571,6 +9571,6 @@ void CFEM_DG_EulerSolver::LoadRestart(CGeometry **geometry, CSolver ***solver, C
 
   /*--- Delete the class memory that is used to load the restart. ---*/
 
-  Restart_Vars.clear(); Restart_Vars.shrink_to_fit();
-  Restart_Data.clear(); Restart_Data.shrink_to_fit();
+  Restart_Vars = decltype(Restart_Vars){};
+  Restart_Data = decltype(Restart_Data){};
 }

SU2_CFD/src/solvers/CHeatSolver.cpp

@@ -265,8 +265,8 @@ void CHeatSolver::LoadRestart(CGeometry **geometry, CSolver ***solver, CConfig *
   /*--- Delete the class memory that is used to load the restart. ---*/
 
   BEGIN_SU2_OMP_SAFE_GLOBAL_ACCESS {
-    Restart_Vars.clear(); Restart_Vars.shrink_to_fit();
-    Restart_Data.clear(); Restart_Data.shrink_to_fit();
+    Restart_Vars = decltype(Restart_Vars){};
+    Restart_Data = decltype(Restart_Data){};
   }
   END_SU2_OMP_SAFE_GLOBAL_ACCESS
 }

SU2_CFD/src/solvers/CMeshSolver.cpp

@@ -857,8 +857,8 @@ void CMeshSolver::LoadRestart(CGeometry **geometry, CSolver ***solver, CConfig *
 
   /*--- Delete the class memory that is used to load the restart. ---*/
 
-  Restart_Vars.clear(); Restart_Vars.shrink_to_fit();
-  Restart_Data.clear(); Restart_Data.shrink_to_fit();
+  Restart_Vars = decltype(Restart_Vars){};
+  Restart_Data = decltype(Restart_Data){};
 }
 
 void CMeshSolver::RestartOldGeometry(CGeometry *geometry, const CConfig *config) {
@@ -955,8 +955,8 @@ void CMeshSolver::RestartOldGeometry(CGeometry *geometry, const CConfig *config)
 
     /*--- Delete the class memory that is used to load the restart. ---*/
 
-    Restart_Vars.clear(); Restart_Vars.shrink_to_fit();
-    Restart_Data.clear(); Restart_Data.shrink_to_fit();
+    Restart_Vars = decltype(Restart_Vars){};
+    Restart_Data = decltype(Restart_Data){};
 
     InitiateComms(geometry, config, CommType);
     CompleteComms(geometry, config, CommType);

SU2_CFD/src/solvers/CRadSolver.cpp

@@ -160,6 +160,6 @@ void CRadSolver::LoadRestart(CGeometry **geometry, CSolver ***solver, CConfig *c
 
   /*--- Delete the class memory that is used to load the restart. ---*/
 
-  Restart_Vars.clear(); Restart_Vars.shrink_to_fit();
-  Restart_Data.clear(); Restart_Data.shrink_to_fit();
+  Restart_Vars = decltype(Restart_Vars){};
+  Restart_Data = decltype(Restart_Data){};
 }