Skip to content

Commit 4ba9b11

Browse files
committed
PR comments
1 parent 38ae887 commit 4ba9b11

1 file changed

Lines changed: 16 additions & 18 deletions

File tree

Common/src/geometry/CPhysicalGeometry.cpp

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -8461,40 +8461,38 @@ void CPhysicalGeometry::ComputeMeshQualityStatistics(const CConfig *config) {
84618461
/*-- Loop over the edges of a face ---*/
84628462
for (unsigned short iEdgesFace = 0; iEdgesFace < nEdgesFace; iEdgesFace++) {
84638463

8464-
const auto face_iPoint = elem[iElem]->GetNode(elem[iElem]->GetFaces(iFace,iEdgesFace));
8465-
unsigned long face_jPoint;
8464+
const auto face_iNode = elem[iElem]->GetFaces(iFace,iEdgesFace);
8465+
unsigned short face_jNode;
84668466

84678467
if (nDim == 2) {
84688468
/*--- In 2D only one edge (two points) per edge ---*/
8469-
face_jPoint = elem[iElem]->GetNode(elem[iElem]->GetFaces(iFace,1));
8469+
face_jNode = elem[iElem]->GetFaces(iFace,1);
84708470
}
84718471
else {
84728472
/*--- In 3D we "circle around" the face ---*/
8473-
face_jPoint = elem[iElem]->GetNode(elem[iElem]->GetFaces(iFace, (iEdgesFace+1)%nEdgesFace));
8473+
face_jNode = elem[iElem]->GetFaces(iFace, (iEdgesFace+1)%nEdgesFace);
84748474
}
84758475

8476-
const su2double* Coord_FaceiPoint = nodes->GetCoord(face_iPoint);
8477-
const su2double* Coord_FacejPoint = nodes->GetCoord(face_jPoint);
8476+
const auto face_iPoint = elem[iElem]->GetNode(face_iNode);
8477+
const auto face_jPoint = elem[iElem]->GetNode(face_jNode);
84788478

84798479
su2double Coord_Edge_CG[MAXNDIM] = {0.0};
84808480
for (unsigned short iDim = 0; iDim < nDim; iDim++) {
8481-
Coord_Edge_CG[iDim] = 0.5 * (Coord_FaceiPoint[iDim] + Coord_FacejPoint[iDim]);
8481+
Coord_Edge_CG[iDim] = 0.5 * (Coord[face_iNode][iDim] + Coord[face_jNode][iDim]);
84828482
}
84838483

84848484
/*--- Access the sub-volume of the element separately in 2D or 3D. ---*/
84858485

84868486
su2double Volume_i, Volume_j;
8487-
switch (nDim) {
8488-
case 2:
8489-
Volume_i = CEdge::GetVolume(Coord_FaceiPoint, Coord_Edge_CG, Coord_Elem_CG);
8490-
Volume_j = CEdge::GetVolume(Coord_FacejPoint, Coord_Edge_CG, Coord_Elem_CG);
8491-
break;
8492-
case 3:
8493-
Volume_i = CEdge::GetVolume(Coord_FaceiPoint, Coord_Edge_CG,
8494-
Coord_FaceElem_CG, Coord_Elem_CG);
8495-
Volume_j = CEdge::GetVolume(Coord_FacejPoint, Coord_Edge_CG,
8496-
Coord_FaceElem_CG, Coord_Elem_CG);
8497-
break;
8487+
if (nDim == 2) {
8488+
Volume_i = CEdge::GetVolume(Coord[face_iNode], Coord_Edge_CG, Coord_Elem_CG);
8489+
Volume_j = CEdge::GetVolume(Coord[face_jNode], Coord_Edge_CG, Coord_Elem_CG);
8490+
}
8491+
else {
8492+
Volume_i = CEdge::GetVolume(Coord[face_iNode], Coord_Edge_CG,
8493+
Coord_FaceElem_CG, Coord_Elem_CG);
8494+
Volume_j = CEdge::GetVolume(Coord[face_jNode], Coord_Edge_CG,
8495+
Coord_FaceElem_CG, Coord_Elem_CG);
84988496
}
84998497

85008498
/*--- Check if sub-elem volume is the min or max for iPoint. ---*/

0 commit comments

Comments
 (0)