Skip to content

Commit 3b36f42

Browse files
authored
Apply suggestions from code review
1 parent 67e492f commit 3b36f42

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

SU2_CFD/src/output/COutput.cpp

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -850,7 +850,6 @@ bool COutput::Convergence_Monitoring(CConfig *config, unsigned long Iteration) {
850850
for (unsigned short iField_Conv = 0; iField_Conv < convFields.size(); iField_Conv++){
851851

852852
bool fieldConverged = false;
853-
su2double cauchyScalingFactor = 1.0;
854853

855854
const string &convField = convFields[iField_Conv];
856855
if (historyOutput_Map.count(convField) > 0){
@@ -874,17 +873,12 @@ bool COutput::Convergence_Monitoring(CConfig *config, unsigned long Iteration) {
874873

875874
oldFunc[iField_Conv] = newFunc[iField_Conv];
876875
newFunc[iField_Conv] = monitor;
877-
878876
/*--- Automatically modify the scaling factor of relative Cauchy convergence for
879877
* coefficients that are close to zero. Example: For the clean aircraft, the rolling
880878
* moment coefficient MOMENT_X is close to zero and thus will never reach a relative
881879
* cauchy convergence ->> dividing tiny numbers is not a good idea. Using absolute
882880
* cauchy convergence is more robust in this case. ---*/
883-
884-
if (fabs(monitor) <= 0.1) { cauchyScalingFactor = 0.1; }
885-
else { cauchyScalingFactor = fabs(monitor); }
886-
887-
cauchyFunc = fabs(newFunc[iField_Conv] - oldFunc[iField_Conv])/cauchyScalingFactor;
881+
cauchyFunc = fabs(newFunc[iField_Conv] - oldFunc[iField_Conv])/fmax(fabs(monitor), 0.1);
888882

889883
cauchySerie[iField_Conv][Iteration % nCauchy_Elems] = cauchyFunc;
890884
cauchyValue = 0.0;

0 commit comments

Comments
 (0)