Remove SetInitalCond routine of CSpeciesSolver as it is superfluous.

Author: TobiKattmann

SU2_CFD/include/solvers/CSpeciesSolver.hpp

@@ -81,16 +81,6 @@ class CSpeciesSolver : public CScalarSolver<CSpeciesVariable> {
   void Preprocessing(CGeometry* geometry, CSolver** solver_container, CConfig* config, unsigned short iMesh,
                      unsigned short iRKStep, unsigned short RunTime_EqSystem, bool Output) final;
 
-  /*!
-   * \brief Set the initial condition for the species transport problem.
-   * \param[in] geometry - Geometrical definition of the problem.
-   * \param[in] solver_container - Container with all the solutions.
-   * \param[in] config - Definition of the particular problem.
-   * \param[in] ExtIter - External iteration.
-   */
-  void SetInitialCondition(CGeometry** geometry, CSolver*** solver_container, CConfig* config,
-                           unsigned long ExtIter) final;
-
   /*!
    * \brief Compute the viscous flux for the turbulent equation at a particular edge.
    * \param[in] iEdge - Edge for which we want to compute the flux

SU2_CFD/src/drivers/CDriver.cpp

@@ -2991,9 +2991,6 @@ void CFluidDriver::Preprocess(unsigned long Iter) {
       if (config_container[iZone]->GetFluidProblem()) {
         for (iInst = 0; iInst < nInst[iZone]; iInst++) {
           solver_container[iZone][iInst][MESH_0][FLOW_SOL]->SetInitialCondition(geometry_container[iZone][INST_0], solver_container[iZone][iInst], config_container[iZone], Iter);
-          /// NOTE TK:: Check if this is necessary here . Why is this not done for turb or heat for example.
-          if (config_container[iZone]->GetKind_Species_Model() != SPECIES_MODEL::NONE)
-            solver_container[iZone][iInst][MESH_0][SPECIES_SOL]->SetInitialCondition(geometry_container[iZone][INST_0], solver_container[iZone][iInst], config_container[iZone], Iter);
         }
       }
     }

SU2_CFD/src/drivers/CMultizoneDriver.cpp

@@ -249,14 +249,6 @@ void CMultizoneDriver::Preprocess(unsigned long TimeIter) {
                                                                               solver_container[iZone][INST_0],
                                                                               config_container[iZone], TimeIter);
     }
-    /// NOTE TK:: check whether this is necessary
-    else if (!fsi && (config_container[iZone]->GetKind_Species_Model() != SPECIES_MODEL::NONE)) {
-      SU2_MPI::Error("Species solver with multizone needs some testing probably!", CURRENT_FUNCTION);
-      /*--- Set the initial condition for species equation ---------------------------------------------*/
-      solver_container[iZone][INST_0][MESH_0][SPECIES_SOL]->SetInitialCondition(geometry_container[iZone][INST_0],
-                                                                                solver_container[iZone][INST_0],
-                                                                                config_container[iZone], TimeIter);
-    }
   }
 
   SU2_MPI::Barrier(SU2_MPI::GetComm());

SU2_CFD/src/drivers/CSinglezoneDriver.cpp

@@ -141,13 +141,6 @@ void CSinglezoneDriver::Preprocess(unsigned long TimeIter) {
                                                                             solver_container[ZONE_0][INST_0],
                                                                             config_container[ZONE_0], TimeIter);
   }
-  /// NOTE TK:: is this necessary. What is my purpose when Turb does not do this.
-  else if (config_container[ZONE_0]->GetKind_Species_Model() != SPECIES_MODEL::NONE) {
-    /*--- Set the initial condition for species equation ---------------------------------------------*/
-    solver_container[ZONE_0][INST_0][MESH_0][SPECIES_SOL]->SetInitialCondition(geometry_container[ZONE_0][INST_0],
-                                                                               solver_container[ZONE_0][INST_0],
-                                                                               config_container[ZONE_0], TimeIter);
-  }
 
   SU2_MPI::Barrier(SU2_MPI::GetComm());
 

SU2_CFD/src/iteration/CFluidIteration.cpp

@@ -126,11 +126,11 @@ void CFluidIteration::Iterate(COutput* output, CIntegration**** integration, CGe
   }
 
   if (config[val_iZone]->GetKind_Species_Model() != SPECIES_MODEL::NONE){
-    config[val_iZone]->SetGlobalParam(MAIN_SOLVER::RANS, RUNTIME_SPECIES_SYS);
+    config[val_iZone]->SetGlobalParam(config[val_iZone]->GetKind_Solver(), RUNTIME_SPECIES_SYS);
     integration[val_iZone][val_iInst][SPECIES_SOL]->SingleGrid_Iteration(geometry, solver, numerics, config,
                                                                          RUNTIME_SPECIES_SYS, val_iZone, val_iInst);
 
-    /// NOTE TK:: THis only applies if mixture properties are used. But this also doesn't hurt if done w/out mixture properties.
+    // This only applies if mixture properties are used. But this also doesn't hurt if done w/out mixture properties.
     // In case of turbulence, the Turb-Post computes the correct eddy viscosity based on mixture-density and
     // mixture lam-visc. In order to get the correct mixture properties, based on the just updated mass-fractions, the
     // Flow-Pre has to be called upfront. The updated eddy-visc are copied into the flow-solver Primitive in another

SU2_CFD/src/solvers/CSpeciesSolver.cpp

@@ -319,33 +319,6 @@ void CSpeciesSolver::Preprocessing(CGeometry* geometry, CSolver** solver_contain
   CommonPreprocessing(geometry, config, Output);
 }
 
-void CSpeciesSolver::SetInitialCondition(CGeometry** geometry, CSolver*** solver_container, CConfig* config,
-                                         unsigned long ExtIter) {
-  const bool Restart = (config->GetRestart() || config->GetRestart_Flow());
-
-  /// NOTE TK:: Check whether this is done in the constructor for example and whether this is mnecessary. The TurbSolver
-  /// does not do this!
-  /*--- For a restart do nothing here. Otherwise initialize the solution with the Init value. ---*/
-  if ((!Restart) && ExtIter == 0) {
-    for (unsigned long iMesh = 0; iMesh <= config->GetnMGLevels(); iMesh++) {
-      SU2_OMP_FOR_STAT(omp_chunk_size)
-      for (unsigned long iPoint = 0; iPoint < geometry[iMesh]->GetnPoint(); iPoint++) {
-        solver_container[iMesh][SPECIES_SOL]->GetNodes()->SetSolution(iPoint, config->GetSpecies_Init());
-      }
-      END_SU2_OMP_FOR
-
-      solver_container[iMesh][SPECIES_SOL]->InitiateComms(geometry[iMesh], config, SOLUTION);
-      solver_container[iMesh][SPECIES_SOL]->CompleteComms(geometry[iMesh], config, SOLUTION);
-
-      solver_container[iMesh][FLOW_SOL]->InitiateComms(geometry[iMesh], config, SOLUTION);
-      solver_container[iMesh][FLOW_SOL]->CompleteComms(geometry[iMesh], config, SOLUTION);
-
-      solver_container[iMesh][FLOW_SOL]->Preprocessing(geometry[iMesh], solver_container[iMesh], config, iMesh,
-                                                       NO_RK_ITER, RUNTIME_FLOW_SYS, false);
-    }
-  }
-}
-
 void CSpeciesSolver::Viscous_Residual(unsigned long iEdge, CGeometry* geometry, CSolver** solver_container,
                                       CNumerics* numerics, CConfig* config) {
   /*--- Define an object to set solver specific numerics contribution. ---*/