Skip to content

Commit 353b3d2

Browse files
authored
Apply suggestions from code review
1 parent 34614e7 commit 353b3d2

4 files changed

Lines changed: 7 additions & 13 deletions

File tree

SU2_CFD/include/numerics/CNumerics.hpp

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -703,11 +703,10 @@ class CNumerics {
703703
/*!
704704
* \brief Set the value of the effective intermittency for the LM model.
705705
* \param[in] intermittency_eff_i - Value of the effective intermittency at point i.
706-
* \param[in] intermittency_eff_j - Value of the effective intermittency at point j.
707706
*/
708707
void SetIntermittencyEff(su2double val_intermittency_eff_i) {
709708
intermittency_eff_i = val_intermittency_eff_i;
710-
};
709+
}
711710

712711
/*!
713712
* \brief Set the gradient of the auxiliary variables.
@@ -1433,11 +1432,6 @@ class CNumerics {
14331432
return ERR;
14341433
}
14351434

1436-
/*!
1437-
* \brief Set intermittency for numerics (used in SA with LM transition model)
1438-
*/
1439-
inline virtual void SetIntermittency(su2double intermittency_in) { }
1440-
14411435
/*!
14421436
* \brief A virtual member.
14431437
*/

SU2_CFD/src/output/CFlowOutput.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2262,7 +2262,7 @@ void CFlowOutput::WriteForcesBreakdown(const CConfig* config, const CSolver* flo
22622262
file << "Menter's SST\n";
22632263
break;
22642264
}
2265-
if(transition) {
2265+
if (transition) {
22662266
file << "Transition model: ";
22672267
switch (Kind_Trans_Model) {
22682268
case TURB_TRANS_MODEL::NONE: break;

SU2_CFD/src/solvers/CEulerSolver.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1031,12 +1031,12 @@ void CEulerSolver::SetNondimensionalization(CConfig *config, unsigned short iMes
10311031
config->SetOmega_FreeStreamND(Omega_FreeStreamND);
10321032

10331033
if (config->GetTurbulenceIntensity_FreeStream() *100 <= 1.3) {
1034-
if(config->GetTurbulenceIntensity_FreeStream() *100 >=0.027) {
1034+
if (config->GetTurbulenceIntensity_FreeStream() *100 >=0.027) {
10351035
Re_ThetaT_FreeStream = (1173.51-589.428*config->GetTurbulenceIntensity_FreeStream() *100+0.2196/
10361036
(config->GetTurbulenceIntensity_FreeStream() *100*config->GetTurbulenceIntensity_FreeStream() *100));
10371037
}
10381038
else {
1039-
Re_ThetaT_FreeStream = (1173.51-589.428*config->GetTurbulenceIntensity_FreeStream() *100+0.2196/(0.27*0.27));
1039+
Re_ThetaT_FreeStream = (1173.51-589.428*config->GetTurbulenceIntensity_FreeStream() *100+0.2196/(0.27*0.27));
10401040
}
10411041
}
10421042
else {
@@ -1290,7 +1290,7 @@ void CEulerSolver::SetNondimensionalization(CConfig *config, unsigned short iMes
12901290
else if (config->GetSystemMeasurements() == US) Unit << "1/s";
12911291
NonDimTable << "Spec. Dissipation" << config->GetOmega_FreeStream() << config->GetOmega_FreeStream()/config->GetOmega_FreeStreamND() << Unit.str() << config->GetOmega_FreeStreamND();
12921292
Unit.str("");
1293-
if( config-> GetKind_Trans_Model() == TURB_TRANS_MODEL::LM) {
1293+
if (config-> GetKind_Trans_Model() == TURB_TRANS_MODEL::LM) {
12941294
NonDimTable << "Intermittency" << "-" << "-" << "-" << config->GetIntermittency_FreeStream();
12951295
Unit.str("");
12961296
NonDimTable << "Moment. Thick. Re" << "-" << "-" << "-" << config->GetReThetaT_FreeStream();

SU2_CFD/src/solvers/CTurbSSTSolver.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -323,8 +323,8 @@ void CTurbSSTSolver::Source_Residual(CGeometry *geometry, CSolver **solver_conta
323323

324324
/*--- Effective Intermittency ---*/
325325

326-
if(TURB_TRANS_MODEL::LM == config->GetKind_Trans_Model()) {
327-
numerics-> SetIntermittencyEff(solver_container[TRANS_SOL]->GetNodes()->GetIntermittencyEff(iPoint));
326+
if (TURB_TRANS_MODEL::LM == config->GetKind_Trans_Model()) {
327+
numerics->SetIntermittencyEff(solver_container[TRANS_SOL]->GetNodes()->GetIntermittencyEff(iPoint));
328328
}
329329

330330
if (axisymmetric){

0 commit comments

Comments
 (0)