Merge pull request #1346 from su2code/fix_slidingmesh_reconstructboundary_pr2

Fix the neighbor-finding in `CInterpolator::ReconstructBoundary`

Author: pcarruscag

Common/include/interface_interpolation/CInterpolator.hpp

@@ -28,7 +28,9 @@
 
 #include "../../include/basic_types/datatype_structure.hpp"
 #include "../../include/containers/C2DContainer.hpp"
+#include "../../include/containers/container_decorators.hpp"
 #include <vector>
+#include <algorithm>
 
 class CConfig;
 class CGeometry;
@@ -53,17 +55,21 @@ class CInterpolator {
   Buffer_Send_nVertex_Donor[1],      /*!< \brief Buffer to send number of vertices on the local processor. */
   *Buffer_Receive_nVertex_Donor;     /*!< \brief Buffer to store the number of vertices per processor on the Donor domain. */
 
-  long *Buffer_Send_GlobalPoint,     /*!< \brief Buffer to send global point indices. */
-  *Buffer_Receive_GlobalPoint;       /*!< \brief Buffer to receive global point indices. */
+  su2vector<unsigned long> Buffer_Send_GlobalPoint;     /*!< \brief Buffer to send global point indices. */
+  su2vector<unsigned long> Buffer_Receive_GlobalPoint;       /*!< \brief Buffer to receive global point indices. */
 
-  su2double *Buffer_Send_Coord,      /*!< \brief Buffer to send coordinate values. */
-  *Buffer_Receive_Coord;             /*!< \brief Buffer to receive coordinate values. */
+  su2activematrix Buffer_Send_Coord;      /*!< \brief Buffer to send coordinate values. */
+  su2activematrix Buffer_Receive_Coord;             /*!< \brief Buffer to receive coordinate values. */
 
-  unsigned long
-  *Buffer_Receive_nLinkedNodes,      /*!< \brief Buffer to receive the number of edges connected to each node. */
-  *Buffer_Receive_LinkedNodes,       /*!< \brief Buffer to receive the list of notes connected to the nodes through an edge. */
-  *Buffer_Receive_StartLinkedNodes,  /*!< \brief Buffer to receive the index of the Receive_LinkedNodes buffer where corresponding list of linked nodes begins. */
-  *Buffer_Receive_Proc;              /*!< \brief Buffer to receive the thread that owns the node. */
+  /*! \brief Buffer to receive the number of surface-connected edges, for each vertex. */
+  su2vector<unsigned long> Buffer_Receive_nLinkedNodes;
+  /*! \brief Buffer to receive the index of the Receive_LinkedNodes buffer where corresponding list of linked nodes begins. */
+  su2vector<unsigned long> Buffer_Receive_StartLinkedNodes;
+  /*! \brief Buffer to receive the list of surface-connected nodes, for each vertex.
+   * \details The vertices are ordered as in Buffer_Receive_nLinkedNodes and Buffer_Receive_StartLinkedNodes, but for each*/
+  su2vector<unsigned long> Buffer_Receive_LinkedNodes;
+  /*! \brief Buffer to receive the rank that owns the vertex. */
+  su2vector<unsigned long> Buffer_Receive_Proc;
 
   unsigned long
   nGlobalVertex_Target,              /*!< \brief Global number of vertex of the target boundary. */
@@ -141,7 +147,7 @@ class CInterpolator {
 
 protected:
   /*!
-   * \brief Recontstruct the boundary connectivity from parallel partitioning and broadcasts it to all threads
+   * \brief Reconstruct the boundary connectivity from parallel partitioning and broadcasts it to all threads.
    * \param[in] val_zone   - index of the zone
    * \param[in] val_marker - index of the marker
    */

Common/include/interface_interpolation/CSlidingMesh.hpp

@@ -63,8 +63,8 @@ class CSlidingMesh final : public CInterpolator {
    * \param[out] element  - double array where element node coordinates will be stored
    * \return Number of points included in the element.
    */
-  static int Build_3D_surface_element(const unsigned long *map, const unsigned long *startIndex,
-                                      const unsigned long* nNeighbor, const su2double *coord,
+  static int Build_3D_surface_element(const su2vector<unsigned long>& map, const su2vector<unsigned long>& startIndex,
+                                      const su2vector<unsigned long>& nNeighbor, const su2activematrix& coord,
                                       unsigned long centralNode, su2double** element);
 
   /*!