Skip to content

Commit 183da05

Browse files
authored
Merge pull request #1049 from jblueh/codi_medi_update
Update CoDiPack and MeDiPack
2 parents 16f3836 + 6002ec3 commit 183da05

8 files changed

Lines changed: 20 additions & 22 deletions

File tree

Common/include/mpi_structure.hpp

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -50,21 +50,16 @@
5050
#include <medi/medi.hpp>
5151
using namespace medi;
5252

53+
#include <codi/externals/codiMpiTypes.hpp>
54+
5355
class CMediMPIWrapper;
5456
typedef CMediMPIWrapper SU2_MPI;
5557

56-
#if defined CODI_REVERSE_TYPE
57-
#include <codi/externals/codiMediPackTypes.hpp>
58-
#if CODI_PRIMAL_INDEX_TAPE
59-
typedef CoDiPackToolPrimalRestore<su2double> MediTool;
60-
#else
61-
typedef CoDiPackTool<su2double> MediTool;
62-
#endif // defined CODI_REVERSE_TYPE
63-
#elif defined CODI_FORWARD_TYPE
64-
#include <codi/externals/codiForwardMediPackTypes.hpp>
65-
typedef CoDiPackForwardTool<su2double> MediTool;
66-
#endif // defined CODI_FORWARD_TYPE
67-
#define AMPI_ADOUBLE ((medi::MpiTypeInterface*)MediTool::MPI_TYPE)
58+
typedef CoDiMpiTypes<su2double> MediTypes;
59+
typedef MediTypes::Tool MediTool;
60+
61+
extern MediTypes* mediTypes;
62+
#define AMPI_ADOUBLE ((medi::MpiTypeInterface*)mediTypes->MPI_TYPE)
6863

6964
#else
7065
class CBaseMPIWrapper;

Common/include/mpi_structure.inl

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ inline passivedouble CBaseMPIWrapper::Wtime(void) {
286286

287287
inline void CMediMPIWrapper::Init(int *argc, char ***argv) {
288288
AMPI_Init(argc,argv);
289-
MediTool::init();
289+
mediTypes = new MediTypes();
290290
AMPI_Comm_rank(convertComm(currentComm), &Rank);
291291
AMPI_Comm_size(convertComm(currentComm), &Size);
292292

@@ -298,7 +298,7 @@ inline void CMediMPIWrapper::Init(int *argc, char ***argv) {
298298

299299
inline void CMediMPIWrapper::Init_thread(int *argc, char ***argv, int required, int* provided) {
300300
AMPI_Init_thread(argc,argv,required,provided);
301-
MediTool::init();
301+
mediTypes = new MediTypes();
302302
AMPI_Comm_rank(convertComm(currentComm), &Rank);
303303
AMPI_Comm_size(convertComm(currentComm), &Size);
304304

@@ -310,7 +310,7 @@ inline void CMediMPIWrapper::Init_thread(int *argc, char ***argv, int required,
310310

311311
inline void CMediMPIWrapper::Init_AMPI(void) {
312312
AMPI_Init_common();
313-
MediTool::init();
313+
mediTypes = new MediTypes();
314314
}
315315

316316
inline void CMediMPIWrapper::SetComm(Comm newComm){
@@ -391,6 +391,8 @@ inline void CMediMPIWrapper::Comm_size(Comm comm, int *size){
391391

392392
inline void CMediMPIWrapper::Finalize(){
393393
if( winMinRankErrorInUse ) MPI_Win_free(&winMinRankError);
394+
395+
delete mediTypes;
394396
AMPI_Finalize();
395397
}
396398

Common/src/mpi_structure.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ CBaseMPIWrapper::Win CBaseMPIWrapper::winMinRankError;
3939

4040
#ifdef HAVE_MPI
4141
#if defined CODI_REVERSE_TYPE || defined CODI_FORWARD_TYPE
42-
//AMPI_ADOUBLE_TYPE* AMPI_ADOUBLE;
42+
MediTypes* mediTypes;
4343
#include <medi/medi.cpp>
4444
#endif // defined CODI_REVERSE_TYPE || defined CODI_FORWARD_TYPE
4545

SU2_CFD/src/solvers/CSolver.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1843,6 +1843,7 @@ void CSolver::InitiateComms(CGeometry *geometry,
18431843
}
18441844

18451845
}
1846+
18461847
void CSolver::CompleteComms(CGeometry *geometry,
18471848
const CConfig *config,
18481849
unsigned short commType) {

externals/codi

Submodule codi updated 317 files

externals/medi

Submodule medi updated 170 files

meson_scripts/init.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ def init_submodules(method = 'auto'):
4444

4545
# This information of the modules is used if projects was not cloned using git
4646
# The sha tag must be maintained manually to point to the correct commit
47-
sha_version_codi = '501dcf0305df147481630f20ce37c2e624fb351f'
47+
sha_version_codi = 'b8ddede642eb2824a56c75cebddb79ba194c2ada'
4848
github_repo_codi = 'https://github.com/scicompkl/CoDiPack'
49-
sha_version_medi = 'edde14f9ac4026b72b1e130f61c0a78e8652afa5'
49+
sha_version_medi = '051753df5bb6e66c9fb6fbe4f2413c4ba187e81d'
5050
github_repo_medi = 'https://github.com/SciCompKL/MeDiPack'
5151
sha_version_meson = '29ef4478df6d3aaca40c7993f125b29409be1de2'
5252
github_repo_meson = 'https://github.com/mesonbuild/meson'

preconfigure.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -290,9 +290,9 @@ def init_codi(argument_dict, modes, mpi_support = False, update = False):
290290

291291
# This information of the modules is used if projects was not cloned using git
292292
# The sha tag must be maintained manually to point to the correct commit
293-
sha_version_codi = 'bd4a639c2fe625a80946c8365bd2976a2868cf46'
293+
sha_version_codi = 'b8ddede642eb2824a56c75cebddb79ba194c2ada'
294294
github_repo_codi = 'https://github.com/scicompkl/CoDiPack'
295-
sha_version_medi = '46a97e1d6e8fdd3cb42b06534cff6acad2a49693'
295+
sha_version_medi = '051753df5bb6e66c9fb6fbe4f2413c4ba187e81d'
296296
github_repo_medi = 'https://github.com/SciCompKL/MeDiPack'
297297

298298
medi_name = 'MeDiPack'

0 commit comments

Comments
 (0)