fix: review fixes

Author: astandrik

src/index.ts

@@ -35,6 +35,7 @@ export { default as useHoverDirty } from './useHoverDirty';
 export { default as useIdle } from './useIdle';
 export { default as useIntersection } from './useIntersection';
 export { default as useInterval } from './useInterval';
+export { default as useInterpolations } from './useInterpolations';
 export { default as useIsomorphicLayoutEffect } from './useIsomorphicLayoutEffect';
 export { default as useKey } from './useKey';
 export { default as createBreakpoint } from './factory/createBreakpoint';
@@ -95,7 +96,6 @@ export { default as useTimeout } from './useTimeout';
 export { default as useTimeoutFn } from './useTimeoutFn';
 export { default as useTitle } from './useTitle';
 export { default as useToggle } from './useToggle';
-export { default as useInterpolations } from './useInterpolations';
 export { default as useTween } from './useTween';
 export { default as useUnmount } from './useUnmount';
 export { default as useUnmountPromise } from './useUnmountPromise';

src/useInterpolations.ts

@@ -1,14 +1,13 @@
-import { useMemo } from "react";
-import useTween from "./useTween";
+import { useMemo } from 'react';
+import useTween from './useTween';
 
 export type InterpolationMap = Record<string, readonly [number, number]>;
 
 const formatMapEntryValue = (value: unknown): string => {
+  // Best-effort stringify for dev error logs; avoids throwing on circular structures.
   try {
     const json = JSON.stringify(value);
-    if (typeof json === "string") {
-      return json;
-    }
+    return json;
   } catch {
     // ignore
   }
@@ -18,21 +17,23 @@ const formatMapEntryValue = (value: unknown): string => {
 
 const useInterpolations = <T extends InterpolationMap>(
   map: T,
-  easingName: string = "inCirc",
+  easingName: string = 'inCirc',
   ms: number = 200,
   delay: number = 0
 ): { [K in keyof T]: number } => {
   const t = useTween(easingName, ms, delay);
 
   return useMemo(() => {
-    if (process.env.NODE_ENV !== "production") {
-      if (!map || typeof map !== "object") {
+    if (process.env.NODE_ENV !== 'production') {
+      if (!map || typeof map !== 'object') {
         console.error('useInterpolations() expected "map" to be an object.');
         return {} as { [K in keyof T]: number };
       }
+    }
 
-      const keys = Object.keys(map) as Array<keyof T>;
+    const keys = Object.keys(map) as Array<keyof T>;
 
+    if (process.env.NODE_ENV !== 'production') {
       for (const key of keys) {
         const value = map[key];
         const keyString = String(key);
@@ -43,7 +44,7 @@ const useInterpolations = <T extends InterpolationMap>(
           );
           return {} as { [K in keyof T]: number };
         }
-        if (typeof value[0] !== "number" || typeof value[1] !== "number") {
+        if (typeof value[0] !== 'number' || typeof value[1] !== 'number') {
           console.error(
             `useInterpolations() expected map["${keyString}"] to contain numbers, got [${typeof value[0]}, ${typeof value[1]}].`
           );
@@ -59,7 +60,6 @@ const useInterpolations = <T extends InterpolationMap>(
     }
 
     const result = {} as { [K in keyof T]: number };
-    const keys = Object.keys(map) as Array<keyof T>;
     for (const key of keys) {
       const [start, end] = map[key];
       result[key] = start + (end - start) * t;

tests/useInterpolations.test.ts

@@ -1,18 +1,18 @@
-import { renderHook } from "@testing-library/react-hooks";
-import * as useTween from "../src/useTween";
-import useInterpolations from "../src/useInterpolations";
+import { renderHook } from '@testing-library/react-hooks';
+import * as useTween from '../src/useTween';
+import useInterpolations from '../src/useInterpolations';
 
 let spyUseTween;
 
 beforeEach(() => {
-  spyUseTween = jest.spyOn(useTween, "default").mockReturnValue(0.5);
+  spyUseTween = jest.spyOn(useTween, 'default').mockReturnValue(0.5);
 });
 
 afterEach(() => {
   jest.restoreAllMocks();
 });
 
-it("should interpolate map values with default parameters", () => {
+it('should interpolate map values with default parameters', () => {
   const { result } = renderHook(() =>
     useInterpolations({
       left: [0, 100],
@@ -25,17 +25,17 @@ it("should interpolate map values with default parameters", () => {
   expect(result.current.top).toBe(100);
   expect(result.current.opacity).toBe(0.5);
   expect(spyUseTween).toHaveBeenCalledTimes(1);
-  expect(spyUseTween).toHaveBeenCalledWith("inCirc", 200, 0);
+  expect(spyUseTween).toHaveBeenCalledWith('inCirc', 200, 0);
 });
 
-it("should interpolate map values with custom parameters", () => {
+it('should interpolate map values with custom parameters', () => {
   const { result } = renderHook(() =>
     useInterpolations(
       {
         x: [10, 20],
         y: [-5, 5],
       },
-      "outCirc",
+      'outCirc',
       500,
       100
     )
@@ -44,10 +44,10 @@ it("should interpolate map values with custom parameters", () => {
   expect(result.current.x).toBe(15);
   expect(result.current.y).toBe(0);
   expect(spyUseTween).toHaveBeenCalledTimes(1);
-  expect(spyUseTween).toHaveBeenCalledWith("outCirc", 500, 100);
+  expect(spyUseTween).toHaveBeenCalledWith('outCirc', 500, 100);
 });
 
-it("should interpolate at t=0", () => {
+it('should interpolate at t=0', () => {
   spyUseTween.mockReturnValue(0);
 
   const { result } = renderHook(() =>
@@ -61,7 +61,7 @@ it("should interpolate at t=0", () => {
   expect(result.current.top).toBe(20);
 });
 
-it("should interpolate at t=1", () => {
+it('should interpolate at t=1', () => {
   spyUseTween.mockReturnValue(1);
 
   const { result } = renderHook(() =>
@@ -75,12 +75,12 @@ it("should interpolate at t=1", () => {
   expect(result.current.top).toBe(80);
 });
 
-describe("when invalid map is provided", () => {
+describe('when invalid map is provided', () => {
   beforeEach(() => {
-    jest.spyOn(console, "error").mockImplementation(() => {});
+    jest.spyOn(console, 'error').mockImplementation(() => {});
   });
 
-  it("should log an error when map is not an object", () => {
+  it('should log an error when map is not an object', () => {
     const { result } = renderHook(() =>
       useInterpolations(null as unknown as Record<string, readonly [number, number]>)
     );
@@ -92,7 +92,7 @@ describe("when invalid map is provided", () => {
     );
   });
 
-  it("should log an error when map value is not a tuple", () => {
+  it('should log an error when map value is not a tuple', () => {
     const { result } = renderHook(() =>
       useInterpolations({
         left: [10] as unknown as readonly [number, number],
@@ -106,10 +106,10 @@ describe("when invalid map is provided", () => {
     );
   });
 
-  it("should log an error when map value contains non-numbers", () => {
+  it('should log an error when map value contains non-numbers', () => {
     const { result } = renderHook(() =>
       useInterpolations({
-        left: ["0", 100] as unknown as readonly [number, number],
+        left: ['0', 100] as unknown as readonly [number, number],
       })
     );
 
@@ -120,7 +120,7 @@ describe("when invalid map is provided", () => {
     );
   });
 
-  it("should log an error when map value contains non-finite numbers", () => {
+  it('should log an error when map value contains non-finite numbers', () => {
     const { result } = renderHook(() =>
       useInterpolations({
         left: [0, Infinity],