Merge pull request #1593 from ishaan-arora-1/fix/typos-in-error-messages

WardBrian · web-flow · commit d111d2a1886f · 2026-02-23T09:24:11.000-05:00
Fix typos in user-facing error and warning messages
diff --git a/src/frontend/Semantic_error.ml b/src/frontend/Semantic_error.ml
@@ -479,7 +479,7 @@ module ExpressionError = struct
     | TupleIndexInvalidIndex (ix_max, ix) ->
         Fmt.pf ppf
           "Tried to access index %d for a tuple of length %d.@ Only indices \
-           indices between 1 and %d are valid."
+           between 1 and %d are valid."
           ix ix_max ix_max
     | TupleIndexNotTuple ut ->
         Fmt.pf ppf "Tried to index a non-tuple type. Expression has type %a."
diff --git a/src/frontend/Typechecker.ml b/src/frontend/Typechecker.ml
@@ -1017,7 +1017,7 @@ and check_expression cf tenv ({emeta; expr} : Ast.untyped_expression) :
                   (Fmt.str
                      "@[<v>Found chained comparison%aThis is interpreted \
                       as%tConsider if the intended meaning was%tinstead. You \
-                      can silence this warning by adding explicit parenthesis. \
+                      can silence this warning by adding explicit parentheses. \
                       This can be automatically changed using the canonicalize \
                       flag for stanc@]"
                      (pp_indented_box Pretty_printing.pp_expression)
diff --git a/test/integration/bad/tuples/stanc.expected b/test/integration/bad/tuples/stanc.expected
@@ -45,7 +45,7 @@ Semantic error in 'bad-index2.stan', line 3, column 11 to column 17:
    -------------------------------------------------
 
 Tried to access index 3 for a tuple of length 2.
-Only indices indices between 1 and 2 are valid.
+Only indices between 1 and 2 are valid.
 [exit 1]
   $ ../../../../../install/default/bin/stanc bad-index3.stan
 Semantic error in 'bad-index3.stan', line 3, column 3 to column 6:
@@ -70,7 +70,7 @@ Semantic error in 'bad-index4.stan', line 3, column 2 to column 8:
    -------------------------------------------------
 
 Tried to access index 3 for a tuple of length 2.
-Only indices indices between 1 and 2 are valid.
+Only indices between 1 and 2 are valid.
 [exit 1]
   $ ../../../../../install/default/bin/stanc bad-index5.stan
 Semantic error in 'bad-index5.stan', line 3, column 11 to column 18:
diff --git a/test/integration/cli-args/canonicalize/canonical.expected b/test/integration/cli-args/canonicalize/canonical.expected
@@ -247,7 +247,7 @@ Warning in 'parenthesize.stan', line 27, column 13 to column 22:
         (1 < 2) > 3
     Consider if the intended meaning was
         1 < 2 && 2 > 3
-    instead. You can silence this warning by adding explicit parenthesis.
+    instead. You can silence this warning by adding explicit parentheses.
     This can be automatically changed using the canonicalize flag for stanc
 Warning in 'parenthesize.stan', line 27, column 13 to column 26:
     Found chained comparison
@@ -256,7 +256,7 @@ Warning in 'parenthesize.stan', line 27, column 13 to column 26:
         (1 < 2 > 3) < 4
     Consider if the intended meaning was
         1 < 2 > 3 && 3 < 4
-    instead. You can silence this warning by adding explicit parenthesis.
+    instead. You can silence this warning by adding explicit parentheses.
     This can be automatically changed using the canonicalize flag for stanc
 [exit 0]
   $ ../../../../../install/default/bin/stanc --print-canonical squaremc.stan
diff --git a/test/integration/cli-args/canonicalize/deprecations-only.expected b/test/integration/cli-args/canonicalize/deprecations-only.expected
@@ -226,7 +226,7 @@ Warning in 'parenthesize.stan', line 27, column 13 to column 22:
         (1 < 2) > 3
     Consider if the intended meaning was
         1 < 2 && 2 > 3
-    instead. You can silence this warning by adding explicit parenthesis.
+    instead. You can silence this warning by adding explicit parentheses.
     This can be automatically changed using the canonicalize flag for stanc
 Warning in 'parenthesize.stan', line 27, column 13 to column 26:
     Found chained comparison
@@ -235,7 +235,7 @@ Warning in 'parenthesize.stan', line 27, column 13 to column 26:
         (1 < 2 > 3) < 4
     Consider if the intended meaning was
         1 < 2 > 3 && 3 < 4
-    instead. You can silence this warning by adding explicit parenthesis.
+    instead. You can silence this warning by adding explicit parentheses.
     This can be automatically changed using the canonicalize flag for stanc
 [exit 0]
   $ ../../../../../install/default/bin/stanc --auto-format --canonicalize deprecations squaremc.stan
diff --git a/test/integration/cli-args/canonicalize/everything-but.expected b/test/integration/cli-args/canonicalize/everything-but.expected
@@ -268,7 +268,7 @@ Warning in 'parenthesize.stan', line 27, column 13 to column 22:
         (1 < 2) > 3
     Consider if the intended meaning was
         1 < 2 && 2 > 3
-    instead. You can silence this warning by adding explicit parenthesis.
+    instead. You can silence this warning by adding explicit parentheses.
     This can be automatically changed using the canonicalize flag for stanc
 Warning in 'parenthesize.stan', line 27, column 13 to column 26:
     Found chained comparison
@@ -277,7 +277,7 @@ Warning in 'parenthesize.stan', line 27, column 13 to column 26:
         (1 < 2 > 3) < 4
     Consider if the intended meaning was
         1 < 2 > 3 && 3 < 4
-    instead. You can silence this warning by adding explicit parenthesis.
+    instead. You can silence this warning by adding explicit parentheses.
     This can be automatically changed using the canonicalize flag for stanc
 [exit 0]
   $ ../../../../../install/default/bin/stanc --auto-format --canonicalize braces,parentheses squaremc.stan
diff --git a/test/integration/cli-args/canonicalize/strip-comments.expected b/test/integration/cli-args/canonicalize/strip-comments.expected
@@ -235,7 +235,7 @@ Warning in 'parenthesize.stan', line 27, column 13 to column 22:
         (1 < 2) > 3
     Consider if the intended meaning was
         1 < 2 && 2 > 3
-    instead. You can silence this warning by adding explicit parenthesis.
+    instead. You can silence this warning by adding explicit parentheses.
     This can be automatically changed using the canonicalize flag for stanc
 Warning in 'parenthesize.stan', line 27, column 13 to column 26:
     Found chained comparison
@@ -244,7 +244,7 @@ Warning in 'parenthesize.stan', line 27, column 13 to column 26:
         (1 < 2 > 3) < 4
     Consider if the intended meaning was
         1 < 2 > 3 && 3 < 4
-    instead. You can silence this warning by adding explicit parenthesis.
+    instead. You can silence this warning by adding explicit parentheses.
     This can be automatically changed using the canonicalize flag for stanc
 [exit 0]
   $ ../../../../../install/default/bin/stanc --auto-format --canonicalize strip-comments,braces,parentheses,deprecations squaremc.stan
diff --git a/test/integration/good/warning/pretty.expected b/test/integration/good/warning/pretty.expected
@@ -36,7 +36,7 @@ Warning in 'deprecated_syntax.stan', line 2, column 6 to column 15:
         (1 < 2) < 3
     Consider if the intended meaning was
         1 < 2 && 2 < 3
-    instead. You can silence this warning by adding explicit parenthesis.
+    instead. You can silence this warning by adding explicit parentheses.
     This can be automatically changed using the canonicalize flag for stanc
 Warning in 'deprecated_syntax.stan', line 2, column 6 to column 19:
     Found chained comparison
@@ -45,7 +45,7 @@ Warning in 'deprecated_syntax.stan', line 2, column 6 to column 19:
         (1 < 2 < 3) < 4
     Consider if the intended meaning was
         1 < 2 < 3 && 3 < 4
-    instead. You can silence this warning by adding explicit parenthesis.
+    instead. You can silence this warning by adding explicit parentheses.
     This can be automatically changed using the canonicalize flag for stanc
 [exit 0]
   $ ../../../../../install/default/bin/stanc --auto-format empty.stan
