Add a bunch of missing test cases for parser errors

WardBrian · WardBrian · commit 954adaedb0fe · 2026-02-09T10:56:38.000-05:00
diff --git a/src/frontend/parser.messages b/src/frontend/parser.messages
@@ -1136,24 +1136,6 @@ program: FUNCTIONBLOCK LBRACE VOID IDENTIFIER LPAREN RPAREN SEMICOLON WHILE
 
 @{<light_red>Ill-formed block.@} Expected a @{<green>"}"@} or a function definition or declaration.
 
-functions_only: COMPLEX IDENTIFIER LPAREN COMPLEX RPAREN
-## Concrete syntax: complex foo ( complex )
-functions_only: COMPLEX IDENTIFIER LPAREN COMPLEX UNREACHABLE
-##
-## Concrete syntax: complex foo ( complex <<<<UNREACHABLE>>>
-##
-## Ends in an error in state: 43.
-##
-## basic_type -> basic_type . LABRACK UNREACHABLE [ WHILE VOID VECTOR UPPER UNITVECTOR TUPLE TRUNCATE TARGET SUMTOZEROVEC SUMTOZEROMAT STOCHASTICROWMATRIX STOCHASTICCOLUMNMATRIX SIMPLEX RPAREN ROWVECTOR RETURN REJECT REAL PROFILE PRINT POSITIVEORDERED PARAMETERSBLOCK ORDERED OFFSET MULTIPLIER MODELBLOCK MATRIX LOWER LBRACK LABRACK JACOBIAN INT IN IF IDENTIFIER FUNCTIONBLOCK FOR FATAL_ERROR ELSE DATABLOCK COVMATRIX CORRMATRIX CONTINUE COMPLEXVECTOR COMPLEXROWVECTOR COMPLEXMATRIX COMPLEX COMMA CHOLESKYFACTORCOV CHOLESKYFACTORCORR BREAK ARRAY ]
-## unsized_type -> basic_type . LBRACK UNREACHABLE [ WHILE VOID VECTOR UPPER UNITVECTOR TUPLE TRUNCATE TARGET SUMTOZEROVEC SUMTOZEROMAT STOCHASTICROWMATRIX STOCHASTICCOLUMNMATRIX SIMPLEX RPAREN ROWVECTOR RETURN REJECT REAL PROFILE PRINT POSITIVEORDERED PARAMETERSBLOCK ORDERED OFFSET MULTIPLIER MODELBLOCK MATRIX LOWER JACOBIAN INT IN IF IDENTIFIER FUNCTIONBLOCK FOR FATAL_ERROR ELSE DATABLOCK COVMATRIX CORRMATRIX CONTINUE COMPLEXVECTOR COMPLEXROWVECTOR COMPLEXMATRIX COMPLEX COMMA CHOLESKYFACTORCOV CHOLESKYFACTORCORR BREAK ARRAY ]
-## unsized_type -> basic_type . [ WHILE VOID VECTOR UPPER UNITVECTOR TUPLE TRUNCATE TARGET SUMTOZEROVEC SUMTOZEROMAT STOCHASTICROWMATRIX STOCHASTICCOLUMNMATRIX SIMPLEX RPAREN ROWVECTOR RETURN REJECT REAL PROFILE PRINT POSITIVEORDERED PARAMETERSBLOCK ORDERED OFFSET MULTIPLIER MODELBLOCK MATRIX LOWER JACOBIAN INT IN IF IDENTIFIER FUNCTIONBLOCK FOR FATAL_ERROR ELSE DATABLOCK COVMATRIX CORRMATRIX CONTINUE COMPLEXVECTOR COMPLEXROWVECTOR COMPLEXMATRIX COMPLEX COMMA CHOLESKYFACTORCOV CHOLESKYFACTORCORR BREAK ARRAY ]
-##
-## The known suffix of the stack is as follows:
-## basic_type
-##
-
-@{<light_red>Ill-formed function argument.@} Expected an identifier after the type for the function argument name.
-
 program: FUNCTIONBLOCK LBRACE VOID IDENTIFIER LPAREN DATABLOCK WHILE
 ##
 ## Concrete syntax: functions { void foo ( data while
@@ -1276,6 +1258,10 @@ program: FUNCTIONBLOCK LBRACE VOID IDENTIFIER WHILE
 
 @{<light_red>Ill-formed function.@} Expected @{<green>"("@} after function name.
 
+functions_only: COMPLEX IDENTIFIER LPAREN COMPLEX RPAREN
+## Concrete syntax: complex foo ( complex )
+functions_only: COMPLEX IDENTIFIER LPAREN COMPLEX UNREACHABLE
+## Concrete syntax: complex foo ( complex <<<<UNREACHABLE>>>
 program: FUNCTIONBLOCK LBRACE VOID LBRACK
 ##
 ## Concrete syntax: functions { void [
@@ -1288,7 +1274,7 @@ program: FUNCTIONBLOCK LBRACE VOID LBRACK
 ## return_type
 ##
 
-@{<light_red>Ill-formed function.@} Expected an identifier as a function name.
+@{<light_red>Ill-formed function.@} Expected an identifier after the type.
 
 program: FUNCTIONBLOCK LBRACE WHILE
 ##
diff --git a/test/integration/bad/err-expected-end-of-tp.stan b/test/integration/bad/err-expected-end-of-tp.stan
@@ -0,0 +1,4 @@
+transformed parameters {
+
+}
+mdel {}
diff --git a/test/integration/bad/lang/bad4.stanfunctions b/test/integration/bad/lang/bad4.stanfunctions
@@ -0,0 +1,3 @@
+array[,,] x() {
+    return ones_array(3, 3);
+}
diff --git a/test/integration/bad/lang/bad_decl5.stan b/test/integration/bad/lang/bad_decl5.stan
@@ -0,0 +1,3 @@
+model {
+  array[3,3] x;
+}
diff --git a/test/integration/bad/lang/bad_decl6.stan b/test/integration/bad/lang/bad_decl6.stan
@@ -0,0 +1,3 @@
+model {
+  array real x;
+}
diff --git a/test/integration/bad/lang/bad_jacobian.stan b/test/integration/bad/lang/bad_jacobian.stan
@@ -0,0 +1,3 @@
+transformed parameters {
+    jacobian += while;
+}
diff --git a/test/integration/bad/lang/incomplete10.stan b/test/integration/bad/lang/incomplete10.stan
@@ -0,0 +1,3 @@
+transformed data {
+  vector[2] foo = [ ;
+}
diff --git a/test/integration/bad/lang/incomplete11.stan b/test/integration/bad/lang/incomplete11.stan
@@ -0,0 +1,3 @@
+model {
+  real; foo;
+}
diff --git a/test/integration/bad/lang/incomplete12.stan b/test/integration/bad/lang/incomplete12.stan
@@ -0,0 +1,5 @@
+functions {
+  real (int x) {
+    return x + 1.0;
+  }
+}
diff --git a/test/integration/bad/lang/incomplete13.stan b/test/integration/bad/lang/incomplete13.stan
@@ -0,0 +1,5 @@
+functions {
+  void (int x) {
+    return x + 1.0;
+  }
+}
diff --git a/test/integration/bad/lang/incomplete14.stan b/test/integration/bad/lang/incomplete14.stan
@@ -0,0 +1,5 @@
+functions {
+  real foo(int , real x) {
+    return y + x;
+  }
+}
diff --git a/test/integration/bad/lang/incomplete7.stan b/test/integration/bad/lang/incomplete7.stan
@@ -0,0 +1 @@
+transformed data { foo += foo ~
diff --git a/test/integration/bad/lang/incomplete8.stan b/test/integration/bad/lang/incomplete8.stan
@@ -0,0 +1 @@
+transformed data { foo = bar ~
diff --git a/test/integration/bad/lang/incomplete9.stan b/test/integration/bad/lang/incomplete9.stan
@@ -0,0 +1,4 @@
+transformed data {
+  vector[2] foo;
+  row_vector[2] bar = -foo' while
+}
diff --git a/test/integration/bad/lang/stanc.expected b/test/integration/bad/lang/stanc.expected
@@ -97,6 +97,20 @@ Semantic error in 'bad4.stan', line 1, column 44 to column 48:
    -------------------------------------------------
 
 Lower bound of for-loop must be of type int. Instead found type real.
+[exit 1]
+  $ ../../../../../install/default/bin/stanc bad4.stanfunctions
+Syntax error in 'bad4.stanfunctions', line 1, column 10 to column 11, parsing error:
+   -------------------------------------------------
+     1:  array[,,] x() {
+                   ^
+     2:      return ones_array(3, 3);
+     3:  }
+   -------------------------------------------------
+
+Ill-formed type. Expected an unconstrained, non-array type after "array" declaration.
+  For example, this means a type like "matrix", not "corr_matrix" or "matrix[3,4]".
+  See the complete table of types at:
+  https://mc-stan.org/docs/reference-manual/types.html#variable-declaration.section
 [exit 1]
   $ ../../../../../install/default/bin/stanc bad5.stan
 Semantic error in 'bad5.stan', line 3, column 6 to column 10:
@@ -235,6 +249,31 @@ Syntax error in 'bad_decl4.stan', line 2, column 10 to column 16, parsing error:
    -------------------------------------------------
 
 Ill-formed identifier. Expected a new identifier but found reserved keyword "reject".
+[exit 1]
+  $ ../../../../../install/default/bin/stanc bad_decl5.stan
+Syntax error in 'bad_decl5.stan', line 2, column 13 to column 14, parsing error:
+   -------------------------------------------------
+     1:  model {
+     2:    array[3,3] x;
+                      ^
+     3:  }
+   -------------------------------------------------
+
+Ill-formed type. Expected an unconstrained, non-array type after "array" declaration.
+  For example, this means a type like "matrix", not "corr_matrix".
+  See the complete table of types at:
+  https://mc-stan.org/docs/reference-manual/types.html#variable-declaration.section
+[exit 1]
+  $ ../../../../../install/default/bin/stanc bad_decl6.stan
+Syntax error in 'bad_decl6.stan', line 2, column 8 to column 12, parsing error:
+   -------------------------------------------------
+     1:  model {
+     2:    array real x;
+                 ^
+     3:  }
+   -------------------------------------------------
+
+Ill-formed type. Expected "[" array sizes "]" followed by type after "array".
 [exit 1]
   $ ../../../../../install/default/bin/stanc bad_function.stan
 Semantic error in 'bad_function.stan', line 3, column 3 to column 7:
@@ -259,6 +298,17 @@ Semantic error in 'bad_function2.stan', line 3, column 3 to column 7:
    -------------------------------------------------
 
 A non-returning function was expected but an undeclared identifier "y" was supplied.
+[exit 1]
+  $ ../../../../../install/default/bin/stanc bad_jacobian.stan
+Syntax error in 'bad_jacobian.stan', line 2, column 16 to column 21, parsing error:
+   -------------------------------------------------
+     1:  transformed parameters {
+     2:      jacobian += while;
+                         ^
+     3:  }
+   -------------------------------------------------
+
+Ill-formed statement. Expected an expression followed by ";" after "jacobian +=".
 [exit 1]
   $ ../../../../../install/default/bin/stanc bad_lmpf.stan
 Semantic error in 'bad_lmpf.stan', line 2, column 2 to line 4, column 3:
@@ -447,6 +497,64 @@ Syntax error in 'incomplete.stan', line 2, column 18 to column 19, parsing error
 
 Ill-formed expression. Found an incomplete binary expression.
 Are you missing the right hand side?
+[exit 1]
+  $ ../../../../../install/default/bin/stanc incomplete10.stan
+Syntax error in 'incomplete10.stan', line 2, column 20 to column 21, parsing error:
+   -------------------------------------------------
+     1:  transformed data {
+     2:    vector[2] foo = [ ;
+                             ^
+     3:  }
+   -------------------------------------------------
+
+Ill-formed expression. Expected a comma separated list of expressions followed by "]" after "[".
+[exit 1]
+  $ ../../../../../install/default/bin/stanc incomplete11.stan
+Syntax error in 'incomplete11.stan', line 2, column 6 to column 7, parsing error:
+   -------------------------------------------------
+     1:  model {
+     2:    real; foo;
+               ^
+     3:  }
+   -------------------------------------------------
+
+Ill-formed declaration. Expected an identifier after type in local (or model block) variable declaration.
+[exit 1]
+  $ ../../../../../install/default/bin/stanc incomplete12.stan
+Syntax error in 'incomplete12.stan', line 2, column 7 to column 8, parsing error:
+   -------------------------------------------------
+     1:  functions {
+     2:    real (int x) {
+                ^
+     3:      return x + 1.0;
+     4:    }
+   -------------------------------------------------
+
+Ill-formed function. Expected an identifier after the type.
+[exit 1]
+  $ ../../../../../install/default/bin/stanc incomplete13.stan
+Syntax error in 'incomplete13.stan', line 2, column 7 to column 8, parsing error:
+   -------------------------------------------------
+     1:  functions {
+     2:    void (int x) {
+                ^
+     3:      return x + 1.0;
+     4:    }
+   -------------------------------------------------
+
+Ill-formed function. Expected an identifier after the type.
+[exit 1]
+  $ ../../../../../install/default/bin/stanc incomplete14.stan
+Syntax error in 'incomplete14.stan', line 2, column 15 to column 16, parsing error:
+   -------------------------------------------------
+     1:  functions {
+     2:    real foo(int , real x) {
+                        ^
+     3:      return y + x;
+     4:    }
+   -------------------------------------------------
+
+Ill-formed function. Expected an identifier after the type.
 [exit 1]
   $ ../../../../../install/default/bin/stanc incomplete2.stan
 Syntax error in 'incomplete2.stan', line 2, column 15 to column 20, parsing error:
@@ -506,6 +614,36 @@ Syntax error in 'incomplete6.stan', line 3, column 16 to column 21, parsing erro
    -------------------------------------------------
 
 Ill-formed expression. Expected a comma separated list of expressions, followed by "]".
+[exit 1]
+  $ ../../../../../install/default/bin/stanc incomplete7.stan
+Syntax error in 'incomplete7.stan', line 1, column 30 to column 31, parsing error:
+   -------------------------------------------------
+     1:  transformed data { foo += foo ~
+                                       ^
+   -------------------------------------------------
+
+Ill-formed compound assignment statement. Expected a ";" after the value being assigned.
+[exit 1]
+  $ ../../../../../install/default/bin/stanc incomplete8.stan
+Syntax error in 'incomplete8.stan', line 1, column 29 to column 30, parsing error:
+   -------------------------------------------------
+     1:  transformed data { foo = bar ~
+                                      ^
+   -------------------------------------------------
+
+Ill-formed assignment statement. Expected a ";" after the value being assigned.
+[exit 1]
+  $ ../../../../../install/default/bin/stanc incomplete9.stan
+Syntax error in 'incomplete9.stan', line 3, column 28 to column 33, parsing error:
+   -------------------------------------------------
+     1:  transformed data {
+     2:    vector[2] foo;
+     3:    row_vector[2] bar = -foo' while
+                                     ^
+     4:  }
+   -------------------------------------------------
+
+Ill-formed expression. Found an expression. Expected an infix or postfix operator or "["
 [exit 1]
   $ ../../../../../install/default/bin/stanc reused_name.stan
 Semantic error in 'reused_name.stan', line 4, column 14 to column 15:
diff --git a/test/integration/bad/new/stanc.expected b/test/integration/bad/new/stanc.expected
@@ -83,18 +83,18 @@ Ill-formed type. Constrained types are not supported in local (or model block) v
   Use "vector" instead.
 [exit 1]
   $ ../../../../../install/default/bin/stanc bad_constrained_type_in_local2.stan
-Syntax error in 'bad_constrained_type_in_local2.stan', line 4, column 4 to column 11, parsing error:
+Syntax error in 'bad_constrained_type_in_local2.stan', line 4, column 4 to column 24, parsing error:
    -------------------------------------------------
-     2:    simplex[2] x;
+     2:    cholesky_factor_corr[2] x;
      3:    {
-     4:      simplex[2] y = x;
+     4:      cholesky_factor_corr[2] y = x;
              ^
      5:      print(y);
      6:    }
    -------------------------------------------------
 
 Ill-formed type. Constrained types are not supported in local (or model block) variable declarations.
-  Use "vector" instead.
+  Use "matrix" instead.
 [exit 1]
   $ ../../../../../install/default/bin/stanc bad_constrained_type_in_model.stan
 Syntax error in 'bad_constrained_type_in_model.stan', line 2, column 11 to column 18, parsing error:
diff --git a/test/integration/bad/profiling/profile-bad7.stan b/test/integration/bad/profiling/profile-bad7.stan
@@ -0,0 +1,3 @@
+transformed data {
+    profile ("") while
+}
diff --git a/test/integration/bad/profiling/profile-bad8.stan b/test/integration/bad/profiling/profile-bad8.stan
@@ -0,0 +1,5 @@
+transformed data {
+    profile ("" {
+        
+    }
+}
diff --git a/test/integration/bad/profiling/stanc.expected b/test/integration/bad/profiling/stanc.expected
@@ -68,4 +68,27 @@ Syntax error in 'profile-bad6.stan', line 2, column 9 to column 16, parsing erro
    -------------------------------------------------
 
 Ill-formed identifier. Expected a new identifier but found reserved keyword "profile".
+[exit 1]
+  $ ../../../../../install/default/bin/stanc profile-bad7.stan
+Syntax error in 'profile-bad7.stan', line 2, column 17 to column 22, parsing error:
+   -------------------------------------------------
+     1:  transformed data {
+     2:      profile ("") while
+                          ^
+     3:  }
+   -------------------------------------------------
+
+Ill-formed statement. Expected "{" to begin profile block.
+[exit 1]
+  $ ../../../../../install/default/bin/stanc profile-bad8.stan
+Syntax error in 'profile-bad8.stan', line 2, column 16 to column 17, parsing error:
+   -------------------------------------------------
+     1:  transformed data {
+     2:      profile ("" {
+                         ^
+     3:          
+     4:      }
+   -------------------------------------------------
+
+Ill-formed statement. Expected ")" after profile name.
 [exit 1]
diff --git a/test/integration/bad/stanc.expected b/test/integration/bad/stanc.expected
@@ -946,6 +946,17 @@ Syntax error in 'err-expected-end-of-model.stan', line 3, column 0 to column 3,
    -------------------------------------------------
 
 Ill-formed program. Expected "generated quantities {" or end of file after end of model block.
+[exit 1]
+  $ ../../../../install/default/bin/stanc err-expected-end-of-tp.stan
+Syntax error in 'err-expected-end-of-tp.stan', line 4, column 0 to column 4, parsing error:
+   -------------------------------------------------
+     2:  
+     3:  }
+     4:  mdel {}
+         ^
+   -------------------------------------------------
+
+Ill-formed program. Expected "model {" or "generated quantities {" after end of transformed parameters block.
 [exit 1]
   $ ../../../../install/default/bin/stanc err-expected-generated.stan
 Syntax error in 'err-expected-generated.stan', line 3, column 0 to column 9, parsing error:

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +transformed parameters {
++
 +}
 +mdel {}
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+array[,,] x() {`
	`2`	`+ return ones_array(3, 3);`
	`3`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+transformed parameters {`
	`2`	`+ jacobian += while;`
	`3`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+transformed data {`
	`2`	`+ vector[2] foo = [ ;`
	`3`	`+}`